You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2015/07/25 02:04:42 UTC
Review Request 36805: Updated slave to always set task status's uuid
in status update.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36805/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Repository: mesos
Description
-------
This should've been done in 0.23.0.
Diffs
-----
src/sched/sched.cpp 1bcc37614c12f1f14f3d0db463f4f851025df658
src/scheduler/scheduler.cpp badc107dbf4e2bd9146f9244724e0db5c2ae05d3
src/slave/slave.cpp dc12c45516ab39d74a5c29b657f22f74d0acf24e
Diff: https://reviews.apache.org/r/36805/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 36805: Updated slave to always set task status's
uuid in status update.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36805/#review93015
-----------------------------------------------------------
Bad patch!
Reviews applied: [36805]
Failed command: ./support/apply-review.sh -n -r 36805
Error:
2015-07-25 00:29:34 URL:https://reviews.apache.org/r/36805/diff/raw/ [2971/2971] -> "36805.patch" [1]
error: patch failed: src/scheduler/scheduler.cpp:625
error: src/scheduler/scheduler.cpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On July 25, 2015, 12:04 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36805/
> -----------------------------------------------------------
>
> (Updated July 25, 2015, 12:04 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This should've been done in 0.23.0.
>
>
> Diffs
> -----
>
> src/sched/sched.cpp 1bcc37614c12f1f14f3d0db463f4f851025df658
> src/scheduler/scheduler.cpp badc107dbf4e2bd9146f9244724e0db5c2ae05d3
> src/slave/slave.cpp dc12c45516ab39d74a5c29b657f22f74d0acf24e
>
> Diff: https://reviews.apache.org/r/36805/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 36805: Updated slave to always set task status's
uuid in status update.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36805/#review93013
-----------------------------------------------------------
Ship it!
Thanks!
- Ben Mahler
On July 25, 2015, 12:04 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36805/
> -----------------------------------------------------------
>
> (Updated July 25, 2015, 12:04 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This should've been done in 0.23.0.
>
>
> Diffs
> -----
>
> src/sched/sched.cpp 1bcc37614c12f1f14f3d0db463f4f851025df658
> src/scheduler/scheduler.cpp badc107dbf4e2bd9146f9244724e0db5c2ae05d3
> src/slave/slave.cpp dc12c45516ab39d74a5c29b657f22f74d0acf24e
>
> Diff: https://reviews.apache.org/r/36805/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>