You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/05/20 02:21:16 UTC
[GitHub] [ozone] kaijchen opened a new pull request, #3434: HDDS-6773. Cleanup TestRDBTableStore
kaijchen opened a new pull request, #3434:
URL: https://github.com/apache/ozone/pull/3434
## What changes were proposed in this pull request?
`rdbStore` is already initialized in `@BeforeEach setUp()`, and closed in `@AfterEach tearDown()`.
Reuse these code in `testIsExist()` and `testGetIfExist()`.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6773
## How was this patch tested?
CI: https://github.com/kaijchen/ozone/actions/runs/2353514330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #3434: HDDS-6773. Cleanup TestRDBTableStore
Posted by GitBox <gi...@apache.org>.
adoroszlai merged PR #3434:
URL: https://github.com/apache/ozone/pull/3434
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kaijchen commented on pull request #3434: HDDS-6773. Cleanup TestRDBTableStore
Posted by GitBox <gi...@apache.org>.
kaijchen commented on PR #3434:
URL: https://github.com/apache/ozone/pull/3434#issuecomment-1171980988
Thanks @adoroszlai for reviewing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kaijchen commented on a diff in pull request #3434: HDDS-6773. Cleanup TestRDBTableStore
Posted by GitBox <gi...@apache.org>.
kaijchen commented on code in PR #3434:
URL: https://github.com/apache/ozone/pull/3434#discussion_r877753737
##########
hadoop-hdds/framework/src/test/java/org/apache/hadoop/hdds/utils/db/TestRDBTableStore.java:
##########
@@ -57,6 +57,10 @@ public class TestRDBTableStore {
private DBOptions options = null;
private static byte[][] bytesOf;
+ @SuppressWarnings("checkstyle:VisibilityModifier")
Review Comment:
We can make `@TempDir` field private after upgrading to `JUnit 5.8`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org