[jira] [Commented] (SCM-807) JGit impl check-in fails unless the Maven project is in the working copy root

["Robert Scholte (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SCM-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991214#comment-15991214 ] 

Robert Scholte commented on SCM-807:
------------------------------------

Having unittests would indeed help. 
And I'm a bit woried about the complete removal of the last block with the comment: {{// if a specific fileSet is given, we have to check if the file is really tracked}}. Not familiar with that piece of code, so can't say if it can be removed safely.

> JGit impl check-in fails unless the Maven project is in the working copy root
> -----------------------------------------------------------------------------
>
>                 Key: SCM-807
>                 URL: https://issues.apache.org/jira/browse/SCM-807
>             Project: Maven SCM
>          Issue Type: Bug
>          Components: maven-scm-provider-gitexe
>    Affects Versions: 1.9.4
>            Reporter: Richard DiCroce
>         Attachments: scm-807.txt
>
>
> Another problem exposed by maven-release-plugin: the JGit SCM implementation's check-in fails unless the Maven project is in the working copy root because it confuses the working copy's location with the Maven project's location.
> The attached patch resolves the issue. Combined with the patch attached to SCM-806, release:prepare now mostly succeeds with the JGit implementation. There is still a problem with the POM not being transformed correctly, but that's a problem in maven-release-plugin.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)