You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/06/21 22:39:26 UTC

[GitHub] [pulsar] rdhabalia opened a new pull request #4580: [managed-ledger] close bk-client factory gracefully

rdhabalia opened a new pull request #4580: [managed-ledger] close bk-client factory gracefully
URL: https://github.com/apache/pulsar/pull/4580
 
 
   ### Motivation
   User can create tools on bookkeeper using ManagedLedger factory which provides [constructor](https://github.com/apache/pulsar/blob/master/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerFactoryImpl.java#L121) to create ml-factory using self-managed bookkeeper (it's not used by broker).
   So, in case of self-managed bk-client, ML-Factory couldn't shutdown it gracefully and we see issue: #4573
   
   ### Modification
   - ML-Factory creates `DefaultBkFactory` to create self-managed bk-client and shutdowns same bk-client while closing the resource. 
   
   cc: @yjshen 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services