You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/21 10:43:19 UTC
[GitHub] [airflow] potiuk opened a new pull request #10442: Do not override in_container scripts when building the image
potiuk opened a new pull request #10442:
URL: https://github.com/apache/airflow/pull/10442
After #10368, we've changed the way we build the images
on CI. We are overriding the ci scripts that we use
to build the image with the scripts taken from master
to not give roque PR authors the possibiility to run
something with the write credentials.
We should not override the in_container scripts, however
because they become part of the image, so we should use
those that came with the PR. That's why we have to move
the "in_container" scripts out of the "ci" folder and
only override the "ci" folder with the one from
master. We've made sure that those scripts in ci
are self-contained and they do not need reach outside of
that folder.
Also the static checks are done with local files mounted
on CI because we want to check all the files - not only
those that are embedded in the container.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10442: Do not override in_container scripts when building the image
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10442:
URL: https://github.com/apache/airflow/pull/10442#issuecomment-678219914
@mik-laj -> this one is needed to fix #10441
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10442: Do not override in_container scripts when building the image
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10442:
URL: https://github.com/apache/airflow/pull/10442#issuecomment-678246535
Fixup: :) . I needed to add perf dir as well:
* https://github.com/potiuk/airflow/actions/runs/218299732
* https://github.com/potiuk/airflow/actions/runs/218299751
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #10442: Do not override in_container scripts when building the image
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #10442:
URL: https://github.com/apache/airflow/pull/10442
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10442: Do not override in_container scripts when building the image
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10442:
URL: https://github.com/apache/airflow/pull/10442#issuecomment-678348127
Looks good: https://github.com/potiuk/airflow/runs/1012859548?check_suite_focus=true pushing it. I had to do another thing - disable the 6000 "skipped" tests in integration tests - they were not needed and with local mounts they caused "blocking I/O" on CI. But it works now :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10442: Do not override in_container scripts when building the image
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10442:
URL: https://github.com/apache/airflow/pull/10442#issuecomment-678235834
Yeah. This one has no chance to pass now as PR because it needs to be merged to get working but I am running the build in my own forks' master. The trouble with "workflow_run" that if we want to change anything in the build process, we need to push it to master somewhere to test it :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10442: Do not override in_container scripts when building the image
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10442:
URL: https://github.com/apache/airflow/pull/10442#issuecomment-678236502
Main build here: https://github.com/potiuk/airflow/actions/runs/218264558
And Build image here: https://github.com/potiuk/airflow/actions/runs/218264569
Once they pass some basic steps I will merge it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org