You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/02/14 18:54:01 UTC
[GitHub] [solr] madrob opened a new pull request #634: SOLR-15972 Add wrapper jar and export-ignore attr
madrob opened a new pull request #634:
URL: https://github.com/apache/solr/pull/634
Tested via: git archive --format tgz HEAD | tar -zt | grep wrapper
https://issues.apache.org/jira/browse/SOLR-15972
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dweiss commented on pull request #634: SOLR-15972 Add wrapper jar and export-ignore attr
Posted by GitBox <gi...@apache.org>.
dweiss commented on pull request #634:
URL: https://github.com/apache/solr/pull/634#issuecomment-1042735790
I'm +0. My view is very polarized - either remove the gradle wrapper download infrastructure or use it for what it was added. Occam's razor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob commented on pull request #634: SOLR-15972 Add wrapper jar and export-ignore attr
Posted by GitBox <gi...@apache.org>.
madrob commented on pull request #634:
URL: https://github.com/apache/solr/pull/634#issuecomment-1040257551
I'm just trying to make my internal, non internet accessible CI work. Like I said on the Jira, I have a maven mirror but not a GitHub mirror. I suppose the other option is that I install gradle from somewhere and use that instead of the wrapper?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob closed pull request #634: SOLR-15972 Add wrapper jar and export-ignore attr
Posted by GitBox <gi...@apache.org>.
madrob closed pull request #634:
URL: https://github.com/apache/solr/pull/634
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dweiss commented on pull request #634: SOLR-15972 Add wrapper jar and export-ignore attr
Posted by GitBox <gi...@apache.org>.
dweiss commented on pull request #634:
URL: https://github.com/apache/solr/pull/634#issuecomment-1040213606
I'm not sure why you want to have the wrapper versioned - for me it's one way or the other. Since you can't publish it in source releases and the infrastructure to automatically download it is in place - why add things to make it more complicated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dweiss commented on pull request #634: SOLR-15972 Add wrapper jar and export-ignore attr
Posted by GitBox <gi...@apache.org>.
dweiss commented on pull request #634:
URL: https://github.com/apache/solr/pull/634#issuecomment-1040213606
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob commented on pull request #634: SOLR-15972 Add wrapper jar and export-ignore attr
Posted by GitBox <gi...@apache.org>.
madrob commented on pull request #634:
URL: https://github.com/apache/solr/pull/634#issuecomment-1040257551
I'm just trying to make my internal, non internet accessible CI work. Like I said on the Jira, I have a maven mirror but not a GitHub mirror. I suppose the other option is that I install gradle from somewhere and use that instead of the wrapper?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dweiss commented on pull request #634: SOLR-15972 Add wrapper jar and export-ignore attr
Posted by GitBox <gi...@apache.org>.
dweiss commented on pull request #634:
URL: https://github.com/apache/solr/pull/634#issuecomment-1040280634
bq. I'm just trying to make my internal, non internet accessible CI work
Fair enough. The only thing that comes to my mind is to download the wrapper manually and place it where it should be placed then. Another alternative for isolated networks would be a git mirror with that wrapper checked in on a downstream branch.
bq. I suppose the other option is that I install gradle from somewhere and use that instead of the wrapper?
Yes, if it's the same version, it'll work just fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob commented on pull request #634: SOLR-15972 Add wrapper jar and export-ignore attr
Posted by GitBox <gi...@apache.org>.
madrob commented on pull request #634:
URL: https://github.com/apache/solr/pull/634#issuecomment-1043430347
I ended up being able to install the full gradle version and use that for CI instead of trying to hack around the wrapper being missing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org