You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Till Toenshoff <to...@me.com> on 2014/06/03 02:47:10 UTC
Review Request 22169: Added External Containerizer documentation.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22169/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos-git
Description
-------
Adds a markdown document describing the ExternalContainerizer.
Diffs
-----
docs/external-containerizer.md PRE-CREATION
docs/home.md 6a512de
Diff: https://reviews.apache.org/r/22169/diff/
Testing
-------
Thanks,
Till Toenshoff
Re: Review Request 22169: Added External Containerizer documentation.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22169/#review52520
-----------------------------------------------------------
Patch looks great!
Reviews applied: [22169]
All tests passed.
- Mesos ReviewBot
On Sept. 5, 2014, 8:48 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22169/
> -----------------------------------------------------------
>
> (Updated Sept. 5, 2014, 8:48 a.m.)
>
>
> Review request for mesos and Tom Arnfeld.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Adds a markdown document describing the ExternalContainerizer.
>
>
> Diffs
> -----
>
> docs/external-containerizer.md PRE-CREATION
> docs/home.md 179a164
> docs/images/ec_kill_seqdiag.png PRE-CREATION
> docs/images/ec_launch_seqdiag.png PRE-CREATION
> docs/images/ec_lifecycle_seqdiag.png PRE-CREATION
> docs/images/ec_orphan_seqdiag.png PRE-CREATION
> docs/images/ec_recover_seqdiag.png PRE-CREATION
>
> Diff: https://reviews.apache.org/r/22169/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 22169: Added External Containerizer documentation.
Posted by Till Toenshoff <to...@me.com>.
> On Sept. 30, 2014, 11:51 p.m., Niklas Nielsen wrote:
> > Fly by review - it is much better than the current (non-existing) docs on the EC. So I think we should land this asap :-) Tom, do you have cycles to review?
Will try to ping Tom directly on that.
> On Sept. 30, 2014, 11:51 p.m., Niklas Nielsen wrote:
> > docs/external-containerizer.md, line 139
> > <https://reviews.apache.org/r/22169/diff/3/?file=680236#file680236line139>
> >
> > Worth making the paths relative?
Fixed. Will commit this very soon.
- Till
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22169/#review55024
-----------------------------------------------------------
On Nov. 5, 2014, 4 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22169/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2014, 4 p.m.)
>
>
> Review request for mesos and Tom Arnfeld.
>
>
> Bugs: MESOS-2045
> https://issues.apache.org/jira/browse/MESOS-2045
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Adds a markdown document describing the ExternalContainerizer.
>
>
> Diffs
> -----
>
> docs/external-containerizer.md PRE-CREATION
> docs/home.md 7afc4a3
> docs/images/ec_kill_seqdiag.png PRE-CREATION
> docs/images/ec_launch_seqdiag.png PRE-CREATION
> docs/images/ec_lifecycle_seqdiag.png PRE-CREATION
> docs/images/ec_orphan_seqdiag.png PRE-CREATION
> docs/images/ec_recover_seqdiag.png PRE-CREATION
>
> Diff: https://reviews.apache.org/r/22169/diff/
>
>
> Testing
> -------
>
> see https://github.com/tillt/mesos/blob/master/docs/external-containerizer.md
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 22169: Added External Containerizer documentation.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22169/#review55024
-----------------------------------------------------------
Fly by review - it is much better than the current (non-existing) docs on the EC. So I think we should land this asap :-) Tom, do you have cycles to review?
docs/external-containerizer.md
<https://reviews.apache.org/r/22169/#comment95357>
Worth making the paths relative?
- Niklas Nielsen
On Sept. 5, 2014, 1:48 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22169/
> -----------------------------------------------------------
>
> (Updated Sept. 5, 2014, 1:48 a.m.)
>
>
> Review request for mesos and Tom Arnfeld.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Adds a markdown document describing the ExternalContainerizer.
>
>
> Diffs
> -----
>
> docs/external-containerizer.md PRE-CREATION
> docs/home.md 179a164
> docs/images/ec_kill_seqdiag.png PRE-CREATION
> docs/images/ec_launch_seqdiag.png PRE-CREATION
> docs/images/ec_lifecycle_seqdiag.png PRE-CREATION
> docs/images/ec_orphan_seqdiag.png PRE-CREATION
> docs/images/ec_recover_seqdiag.png PRE-CREATION
>
> Diff: https://reviews.apache.org/r/22169/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 22169: Added External Containerizer documentation.
Posted by Till Toenshoff <to...@me.com>.
> On Nov. 5, 2014, 12:35 p.m., Tom Arnfeld wrote:
> > LGTM! Yeah, relative URLs would be a good idea.
Aye, fixed that.
- Till
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22169/#review59951
-----------------------------------------------------------
On Nov. 5, 2014, 4 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22169/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2014, 4 p.m.)
>
>
> Review request for mesos and Tom Arnfeld.
>
>
> Bugs: MESOS-2045
> https://issues.apache.org/jira/browse/MESOS-2045
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Adds a markdown document describing the ExternalContainerizer.
>
>
> Diffs
> -----
>
> docs/external-containerizer.md PRE-CREATION
> docs/home.md 7afc4a3
> docs/images/ec_kill_seqdiag.png PRE-CREATION
> docs/images/ec_launch_seqdiag.png PRE-CREATION
> docs/images/ec_lifecycle_seqdiag.png PRE-CREATION
> docs/images/ec_orphan_seqdiag.png PRE-CREATION
> docs/images/ec_recover_seqdiag.png PRE-CREATION
>
> Diff: https://reviews.apache.org/r/22169/diff/
>
>
> Testing
> -------
>
> see https://github.com/tillt/mesos/blob/master/docs/external-containerizer.md
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 22169: Added External Containerizer documentation.
Posted by Tom Arnfeld <ta...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22169/#review59951
-----------------------------------------------------------
Ship it!
LGTM! Yeah, relative URLs would be a good idea.
- Tom Arnfeld
On Sept. 5, 2014, 8:48 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22169/
> -----------------------------------------------------------
>
> (Updated Sept. 5, 2014, 8:48 a.m.)
>
>
> Review request for mesos and Tom Arnfeld.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Adds a markdown document describing the ExternalContainerizer.
>
>
> Diffs
> -----
>
> docs/external-containerizer.md PRE-CREATION
> docs/home.md 179a164
> docs/images/ec_kill_seqdiag.png PRE-CREATION
> docs/images/ec_launch_seqdiag.png PRE-CREATION
> docs/images/ec_lifecycle_seqdiag.png PRE-CREATION
> docs/images/ec_orphan_seqdiag.png PRE-CREATION
> docs/images/ec_recover_seqdiag.png PRE-CREATION
>
> Diff: https://reviews.apache.org/r/22169/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 22169: Added External Containerizer documentation.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22169/
-----------------------------------------------------------
(Updated Nov. 5, 2014, 4 p.m.)
Review request for mesos and Tom Arnfeld.
Bugs: MESOS-2045
https://issues.apache.org/jira/browse/MESOS-2045
Repository: mesos-git
Description
-------
Adds a markdown document describing the ExternalContainerizer.
Diffs
-----
docs/external-containerizer.md PRE-CREATION
docs/home.md 7afc4a3
docs/images/ec_kill_seqdiag.png PRE-CREATION
docs/images/ec_launch_seqdiag.png PRE-CREATION
docs/images/ec_lifecycle_seqdiag.png PRE-CREATION
docs/images/ec_orphan_seqdiag.png PRE-CREATION
docs/images/ec_recover_seqdiag.png PRE-CREATION
Diff: https://reviews.apache.org/r/22169/diff/
Testing (updated)
-------
see https://github.com/tillt/mesos/blob/master/docs/external-containerizer.md
Thanks,
Till Toenshoff
Re: Review Request 22169: Added External Containerizer documentation.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22169/
-----------------------------------------------------------
(Updated Nov. 5, 2014, 3:58 p.m.)
Review request for mesos and Tom Arnfeld.
Changes
-------
Updated towards relative URLs and included a missing image.
Bugs: MESOS-2045
https://issues.apache.org/jira/browse/MESOS-2045
Repository: mesos-git
Description
-------
Adds a markdown document describing the ExternalContainerizer.
Diffs (updated)
-----
docs/external-containerizer.md PRE-CREATION
docs/home.md 7afc4a3
docs/images/ec_kill_seqdiag.png PRE-CREATION
docs/images/ec_launch_seqdiag.png PRE-CREATION
docs/images/ec_lifecycle_seqdiag.png PRE-CREATION
docs/images/ec_orphan_seqdiag.png PRE-CREATION
docs/images/ec_recover_seqdiag.png PRE-CREATION
Diff: https://reviews.apache.org/r/22169/diff/
Testing
-------
Thanks,
Till Toenshoff
Re: Review Request 22169: Added External Containerizer documentation.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22169/
-----------------------------------------------------------
(Updated Sept. 5, 2014, 8:48 a.m.)
Review request for mesos and Tom Arnfeld.
Changes
-------
Added more sequence diagrams and linked into home.md.
Repository: mesos-git
Description
-------
Adds a markdown document describing the ExternalContainerizer.
Diffs (updated)
-----
docs/external-containerizer.md PRE-CREATION
docs/home.md 179a164
docs/images/ec_kill_seqdiag.png PRE-CREATION
docs/images/ec_launch_seqdiag.png PRE-CREATION
docs/images/ec_lifecycle_seqdiag.png PRE-CREATION
docs/images/ec_orphan_seqdiag.png PRE-CREATION
docs/images/ec_recover_seqdiag.png PRE-CREATION
Diff: https://reviews.apache.org/r/22169/diff/
Testing
-------
Thanks,
Till Toenshoff
Re: Review Request 22169: Added External Containerizer documentation.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22169/#review44837
-----------------------------------------------------------
Patch looks great!
Reviews applied: [22169]
All tests passed.
- Mesos ReviewBot
On June 4, 2014, 6:05 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22169/
> -----------------------------------------------------------
>
> (Updated June 4, 2014, 6:05 a.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Adds a markdown document describing the ExternalContainerizer.
>
>
> Diffs
> -----
>
> docs/external-containerizer.md PRE-CREATION
> docs/home.md 6a512de
> docs/images/ec-launch-seqdiag.png PRE-CREATION
> docs/images/ec-recover-seqdiag.png PRE-CREATION
>
> Diff: https://reviews.apache.org/r/22169/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 22169: Added External Containerizer documentation.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22169/
-----------------------------------------------------------
(Updated June 4, 2014, 6:05 a.m.)
Review request for mesos.
Changes
-------
Added sequence diagrams for task lifecycle and slave recovery.
Repository: mesos-git
Description
-------
Adds a markdown document describing the ExternalContainerizer.
Diffs (updated)
-----
docs/external-containerizer.md PRE-CREATION
docs/home.md 6a512de
docs/images/ec-launch-seqdiag.png PRE-CREATION
docs/images/ec-recover-seqdiag.png PRE-CREATION
Diff: https://reviews.apache.org/r/22169/diff/
Testing
-------
Thanks,
Till Toenshoff