You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Aleksandr Sorokoumov (Jira)" <ji...@apache.org> on 2021/09/18 16:04:00 UTC
[jira] [Created] (CASSANDRA-16975) CompactionTask#runMayThrow
should not remove new SSTables from the tracker for offline transactions
Aleksandr Sorokoumov created CASSANDRA-16975:
------------------------------------------------
Summary: CompactionTask#runMayThrow should not remove new SSTables from the tracker for offline transactions
Key: CASSANDRA-16975
URL: https://issues.apache.org/jira/browse/CASSANDRA-16975
Project: Cassandra
Issue Type: Bug
Components: Local/Compaction
Reporter: Aleksandr Sorokoumov
Assignee: Aleksandr Sorokoumov
Right now, {{CompactionTask#runMayThrow}} removes new SSTables from the tracker for offline transactions ([code|https://github.com/apache/cassandra/blob/f7c71f65c000c2c3ef7df1b034b8fdd822a396d8/src/java/org/apache/cassandra/db/compaction/CompactionTask.java#L227-L230]). This change was added in CASSANDRA-8962, prior to the introduction of lifecycle transactions in CASSANDRA-8568. I suspect that this behavior might be undesired and could have just fallen through the cracks.
To my knowledge, this code does not cause any known bugs solely because in-tree tools do not access the SSTables they produce before exiting. However, if someone is to write, say, offline compaction daemon, it might break on subsequent iterations because newly created SSTables won't be in the tracker.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org