You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2016/04/19 18:35:23 UTC
Review Request 46395: Windows: Removed `std::bind` from `process.cpp`
to build on Windows.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46395/
-----------------------------------------------------------
Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
Bugs: MESOS-3637
https://issues.apache.org/jira/browse/MESOS-3637
Repository: mesos
Description
-------
Windows: Removed `std::bind` from `process.cpp` to build on Windows.
Diffs
-----
3rdparty/libprocess/src/process.cpp d2c458ed93307f75358bb642aaf2ed8e17b2fe97
Diff: https://reviews.apache.org/r/46395/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 46395: Windows: Removed `std::bind` from
`process.cpp` to build on Windows.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46395/#review129644
-----------------------------------------------------------
Patch looks great!
Reviews applied: [46393, 46395]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 19, 2016, 4:35 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46395/
> -----------------------------------------------------------
>
> (Updated April 19, 2016, 4:35 p.m.)
>
>
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
>
>
> Bugs: MESOS-3637
> https://issues.apache.org/jira/browse/MESOS-3637
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Removed `std::bind` from `process.cpp` to build on Windows.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp d2c458ed93307f75358bb642aaf2ed8e17b2fe97
>
> Diff: https://reviews.apache.org/r/46395/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 46395: Windows: Removed `std::bind` from
`process.cpp` to build on Windows.
Posted by Alex Clemmer <cl...@gmail.com>.
> On April 22, 2016, 10:04 p.m., Joris Van Remoortere wrote:
> > 3rdparty/libprocess/src/process.cpp, line 897
> > <https://reviews.apache.org/r/46395/diff/1/?file=1350657#file1350657line897>
> >
> > space between `(char*)` and `&on`
Let's actually make it a C++ cast.
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46395/#review130196
-----------------------------------------------------------
On April 19, 2016, 4:35 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46395/
> -----------------------------------------------------------
>
> (Updated April 19, 2016, 4:35 p.m.)
>
>
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
>
>
> Bugs: MESOS-3637
> https://issues.apache.org/jira/browse/MESOS-3637
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Removed `std::bind` from `process.cpp` to build on Windows.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp d2c458ed93307f75358bb642aaf2ed8e17b2fe97
>
> Diff: https://reviews.apache.org/r/46395/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 46395: Windows: Removed `std::bind` from
`process.cpp` to build on Windows.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46395/#review130196
-----------------------------------------------------------
Fix it, then Ship it!
3rdparty/libprocess/src/process.cpp (lines 13 - 40)
<https://reviews.apache.org/r/46395/#comment193892>
Please leave these in the original order and use the smaller `#ifndef __WINDOWS__` blocks where needed. I think the 3? places necessary are still clean enough to keep the original ordering.
3rdparty/libprocess/src/process.cpp (line 888)
<https://reviews.apache.org/r/46395/#comment193893>
space between `(char*)` and `&on`
- Joris Van Remoortere
On April 19, 2016, 4:35 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46395/
> -----------------------------------------------------------
>
> (Updated April 19, 2016, 4:35 p.m.)
>
>
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
>
>
> Bugs: MESOS-3637
> https://issues.apache.org/jira/browse/MESOS-3637
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Removed `std::bind` from `process.cpp` to build on Windows.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp d2c458ed93307f75358bb642aaf2ed8e17b2fe97
>
> Diff: https://reviews.apache.org/r/46395/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 46395: Windows: Removed `std::bind` from
`process.cpp` to build on Windows.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46395/
-----------------------------------------------------------
(Updated April 23, 2016, 11:26 p.m.)
Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
Bugs: MESOS-3637
https://issues.apache.org/jira/browse/MESOS-3637
Repository: mesos
Description
-------
Windows: Removed `std::bind` from `process.cpp` to build on Windows.
Diffs (updated)
-----
3rdparty/libprocess/src/process.cpp 8727eb202e9699f0ac3c95788257cf1a22b0da7b
Diff: https://reviews.apache.org/r/46395/diff/
Testing
-------
Thanks,
Alex Clemmer