You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by "Benoit Chesneau (Created) (JIRA)" <ji...@apache.org> on 2011/12/05 21:52:40 UTC
[jira] [Created] (COUCHDB-1355) split code & create couch_httpd
application
split code & create couch_httpd application
-------------------------------------------
Key: COUCHDB-1355
URL: https://issues.apache.org/jira/browse/COUCHDB-1355
Project: CouchDB
Issue Type: Improvement
Components: Database Core, HTTP Interface
Affects Versions: 1.3
Reporter: Benoit Chesneau
Fix For: 1.3
Couchdb is still to monolithic. This tcicket track changes to extract CouchDB HTTP API as a full application.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COUCHDB-1355) split code & create couch_httpd
application
Posted by "Paul Joseph Davis (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13169037#comment-13169037 ]
Paul Joseph Davis commented on COUCHDB-1355:
--------------------------------------------
Commencing brain dump review:
0001
* src/Makefile.am indentation looks wrong for src/couch_httpd
* include files is empty, but this might change in the next patch so just a note to self
* We do a thing for couch.app.src in couchdb so we can set the module list automatically. Should we duplicate that here?
* couch_httpd.app is missing the module to start the app
0002
* Yep, record moved. Looks good.
* Whitespace only hunk at the bottom of 0002
0003
* I'm not entirely certain about this patch. What's the circular dependency? If it's just records in include files I don't think I'd bother making the split as it seems a bit awkward.
* The couch_changes.app reminds me we should be listing dependencies better as we do this. Not super urgent but a thing to think about.
This also brings up how we want to handle things like the httpd code for views. If anyone has good ideas we should open a ticket and discuss a plan of some sort on how to handle this going forward. I'm thinking specifically that the couch_httpd is separate from couch, but couch_changes and couch_mrview have their httpd code in those apps.
> split code & create couch_httpd application
> -------------------------------------------
>
> Key: COUCHDB-1355
> URL: https://issues.apache.org/jira/browse/COUCHDB-1355
> Project: CouchDB
> Issue Type: Improvement
> Components: Database Core, HTTP Interface
> Affects Versions: 1.3
> Reporter: Benoit Chesneau
> Assignee: Benoit Chesneau
> Fix For: 1.3
>
> Attachments: 0001-couch_httpd-application.patch, 0002-move-httpd-record-in-couch_httpd-include-couch_httpd.patch, 0003-create-couch_changes-application.-Fix-tests-and-allo.patch
>
>
> Couchdb is still to monolithic. This tcicket track changes to extract CouchDB HTTP API as a full application.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COUCHDB-1355) split code & create couch_httpd
application
Posted by "Paul Joseph Davis (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166221#comment-13166221 ]
Paul Joseph Davis commented on COUCHDB-1355:
--------------------------------------------
I'll try and get a review of this done today. I skimmed and didn't see anything major but I want to go over some of the build stuff and startup in a bit more detail before I can comment more thoroughly.
> split code & create couch_httpd application
> -------------------------------------------
>
> Key: COUCHDB-1355
> URL: https://issues.apache.org/jira/browse/COUCHDB-1355
> Project: CouchDB
> Issue Type: Improvement
> Components: Database Core, HTTP Interface
> Affects Versions: 1.3
> Reporter: Benoit Chesneau
> Assignee: Benoit Chesneau
> Fix For: 1.3
>
> Attachments: 0001-couch_httpd-application.patch, 0002-move-httpd-record-in-couch_httpd-include-couch_httpd.patch, 0003-create-couch_changes-application.-Fix-tests-and-allo.patch
>
>
> Couchdb is still to monolithic. This tcicket track changes to extract CouchDB HTTP API as a full application.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COUCHDB-1355) split code & create couch_httpd
application
Posted by "Benoit Chesneau (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163036#comment-13163036 ]
Benoit Chesneau commented on COUCHDB-1355:
------------------------------------------
I posted changes on my github repository in the couch_httpd branch :
https://github.com/benoitc/couchdb/compare/master...couch_httpd
> split code & create couch_httpd application
> -------------------------------------------
>
> Key: COUCHDB-1355
> URL: https://issues.apache.org/jira/browse/COUCHDB-1355
> Project: CouchDB
> Issue Type: Improvement
> Components: Database Core, HTTP Interface
> Affects Versions: 1.3
> Reporter: Benoit Chesneau
> Fix For: 1.3
>
> Attachments: 0001-couch_httpd-application.patch, 0002-move-httpd-record-in-couch_httpd-include-couch_httpd.patch, 0003-create-couch_changes-application.-Fix-tests-and-allo.patch
>
>
> Couchdb is still to monolithic. This tcicket track changes to extract CouchDB HTTP API as a full application.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (COUCHDB-1355) split code & create couch_httpd
application
Posted by "Benoit Chesneau (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benoit Chesneau updated COUCHDB-1355:
-------------------------------------
Attachment: 0003-create-couch_changes-application.-Fix-tests-and-allo.patch
0002-move-httpd-record-in-couch_httpd-include-couch_httpd.patch
0001-couch_httpd-application.patch
IAttached are 3 patches to extract the HTTP api as in its own folder/app. First patch [0001] is moving couch_httpd* in their own application named couch_httpd and make sure tests still pass. Second [0002] is moving #httpd record in couch_httpd/include/couch_httpd.hrl instead having it in couch_db.hrl, the third [0003] one create a couch_changes applications (extracting couch changes API from couchdb & couch_httpd applications to remove any circular dependancies and make sure couchdb doesn't use #httpd record. Also by doing this it allows to manage couch_changes API more consistant and usable by other couchdb applications.
All tests pass.
> split code & create couch_httpd application
> -------------------------------------------
>
> Key: COUCHDB-1355
> URL: https://issues.apache.org/jira/browse/COUCHDB-1355
> Project: CouchDB
> Issue Type: Improvement
> Components: Database Core, HTTP Interface
> Affects Versions: 1.3
> Reporter: Benoit Chesneau
> Fix For: 1.3
>
> Attachments: 0001-couch_httpd-application.patch, 0002-move-httpd-record-in-couch_httpd-include-couch_httpd.patch, 0003-create-couch_changes-application.-Fix-tests-and-allo.patch
>
>
> Couchdb is still to monolithic. This tcicket track changes to extract CouchDB HTTP API as a full application.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (COUCHDB-1355) split code & create couch_httpd
application
Posted by "Benoit Chesneau (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benoit Chesneau reassigned COUCHDB-1355:
----------------------------------------
Assignee: Benoit Chesneau
> split code & create couch_httpd application
> -------------------------------------------
>
> Key: COUCHDB-1355
> URL: https://issues.apache.org/jira/browse/COUCHDB-1355
> Project: CouchDB
> Issue Type: Improvement
> Components: Database Core, HTTP Interface
> Affects Versions: 1.3
> Reporter: Benoit Chesneau
> Assignee: Benoit Chesneau
> Fix For: 1.3
>
> Attachments: 0001-couch_httpd-application.patch, 0002-move-httpd-record-in-couch_httpd-include-couch_httpd.patch, 0003-create-couch_changes-application.-Fix-tests-and-allo.patch
>
>
> Couchdb is still to monolithic. This tcicket track changes to extract CouchDB HTTP API as a full application.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COUCHDB-1355) split code & create couch_httpd
application
Posted by "Benoit Chesneau (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166006#comment-13166006 ]
Benoit Chesneau commented on COUCHDB-1355:
------------------------------------------
bump
> split code & create couch_httpd application
> -------------------------------------------
>
> Key: COUCHDB-1355
> URL: https://issues.apache.org/jira/browse/COUCHDB-1355
> Project: CouchDB
> Issue Type: Improvement
> Components: Database Core, HTTP Interface
> Affects Versions: 1.3
> Reporter: Benoit Chesneau
> Fix For: 1.3
>
> Attachments: 0001-couch_httpd-application.patch, 0002-move-httpd-record-in-couch_httpd-include-couch_httpd.patch, 0003-create-couch_changes-application.-Fix-tests-and-allo.patch
>
>
> Couchdb is still to monolithic. This tcicket track changes to extract CouchDB HTTP API as a full application.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Work started] (COUCHDB-1355) split code & create
couch_httpd application
Posted by "Benoit Chesneau (Work started) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on COUCHDB-1355 started by Benoit Chesneau.
> split code & create couch_httpd application
> -------------------------------------------
>
> Key: COUCHDB-1355
> URL: https://issues.apache.org/jira/browse/COUCHDB-1355
> Project: CouchDB
> Issue Type: Improvement
> Components: Database Core, HTTP Interface
> Affects Versions: 1.3
> Reporter: Benoit Chesneau
> Assignee: Benoit Chesneau
> Fix For: 1.3
>
> Attachments: 0001-couch_httpd-application.patch, 0002-move-httpd-record-in-couch_httpd-include-couch_httpd.patch, 0003-create-couch_changes-application.-Fix-tests-and-allo.patch
>
>
> Couchdb is still to monolithic. This tcicket track changes to extract CouchDB HTTP API as a full application.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira