You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "Superskyyy (via GitHub)" <gi...@apache.org> on 2023/03/15 05:03:41 UTC
[GitHub] [skywalking-python] Superskyyy opened a new pull request, #294: Remove dead MIT gpg site and fix release command
Superskyyy opened a new pull request, #294:
URL: https://github.com/apache/skywalking-python/pull/294
1. MIT gpg site is gone, replaced with ubuntu keyserver.
2. Release command was previously wrong, now fixed.
<!--
⚠️ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
<!-- ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👇 ====
### Fix <bug description or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [ ] Explain briefly why the bug exists and how to fix it.
==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👆 ==== -->
<!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking/blob/master/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👆 ==== -->
<!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👇 ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
- [ ] I have rebuilt the `Configuration.md` documentation by running `make doc-gen`
==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== -->
<!-- ==== 📱 Remove this line WHEN AND ONLY WHEN you're adding or modifying a plugin instrumentation, follow the checklist 👇 ====
### <Feature description>
- [ ] If adding a new plugin, add a component id in [the main repo](https://github.com/apache/skywalking/blob/master/oap-server/server-starter/src/main/resources/component-libraries.yml)
- [ ] If adding a new plugin, add a logo in [the UI repo](https://github.com/apache/skywalking-booster-ui/tree/main/src/assets/img/technologies)
- [ ] I have added the library to `pyproject.toml` (plugin group) by running `poetry add library --group plugins`
- [ ] I have rebuilt the `Plugins.md` documentation by running `make doc-gen`
==== 📱 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== -->
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue url. Closes: <URL to main repo issue>
- [ ] Update the [`CHANGELOG.md`](https://github.com/apache/skywalking-python/blob/master/CHANGELOG.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] wu-sheng commented on a diff in pull request #294: Remove dead MIT gpg site and fix release command
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #294:
URL: https://github.com/apache/skywalking-python/pull/294#discussion_r1136599114
##########
docs/en/contribution/How-to-release.md:
##########
@@ -10,7 +10,7 @@ This documentation guides the release manager to release the SkyWalking Python i
## Add your GPG public key to Apache svn
-1. Upload your GPG public key to a public GPG site, such as [MIT's site](http://pgp.mit.edu:11371/).
+1. Upload your GPG public key to a public GPG site, such as [Ubuntu's GPG keyserver](https://keyserver.ubuntu.com/).
Review Comment:
Is this an official rename?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] kezhenxu94 commented on a diff in pull request #294: Remove dead MIT gpg site and fix release command
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on code in PR #294:
URL: https://github.com/apache/skywalking-python/pull/294#discussion_r1140843362
##########
docs/en/contribution/How-to-release.md:
##########
@@ -7,16 +7,6 @@ This documentation guides the release manager to release the SkyWalking Python i
1. Close (if finished, or move to next milestone otherwise) all issues in the current milestone from [skywalking-python](https://github.com/apache/skywalking-python/milestones) and [skywalking](https://github.com/apache/skywalking/milestones), create a new milestone if needed.
2. Update CHANGELOG.md and `version` in `pyproject.toml`.
-
-## Add your GPG public key to Apache svn
-
-1. Upload your GPG public key to a public GPG site, such as [MIT's site](http://pgp.mit.edu:11371/).
-
-1. Log in [id.apache.org](https://id.apache.org/) and submit your key fingerprint.
-
-1. Add your GPG public key into [SkyWalking GPG KEYS](https://dist.apache.org/repos/dist/release/skywalking/KEYS) file, **you can do this only if you are a PMC member**. You can ask a PMC member for help. **DO NOT override the existed `KEYS` file content, only append your key at the end of the file.**
Review Comment:
This step is needed however, the vote and the users need this to check the tars are signed by the release manager.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] Superskyyy commented on a diff in pull request #294: Remove dead MIT gpg site and fix release command
Posted by "Superskyyy (via GitHub)" <gi...@apache.org>.
Superskyyy commented on code in PR #294:
URL: https://github.com/apache/skywalking-python/pull/294#discussion_r1146926871
##########
docs/en/contribution/How-to-release.md:
##########
@@ -7,16 +7,6 @@ This documentation guides the release manager to release the SkyWalking Python i
1. Close (if finished, or move to next milestone otherwise) all issues in the current milestone from [skywalking-python](https://github.com/apache/skywalking-python/milestones) and [skywalking](https://github.com/apache/skywalking/milestones), create a new milestone if needed.
2. Update CHANGELOG.md and `version` in `pyproject.toml`.
-
-## Add your GPG public key to Apache svn
-
-1. Upload your GPG public key to a public GPG site, such as [MIT's site](http://pgp.mit.edu:11371/).
-
-1. Log in [id.apache.org](https://id.apache.org/) and submit your key fingerprint.
-
-1. Add your GPG public key into [SkyWalking GPG KEYS](https://dist.apache.org/repos/dist/release/skywalking/KEYS) file, **you can do this only if you are a PMC member**. You can ask a PMC member for help. **DO NOT override the existed `KEYS` file content, only append your key at the end of the file.**
Review Comment:
Fixed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] Superskyyy commented on a diff in pull request #294: Remove dead MIT gpg site and fix release command
Posted by "Superskyyy (via GitHub)" <gi...@apache.org>.
Superskyyy commented on code in PR #294:
URL: https://github.com/apache/skywalking-python/pull/294#discussion_r1137442493
##########
docs/en/contribution/How-to-release.md:
##########
@@ -10,7 +10,7 @@ This documentation guides the release manager to release the SkyWalking Python i
## Add your GPG public key to Apache svn
-1. Upload your GPG public key to a public GPG site, such as [MIT's site](http://pgp.mit.edu:11371/).
+1. Upload your GPG public key to a public GPG site, such as [Ubuntu's GPG keyserver](https://keyserver.ubuntu.com/).
Review Comment:
> Or simply mit one is gone? The reason I asked is about Maven release, the nexus will use some gpg servers to access public keys for verification. This is why it is mentioned in Java release, and copied here.
I think the MIT one is gone and won't come back any more. Last time I did Python agent release, the MIT site was already broken so I used the Ubuntu keyserver and it worked perfectly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] wu-sheng commented on a diff in pull request #294: Remove dead MIT gpg site and fix release command
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #294:
URL: https://github.com/apache/skywalking-python/pull/294#discussion_r1136600875
##########
docs/en/contribution/How-to-release.md:
##########
@@ -10,7 +10,7 @@ This documentation guides the release manager to release the SkyWalking Python i
## Add your GPG public key to Apache svn
-1. Upload your GPG public key to a public GPG site, such as [MIT's site](http://pgp.mit.edu:11371/).
+1. Upload your GPG public key to a public GPG site, such as [Ubuntu's GPG keyserver](https://keyserver.ubuntu.com/).
Review Comment:
Or simply mit one is gone?
The reason I asked is about Maven release, the nexus will use some gpg servers to access public keys for verification. This is why it is mentioned in Java release, and copied here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] Superskyyy commented on a diff in pull request #294: Remove dead MIT gpg site and fix release command
Posted by "Superskyyy (via GitHub)" <gi...@apache.org>.
Superskyyy commented on code in PR #294:
URL: https://github.com/apache/skywalking-python/pull/294#discussion_r1140536536
##########
Makefile:
##########
@@ -130,6 +130,6 @@ clean:
.PHONY: release
release: clean lint license
- -tar -zcvf skywalking-python-src-$(VERSION).tgz --exclude .venv *
- gpg --batch --yes --armor --detach-sig skywalking-python-src-$(VERSION).tgz
- shasum -a 512 skywalking-python-src-$(VERSION).tgz > skywalking-python-src-$(VERSION).tgz.sha512
+ tar -zcvf skywalking-python-src-$VERSION.tgz --exclude .venv *
+ gpg --batch --yes --armor --detach-sig skywalking-python-src-$VERSION.tgz
Review Comment:
So you mean this line should also be removed right?@kezhenxu94
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] kezhenxu94 commented on a diff in pull request #294: Remove dead MIT gpg site and fix release command
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on code in PR #294:
URL: https://github.com/apache/skywalking-python/pull/294#discussion_r1140844979
##########
docs/en/contribution/How-to-release.md:
##########
@@ -10,7 +10,7 @@ This documentation guides the release manager to release the SkyWalking Python i
## Add your GPG public key to Apache svn
-1. Upload your GPG public key to a public GPG site, such as [MIT's site](http://pgp.mit.edu:11371/).
+1. Upload your GPG public key to a public GPG site, such as [Ubuntu's GPG keyserver](https://keyserver.ubuntu.com/).
Review Comment:
> Uploading gpg key to a public server
The other step "upload the key to Apache svn " is still needed 🤭
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] Superskyyy commented on a diff in pull request #294: Remove dead MIT gpg site and fix release command
Posted by "Superskyyy (via GitHub)" <gi...@apache.org>.
Superskyyy commented on code in PR #294:
URL: https://github.com/apache/skywalking-python/pull/294#discussion_r1140534854
##########
docs/en/contribution/How-to-release.md:
##########
@@ -10,7 +10,7 @@ This documentation guides the release manager to release the SkyWalking Python i
## Add your GPG public key to Apache svn
-1. Upload your GPG public key to a public GPG site, such as [MIT's site](http://pgp.mit.edu:11371/).
+1. Upload your GPG public key to a public GPG site, such as [Ubuntu's GPG keyserver](https://keyserver.ubuntu.com/).
Review Comment:
Sure!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] kezhenxu94 commented on a diff in pull request #294: Remove dead MIT gpg site and fix release command
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on code in PR #294:
URL: https://github.com/apache/skywalking-python/pull/294#discussion_r1139897066
##########
docs/en/contribution/How-to-release.md:
##########
@@ -10,7 +10,7 @@ This documentation guides the release manager to release the SkyWalking Python i
## Add your GPG public key to Apache svn
-1. Upload your GPG public key to a public GPG site, such as [MIT's site](http://pgp.mit.edu:11371/).
+1. Upload your GPG public key to a public GPG site, such as [Ubuntu's GPG keyserver](https://keyserver.ubuntu.com/).
Review Comment:
Uploading gpg key to a public server is not required in Python agent release process, let's simply remove this in the doc @Superskyyy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] wu-sheng merged pull request #294: Remove dead MIT gpg site and fix release command
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #294:
URL: https://github.com/apache/skywalking-python/pull/294
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] kezhenxu94 commented on a diff in pull request #294: Remove dead MIT gpg site and fix release command
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on code in PR #294:
URL: https://github.com/apache/skywalking-python/pull/294#discussion_r1140844979
##########
docs/en/contribution/How-to-release.md:
##########
@@ -10,7 +10,7 @@ This documentation guides the release manager to release the SkyWalking Python i
## Add your GPG public key to Apache svn
-1. Upload your GPG public key to a public GPG site, such as [MIT's site](http://pgp.mit.edu:11371/).
+1. Upload your GPG public key to a public GPG site, such as [Ubuntu's GPG keyserver](https://keyserver.ubuntu.com/).
Review Comment:
> Uploading gpg key to a public server is not required in Python agent release process
The other step "upload the key to Apache svn " is still needed 🤭
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org