[GitHub] [airflow] ashb commented on a change in pull request #7096: [AIRFLOW-6451] self._print_stat() in dag_processing.py should be skippable

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #7096: [AIRFLOW-6451] self._print_stat() in dag_processing.py should be skippable
URL: https://github.com/apache/airflow/pull/7096#discussion_r364650879
 
 

 ##########
 File path: airflow/utils/dag_processing.py
 ##########
 @@ -691,6 +688,7 @@ def start(self):
                               "have been processed %s times", self._max_runs)
                 break
 
+            # TODO can this be removed?
 
 Review comment:
   @tooptoop4 Please don't add comments like this  -- it just makes it harder and confusing for the next person who comes along.
   
   The answer is no - async mode is still needed -- when using SQLlite we run "synchronously" as it doesn't have well/at all with multiple access, so we want to "stop" as soon as we're done, not sleep. poll_time=None in sync mode, which says wait until a message is sent on L639.
   
   Please remove this comment.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services