You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by pengjianhua <pe...@zte.com.cn> on 2017/08/20 13:53:23 UTC
Review Request 61771: Comment lines have not been filtered out when
the populate_global_dict function parsed install.properties in
security-admin/scripts/restrict_permissions.py. Like RANGER-1284,
we should modify it.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61771/
-----------------------------------------------------------
Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
Repository: ranger
Description
-------
Comment lines have not been filtered out when the populate_global_dict function parsed install.properties in security-admin/scripts/restrict_permissions.py. So if we use '#' to comment a line and it includes '=', the comment will not work. On the left of the '=', it will be parsed as a key and the right will be parsed as a value. As a result, there are two problems as follows:
1. There are invalid attribute values in globalDict variable.
2. Invalid parsing will degrade the performance of program.
Diffs
-----
security-admin/scripts/restrict_permissions.py a4998be
Diff: https://reviews.apache.org/r/61771/diff/1/
Testing
-------
Thanks,
pengjianhua
Re: Review Request 61771: Comment lines have not been filtered out
when the populate_global_dict function parsed install.properties in
security-admin/scripts/restrict_permissions.py. Like RANGER-1284,
we should modify it.
Posted by pengjianhua <pe...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61771/
-----------------------------------------------------------
(Updated 八月 23, 2017, 1:42 a.m.)
Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
Bugs: RANGER-1743
https://issues.apache.org/jira/browse/RANGER-1743
Repository: ranger
Description
-------
Comment lines have not been filtered out when the populate_global_dict function parsed install.properties in security-admin/scripts/restrict_permissions.py. So if we use '#' to comment a line and it includes '=', the comment will not work. On the left of the '=', it will be parsed as a key and the right will be parsed as a value. As a result, there are two problems as follows:
1. There are invalid attribute values in globalDict variable.
2. Invalid parsing will degrade the performance of program.
Diffs
-----
security-admin/scripts/restrict_permissions.py a4998be
Diff: https://reviews.apache.org/r/61771/diff/1/
Testing
-------
Thanks,
pengjianhua
Re: Review Request 61771: Comment lines have not been filtered out
when the populate_global_dict function parsed install.properties in
security-admin/scripts/restrict_permissions.py. Like RANGER-1284,
we should modify it.
Posted by Qiang Zhang <zh...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61771/#review183341
-----------------------------------------------------------
Ship it!
Ship It!
- Qiang Zhang
On 八月 20, 2017, 1:53 p.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61771/
> -----------------------------------------------------------
>
> (Updated 八月 20, 2017, 1:53 p.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Comment lines have not been filtered out when the populate_global_dict function parsed install.properties in security-admin/scripts/restrict_permissions.py. So if we use '#' to comment a line and it includes '=', the comment will not work. On the left of the '=', it will be parsed as a key and the right will be parsed as a value. As a result, there are two problems as follows:
> 1. There are invalid attribute values in globalDict variable.
> 2. Invalid parsing will degrade the performance of program.
>
>
> Diffs
> -----
>
> security-admin/scripts/restrict_permissions.py a4998be
>
>
> Diff: https://reviews.apache.org/r/61771/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengjianhua
>
>