[jira] [Issue Comment Edited] (HBASE-4684) REST server is leaking ZK connections in 0.90

["Andrew Purtell (Issue Comment Edited) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-4684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137685#comment-13137685 ] 

Andrew Purtell edited comment on HBASE-4684 at 10/27/11 10:53 PM:
------------------------------------------------------------------

Patch to fix the leak attached.

Still not thrilled with scan/rescan of table attributes for transformation directives, in retrospect. Could do something like:

{code}
public class RESTConfiguration extends HBaseConfiguration {
   public RESTConfiguration() {
     super();
     addResource("hbase-rest-site.xml");
   }
}
{code}

and get transform configuration from the configuration presumably as specified in the additional REST config file if it exists. More convenient to edit configuration and bounce the REST gateway then change a table attribute? At least until online schema updates.

                
      was (Author: apurtell):
    Patch to fix the leak attached.

Still not thrilled with scan/rescan of table attributes for transformation directives, in retrospect. Could do something like:

{code}
public class RESTConfiguration extends HBaseConfiguration {
   public RESTConfiguration() {
     super();
     addResource("hbase-rest-site.xml");
   }
}
{code}

and get transform configuration from the configuration presumably as specified in the additional REST config file if it exists. More likely a REST gateway will be bounced than a table attribute changed? At least until online schema updates.

                  
> REST server is leaking ZK connections in 0.90
> ---------------------------------------------
>
>                 Key: HBASE-4684
>                 URL: https://issues.apache.org/jira/browse/HBASE-4684
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.4
>            Reporter: Jean-Daniel Cryans
>            Priority: Critical
>             Fix For: 0.90.5
>
>         Attachments: HBASE-4684-0.90.patch
>
>
> As reported a month ago, http://search-hadoop.com/m/FD6gmKzrxY1, the REST server is leak ZK connections. Upon investigation I see that TableResource.scanTransformAttrs creates a new HBA per minute per table (when the server is getting requests) but never deletes the connection created in there.
> There are a bunch of other places where HBAs are created but not cleaned after like SchemaResource, StorageClusterStatusResource, StorageClusterVersionResource, ExistsResource, etc. Those places shouldn't be as leaky under normal circumstances tho.
> Thanks to Jack Levin for bringing up this issue again when he tried to upgrade.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira