[GitHub] [arrow] wgtmac commented on a diff in pull request #36955: GH-36882: [C++][Parquet] Default RLE for bool values in v2 pages

["wgtmac (via GitHub)" <gi...@apache.org>]

wgtmac commented on code in PR #36955:
URL: https://github.com/apache/arrow/pull/36955#discussion_r1279488827


##########
cpp/src/parquet/column_writer.cc:
##########
@@ -2328,7 +2328,13 @@ std::shared_ptr<ColumnWriter> ColumnWriter::Make(ColumnChunkMetaDataBuilder* met
   const ColumnDescriptor* descr = metadata->descr();
   const bool use_dictionary = properties->dictionary_enabled(descr->path()) &&
                               descr->physical_type() != Type::BOOLEAN;
-  Encoding::type encoding = properties->encoding(descr->path());
+  Encoding::type default_encoding =
+      (descr->physical_type() == Type::BOOLEAN &&
+       properties->data_page_version() == ParquetDataPageVersion::V2)

Review Comment:
   I'm not sure if we need to check `properties->version() != ParquetVersion::PARQUET_1_0`. parquet-mr does not have a way to set format version and always write 1 in the footer.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org