You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/06/24 18:24:18 UTC
[GitHub] [trafficcontrol] mitchell852 opened a new pull request #4827: TP: adds first, inner and last header rewrite fields for topologies
mitchell852 opened a new pull request #4827:
URL: https://github.com/apache/trafficcontrol/pull/4827
## What does this PR (Pull Request) do?
This PR adds 3 new fields to the DNS* and HTTP* delivery service forms:
- firstHeaderRewrite
- innerHeaderRewrite
- lastHeaderRewrite
Validation was also added to:
a. only allow firstHeaderRewrite, innerHeaderRewrite and lastHeaderRewrite values if topology is selected for a ds
b. prevent edgeHeaderRewrite and midHeaderRewrite values if a topology is selected.
All 5 values are displayed to facilitate migration from edge/mid header rewrites to first/inner/last header rewrites when moving from explicit ds / server assignments towards using a topology instead.
- [x] This PR is not related to any Issue
## Which Traffic Control components are affected by this PR?
- Traffic Portal
## What is the best way to verify this PR?
- Ensure that topologies exist at https://tp.domain.net/#!/topologies
- create/update a DNS* ds
- add values for edge/mid/first/inner/last header rewrites
- toggle between a topology and no topology assigned and notice the validation of those fields.
- ensure edge/mid header rewrites are not allowed when a topology is assigned
- ensure first/inner/last header rewrites are not allowed when NO topology is assigned
- do the same for an HTTP* ds
## The following criteria are ALL met by this PR
- [x] This PR does NOT include tests as these fields are optional and only required fields are currently under test.
- [x] This PR does NOT includes documentation changes as each ds form is not documented.
- [x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
- [x] This PR includes any and all required license headers
- [x] This PR ensures that database migration sequence is correct OR this PR does not include a database migration
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 commented on pull request #4827: TP: adds first, inner and last header rewrite fields for topologies
Posted by GitBox <gi...@apache.org>.
mitchell852 commented on pull request #4827:
URL: https://github.com/apache/trafficcontrol/pull/4827#issuecomment-650378165
> How would you feel about hiding the edge/mid header rewrite fields if they're empty and a topology is assigned? And hiding the first/inner/last header rewrite fields if they're empty and a topology isn't assigned?
so i thought about this a lot actually and it gets tricky, stuff starts showing/hiding when you assign/unassign a topology and/or add/remove header rewrite rules so i came to the conclusion that maybe it's just best to show all 5 fields with an validation message that displays if you are using the wrong combination of fields.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 edited a comment on pull request #4827: TP: adds first, inner and last header rewrite fields for topologies
Posted by GitBox <gi...@apache.org>.
mitchell852 edited a comment on pull request #4827:
URL: https://github.com/apache/trafficcontrol/pull/4827#issuecomment-650378165
> How would you feel about hiding the edge/mid header rewrite fields if they're empty and a topology is assigned? And hiding the first/inner/last header rewrite fields if they're empty and a topology isn't assigned?
so i thought about this a lot actually and it gets tricky, stuff starts showing/hiding when you assign/unassign a topology and/or add/remove header rewrite rules so i came to the conclusion that maybe it's just best to show all 5 fields with an validation message that displays if you are using the wrong combination of fields. At least, I think this is a good approach while both non-topology and topology ds's are permitted. once they are not and only topology-based ds's are allowed, then obviously the edge/mid header rewrite rules need to be removed entirely.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mattjackson220 merged pull request #4827: TP: adds first, inner and last header rewrite fields for topologies
Posted by GitBox <gi...@apache.org>.
mattjackson220 merged pull request #4827:
URL: https://github.com/apache/trafficcontrol/pull/4827
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 edited a comment on pull request #4827: TP: adds first, inner and last header rewrite fields for topologies
Posted by GitBox <gi...@apache.org>.
mitchell852 edited a comment on pull request #4827:
URL: https://github.com/apache/trafficcontrol/pull/4827#issuecomment-650378165
> How would you feel about hiding the edge/mid header rewrite fields if they're empty and a topology is assigned? And hiding the first/inner/last header rewrite fields if they're empty and a topology isn't assigned?
so i thought about this a lot actually and it gets tricky, stuff starts showing/hiding when you assign/unassign a topology and/or add/remove header rewrite rules so i came to the conclusion that maybe it's just best to show all 5 fields with an validation message that displays if you are using the wrong combination of fields. At least, I think this is a good approach which both non-topology and topology ds's are permitted. once they are not, then obviously the edge/mid header rewrite rules need to be removed entirely.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org