You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Jason Fehr (Code Review)" <ge...@cloudera.org> on 2025/05/30 23:10:25 UTC

[Impala-ASF-CR] IMPALA-14090: Move Some Stable Custom Cluster Tests to Exhaustive

Jason Fehr has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22963


Change subject: IMPALA-14090: Move Some Stable Custom Cluster Tests to Exhaustive
......................................................................

IMPALA-14090: Move Some Stable Custom Cluster Tests to Exhaustive

Moves several custom cluster tests out of core and into exhaustive
only. The tests were chosen based on their stability, lack of recent
modifications, and coverage of rare/corner cases.

Testing was accomplished by running both core and exhaustive tests
and manually verifying the tests were or were not skipped as
expected.

Change-Id: If99c015a0cb5d95b1607ca2be48d2dea04194f81
---
M tests/common/skip.py
M tests/custom_cluster/test_query_log.py
M tests/custom_cluster/test_topic_update_frequency.py
M tests/custom_cluster/test_workload_mgmt_init.py
M tests/custom_cluster/test_workload_mgmt_sql_details.py
5 files changed, 29 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/63/22963/1
-- 
To view, visit http://gerrit.cloudera.org:8080/22963
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If99c015a0cb5d95b1607ca2be48d2dea04194f81
Gerrit-Change-Number: 22963
Gerrit-PatchSet: 1
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>

[Impala-ASF-CR] IMPALA-14090: Move Some Stable Custom Cluster Tests to Exhaustive

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22963 )

Change subject: IMPALA-14090: Move Some Stable Custom Cluster Tests to Exhaustive
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/22963
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If99c015a0cb5d95b1607ca2be48d2dea04194f81
Gerrit-Change-Number: 22963
Gerrit-PatchSet: 2
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: gaurav singh <gs...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 May 2025 23:14:25 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14090: Move Some Stable Custom Cluster Tests to Exhaustive

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22963 )

Change subject: IMPALA-14090: Move Some Stable Custom Cluster Tests to Exhaustive
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/19354/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/22963
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If99c015a0cb5d95b1607ca2be48d2dea04194f81
Gerrit-Change-Number: 22963
Gerrit-PatchSet: 1
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: gaurav singh <gs...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 May 2025 23:36:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14090: Move Some Stable Custom Cluster Tests to Exhaustive

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22963 )

Change subject: IMPALA-14090: Move Some Stable Custom Cluster Tests to Exhaustive
......................................................................

IMPALA-14090: Move Some Stable Custom Cluster Tests to Exhaustive

Moves several custom cluster tests out of core and into exhaustive
only. The tests were chosen based on their stability, lack of recent
modifications, and coverage of rare/corner cases.

Testing was accomplished by running both core and exhaustive tests
and manually verifying the tests were or were not skipped as
expected.

Change-Id: If99c015a0cb5d95b1607ca2be48d2dea04194f81
Reviewed-on: http://gerrit.cloudera.org:8080/22963
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/common/skip.py
M tests/custom_cluster/test_query_log.py
M tests/custom_cluster/test_topic_update_frequency.py
M tests/custom_cluster/test_workload_mgmt_init.py
M tests/custom_cluster/test_workload_mgmt_sql_details.py
5 files changed, 29 insertions(+), 1 deletion(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/22963
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If99c015a0cb5d95b1607ca2be48d2dea04194f81
Gerrit-Change-Number: 22963
Gerrit-PatchSet: 4
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: gaurav singh <gs...@cloudera.com>

[Impala-ASF-CR] IMPALA-14090: Move Some Stable Custom Cluster Tests to Exhaustive

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22963 )

Change subject: IMPALA-14090: Move Some Stable Custom Cluster Tests to Exhaustive
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11961/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/22963
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If99c015a0cb5d95b1607ca2be48d2dea04194f81
Gerrit-Change-Number: 22963
Gerrit-PatchSet: 3
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: gaurav singh <gs...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Jun 2025 01:53:03 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14090: Move Some Stable Custom Cluster Tests to Exhaustive

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22963 )

Change subject: IMPALA-14090: Move Some Stable Custom Cluster Tests to Exhaustive
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/22963
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If99c015a0cb5d95b1607ca2be48d2dea04194f81
Gerrit-Change-Number: 22963
Gerrit-PatchSet: 2
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: gaurav singh <gs...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 May 2025 23:41:44 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14090: Move Some Stable Custom Cluster Tests to Exhaustive

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22963 )

Change subject: IMPALA-14090: Move Some Stable Custom Cluster Tests to Exhaustive
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/22963
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If99c015a0cb5d95b1607ca2be48d2dea04194f81
Gerrit-Change-Number: 22963
Gerrit-PatchSet: 3
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: gaurav singh <gs...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Jun 2025 01:53:02 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14090: Move Some Stable Custom Cluster Tests to Exhaustive

Posted by "Jason Fehr (Code Review)" <ge...@cloudera.org>.
Hello Riza Suminto, gaurav singh, Michael Smith, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22963

to look at the new patch set (#2).

Change subject: IMPALA-14090: Move Some Stable Custom Cluster Tests to Exhaustive
......................................................................

IMPALA-14090: Move Some Stable Custom Cluster Tests to Exhaustive

Moves several custom cluster tests out of core and into exhaustive
only. The tests were chosen based on their stability, lack of recent
modifications, and coverage of rare/corner cases.

Testing was accomplished by running both core and exhaustive tests
and manually verifying the tests were or were not skipped as
expected.

Change-Id: If99c015a0cb5d95b1607ca2be48d2dea04194f81
---
M tests/common/skip.py
M tests/custom_cluster/test_query_log.py
M tests/custom_cluster/test_topic_update_frequency.py
M tests/custom_cluster/test_workload_mgmt_init.py
M tests/custom_cluster/test_workload_mgmt_sql_details.py
5 files changed, 29 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/63/22963/2
-- 
To view, visit http://gerrit.cloudera.org:8080/22963
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If99c015a0cb5d95b1607ca2be48d2dea04194f81
Gerrit-Change-Number: 22963
Gerrit-PatchSet: 2
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: gaurav singh <gs...@cloudera.com>

[Impala-ASF-CR] IMPALA-14090: Move Some Stable Custom Cluster Tests to Exhaustive

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22963 )

Change subject: IMPALA-14090: Move Some Stable Custom Cluster Tests to Exhaustive
......................................................................


Patch Set 1:

(2 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/22963/1/tests/common/skip.py
File tests/common/skip.py:

http://gerrit.cloudera.org:8080/#/c/22963/1/tests/common/skip.py@287
PS1, Line 287:  
flake8: W291 trailing whitespace


http://gerrit.cloudera.org:8080/#/c/22963/1/tests/common/skip.py@287
PS1, Line 287:         reason=skip_msg)  
line has trailing whitespace



-- 
To view, visit http://gerrit.cloudera.org:8080/22963
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If99c015a0cb5d95b1607ca2be48d2dea04194f81
Gerrit-Change-Number: 22963
Gerrit-PatchSet: 1
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: gaurav singh <gs...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 May 2025 23:12:14 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14090: Move Some Stable Custom Cluster Tests to Exhaustive

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22963 )

Change subject: IMPALA-14090: Move Some Stable Custom Cluster Tests to Exhaustive
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/19355/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/22963
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If99c015a0cb5d95b1607ca2be48d2dea04194f81
Gerrit-Change-Number: 22963
Gerrit-PatchSet: 2
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: gaurav singh <gs...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 May 2025 23:40:44 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14090: Move Some Stable Custom Cluster Tests to Exhaustive

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22963 )

Change subject: IMPALA-14090: Move Some Stable Custom Cluster Tests to Exhaustive
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/22963
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If99c015a0cb5d95b1607ca2be48d2dea04194f81
Gerrit-Change-Number: 22963
Gerrit-PatchSet: 3
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: gaurav singh <gs...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Jun 2025 07:53:36 +0000
Gerrit-HasComments: No