You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/02 14:31:55 UTC

[GitHub] [airflow] sunkickr commented on a change in pull request #15159: Add dynamic connection fields to Azure Connection

sunkickr commented on a change in pull request #15159:
URL: https://github.com/apache/airflow/pull/15159#discussion_r606263524



##########
File path: airflow/providers/microsoft/azure/hooks/base_azure.py
##########
@@ -30,14 +30,56 @@ class AzureBaseHook(BaseHook):
     authenticate the client library used for upstream azure hooks.
 
     :param sdk_client: The SDKClient to use.
+    :type sdk_client: Optional[str]
     :param conn_id: The azure connection id which refers to the information to connect to the service.
+    :type conn_id: str
     """
 
-    conn_name_attr = 'conn_id'
+    conn_name_attr = 'azure_conn_id'

Review comment:
       wondering what implication this change has




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org