You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@metron.apache.org by merrimanr <gi...@git.apache.org> on 2018/09/12 19:58:35 UTC

[GitHub] metron issue #1190: METRON-1771: Update REST endpoints to support eventually...

Github user merrimanr commented on the issue:

    https://github.com/apache/metron/pull/1190
  
    The latest commit updates the various places where looking up a document that doesn't exist returns null.  Now an IOException is thrown with a helpful message and guid of the missing object.  I added tests to cover these cases.  I also added changes that will throw an exception when alerts to be add/removed don't exist.  Previously that wasn't covered and the operation would succeed even though the missing alert wasn't added/removed.
    
    For the parallel stream issue, I made it consistent with the rest of the class.  It now uses the same approach as the getLatest method and uses the DocumentContainer class.  As part of this I moved common code to a separate method.
    
    Let me know what you think about these changes.


---