You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Haohui Mai (JIRA)" <ji...@apache.org> on 2014/08/12 20:45:12 UTC
[jira] [Comment Edited] (HDFS-6836) HDFS INFO logging is verbose &
uses file appenders
[ https://issues.apache.org/jira/browse/HDFS-6836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14094475#comment-14094475 ]
Haohui Mai edited comment on HDFS-6836 at 8/12/14 6:43 PM:
-----------------------------------------------------------
{code}
- if (clientTraceFmt != null) {
+ if (ClientTraceLog.isInfoEnabled() && (clientTraceFmt != null)) {
final long endTime = System.nanoTime();
- ClientTraceLog.info(String.format(clientTraceFmt, totalRead,
+ ClientTraceLog.debug(String.format(clientTraceFmt, totalRead,
initialOffset, endTime - startTime));
}
{code}
It probably should be something like:
{code}
...
if (clientTraceFmt != null && ClientTraceLog.isDebugEnabled()) {
ClientTraceLog.debug(...)
}
{code}
was (Author: wheat9):
{code}
- if (clientTraceFmt != null) {
+ if (ClientTraceLog.isInfoEnabled() && (clientTraceFmt != null)) {
final long endTime = System.nanoTime();
- ClientTraceLog.info(String.format(clientTraceFmt, totalRead,
+ ClientTraceLog.debug(String.format(clientTraceFmt, totalRead,
initialOffset, endTime - startTime));
}
{code}
It probably should be something like:
{code}
...
if (ClientTraceLog.isDebugEnabled()) {
ClientTraceLog.debug(...)
}
{code}
> HDFS INFO logging is verbose & uses file appenders
> --------------------------------------------------
>
> Key: HDFS-6836
> URL: https://issues.apache.org/jira/browse/HDFS-6836
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Affects Versions: 2.4.1
> Reporter: Gopal V
> Assignee: Xiaoyu Yao
> Attachments: HDFS-6836.0.patch, HDFS-6836.1.patch
>
>
> Reported by: [~gopalv].
> The HDFS INFO logs is present within the inner loops of HDFS logging information like
> {code}
> 2014-07-24 19:43:34,459 INFO DataNode.clienttrace (BlockSender.java:sendBlock(738)) - src: /172.21.128.105:50010, dest: /172.21.128.113:43666, bytes: 786432, op: HDFS_READ, cliID: DFSClient_hb_rs_cn113-10.l42scl.hortonworks.com,50700,1406227155474_1075922312_33, offset: 86616576, srvID: 3f80f56f-a6ea-4951-8db6-86b51938d144, blockid: BP-971413386-172.21.128.105-1398117368124:blk_1074925960_1186504, duration: 6827335
> 2014-07-24 19:43:34,465 INFO DataNode.clienttrace (BlockSender.java:sendBlock(738)) - src: /172.21.128.105:50010, dest: /172.21.128.117:41731, bytes: 786432, op: HDFS_READ, cliID: DFSClient_hb_rs_cn117-10.l42scl.hortonworks.com,53868,1406227155459_1689003704_33, offset: 72691200, srvID: 3f80f56f-a6ea-4951-8db6-86b51938d144, blockid: BP-971413386-172.21.128.105-1398117368124:blk_1074926372_1186916, duration: 7178626
> 2014-07-24 19:43:34,467 INFO DataNode.clienttrace (BlockSender.java:sendBlock(738)) - src: /172.21.128.105:50010, dest: /172.21.128.113:43669, bytes: 786432, op: HDFS_READ, cliID: DFSClient_hb_rs_cn113-10.l42scl.hortonworks.com,50700,1406227155474_1075922312_33, offset: 86813696, srvID: 3f80f56f-a6ea-4951-8db6-86b51938d144, blockid: BP-971413386-172.21.128.105-1398117368124:blk_1074925960_1186504, duration: 8540703
> 2014-07-24 19:43:34,474 INFO DataNode.clienttrace (BlockSender.java:sendBlock(738)) - src: /172.21.128.105:50010, dest: /172.21.128.117:41733, bytes: 786432, op: HDFS_READ, cliID: DFSClient_hb_rs_cn117-10.l42scl.hortonworks.com,53868,1406227155459_1689003704_33, offset: 72822272, srvID: 3f80f56f-a6ea-4951-8db6-86b51938d144, blockid: BP-971413386-172.21.128.105-1398117368124:blk_1074926372_1186916, duration: 8220422
> 2014-07-24 19:43:34,477 INFO DataNode.clienttrace (BlockSender.java:sendBlock(738)) - src: /172.21.128.105:50010, dest: /172.21.128.113:43672, bytes: 786432, op: HDFS_READ, cliID: DFSClient_hb_rs_cn113-10.l42scl.hortonworks.com,50700,1406227155474_1075922312_33, offset: 86944768, srvID: 3f80f56f-a6ea-4951-8db6-86b51938d144, blockid: BP-971413386-172.21.128.105-1398117368124:blk_1074925960_1186504, duration: 8327499
> {code}
> Looks like future releases of log4j will fix this to be faster - https://issues.apache.org/jira/browse/LOG4J2-163
--
This message was sent by Atlassian JIRA
(v6.2#6252)