You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "Julien Vermillard (JIRA)" <ji...@apache.org> on 2007/09/03 09:03:23 UTC

[jira] Created: (DIRMINA-432) IoService method for writing Object to all the managed IoSession

IoService method for writing Object to all the managed IoSession
----------------------------------------------------------------

                 Key: DIRMINA-432
                 URL: https://issues.apache.org/jira/browse/DIRMINA-432
             Project: MINA
          Issue Type: Improvement
          Components: Core
    Affects Versions: 1.1.2, 1.0.5, 1.1.1, 1.0.4, 1.1.0, 1.0.3, 1.0.2, 1.0.1, 1.0.0, 0.9.5, 0.9.4, 0.9.3, 0.9.2, 0.9.1, 0.9.0, 0.8.4, 0.8.3, 0.8.2, 0.8.1, 0.8.0, 0.7.4, 0.7.3, 0.7.2, 0.7.1, 0.7.0, 1.0.6, 1.1.3, 2.0.0-M1
            Reporter: Julien Vermillard
            Assignee: Julien Vermillard
            Priority: Trivial
             Fix For: 2.0.0-M1


Would be convenient to ad a method to IoService for writing a message to all the managed sessions.
in IoService : 
public WriteFuture writeAllSession(Object message);

the implementation could be done in AbstractIoService.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Commented: (DIRMINA-432) IoService method for writing Object to all the managed IoSession

Posted by Maarten Bosteels <mb...@gmail.com>.
ok for me.
Maarten

On 9/3/07, Julien Vermillard (JIRA) <ji...@apache.org> wrote:
>
>
>     [
> https://issues.apache.org/jira/browse/DIRMINA-432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12524520]
>
> Julien Vermillard commented on DIRMINA-432:
> -------------------------------------------
>
> Why not simply 'write(..)' ?
>
> So we can have :
>
> WriteFuture write(Set<IoSession> sessions,Object message);
>
> and a general broadcast (just a shortcut using the set of managed session
> as first paramaeter):
> WriteFuture write(Object messsage);
>
>
> > IoService method for writing Object to all the managed IoSession
> > ----------------------------------------------------------------
> >
> >                 Key: DIRMINA-432
> >                 URL: https://issues.apache.org/jira/browse/DIRMINA-432
> >             Project: MINA
> >          Issue Type: Improvement
> >          Components: Core
> >    Affects Versions: 0.7.0, 0.7.1, 0.7.2, 0.7.3, 0.7.4, 0.8.0, 0.8.1,
> 0.8.2, 0.8.3, 0.8.4, 0.9.0, 0.9.1, 0.9.2, 0.9.3, 0.9.4, 0.9.5, 1.0.0,
> 1.0.1, 1.0.2, 1.0.3, 1.1.0, 1.0.4, 1.1.1, 1.0.5, 1.1.2, 1.0.6, 1.1.3,
> 2.0.0-M1
> >            Reporter: Julien Vermillard
> >            Assignee: Julien Vermillard
> >            Priority: Trivial
> >             Fix For: 2.0.0-M1
> >
> >
> > Would be convenient to ad a method to IoService for writing a message to
> all the managed sessions.
> > in IoService :
> > public WriteFuture writeAllSession(Object message);
> > the implementation could be done in AbstractIoService.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>

[jira] Resolved: (DIRMINA-432) IoService method for writing Object to all the managed IoSession

Posted by "Trustin Lee (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRMINA-432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Trustin Lee resolved DIRMINA-432.
---------------------------------

    Resolution: Fixed

I added the following:

* Set<WriteFuture> IoService.broadcast(Object message)
* CompositeIoFuture
* MessageBroadcaster.broadcast(...)
* MessageBroadcaster.await(...)
* MessageBroadcaster.awaitUninterruptly(...)

Please review and close this issue if you are satisfied. :)

> IoService method for writing Object to all the managed IoSession
> ----------------------------------------------------------------
>
>                 Key: DIRMINA-432
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-432
>             Project: MINA
>          Issue Type: New Feature
>          Components: Core
>            Reporter: Julien Vermillard
>            Assignee: Trustin Lee
>            Priority: Trivial
>             Fix For: 2.0.0-M1
>
>
> Would be convenient to ad a method to IoService for writing a message to all the managed sessions.
> in IoService : 
> public WriteFuture writeAllSession(Object message);
> the implementation could be done in AbstractIoService.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (DIRMINA-432) IoService method for writing Object to all the managed IoSession

Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRMINA-432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emmanuel Lecharny closed DIRMINA-432.
-------------------------------------


> IoService method for writing Object to all the managed IoSession
> ----------------------------------------------------------------
>
>                 Key: DIRMINA-432
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-432
>             Project: MINA
>          Issue Type: New Feature
>          Components: Core
>            Reporter: Julien Vermillard
>            Assignee: Trustin Lee
>            Priority: Trivial
>             Fix For: 2.0.0-M1
>
>
> Would be convenient to ad a method to IoService for writing a message to all the managed sessions.
> in IoService : 
> public WriteFuture writeAllSession(Object message);
> the implementation could be done in AbstractIoService.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DIRMINA-432) IoService method for writing Object to all the managed IoSession

Posted by "Julien Vermillard (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DIRMINA-432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12525080 ] 

Julien Vermillard commented on DIRMINA-432:
-------------------------------------------

The WriteFuture write(Object messsage); can be placed in IoService, but as Trustin thought  write(Set<IoSession>,Object message) need to go to a utility class because the set can be composed of session of different IoService.

> IoService method for writing Object to all the managed IoSession
> ----------------------------------------------------------------
>
>                 Key: DIRMINA-432
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-432
>             Project: MINA
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.7.0, 0.7.1, 0.7.2, 0.7.3, 0.7.4, 0.8.0, 0.8.1, 0.8.2, 0.8.3, 0.8.4, 0.9.0, 0.9.1, 0.9.2, 0.9.3, 0.9.4, 0.9.5, 1.0.0, 1.0.1, 1.0.2, 1.0.3, 1.1.0, 1.0.4, 1.1.1, 1.0.5, 1.1.2, 1.0.6, 1.1.3, 2.0.0-M1
>            Reporter: Julien Vermillard
>            Assignee: Julien Vermillard
>            Priority: Trivial
>             Fix For: 2.0.0-M1
>
>
> Would be convenient to ad a method to IoService for writing a message to all the managed sessions.
> in IoService : 
> public WriteFuture writeAllSession(Object message);
> the implementation could be done in AbstractIoService.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DIRMINA-432) IoService method for writing Object to all the managed IoSession

Posted by "Trustin Lee (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DIRMINA-432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12524475 ] 

Trustin Lee commented on DIRMINA-432:
-------------------------------------

writeAllSession sounds like 'writing sessions' than 'writing a message to all sessions'.  What would be a better name?

Or... it would be more flexible to provide a utility class that sends a message to a certain set of sessions so a user can send to any combination of sessions.  WDYT?

> IoService method for writing Object to all the managed IoSession
> ----------------------------------------------------------------
>
>                 Key: DIRMINA-432
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-432
>             Project: MINA
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.7.0, 0.7.1, 0.7.2, 0.7.3, 0.7.4, 0.8.0, 0.8.1, 0.8.2, 0.8.3, 0.8.4, 0.9.0, 0.9.1, 0.9.2, 0.9.3, 0.9.4, 0.9.5, 1.0.0, 1.0.1, 1.0.2, 1.0.3, 1.1.0, 1.0.4, 1.1.1, 1.0.5, 1.1.2, 1.0.6, 1.1.3, 2.0.0-M1
>            Reporter: Julien Vermillard
>            Assignee: Julien Vermillard
>            Priority: Trivial
>             Fix For: 2.0.0-M1
>
>
> Would be convenient to ad a method to IoService for writing a message to all the managed sessions.
> in IoService : 
> public WriteFuture writeAllSession(Object message);
> the implementation could be done in AbstractIoService.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DIRMINA-432) IoService method for writing Object to all the managed IoSession

Posted by "Julien Vermillard (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DIRMINA-432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12524520 ] 

Julien Vermillard commented on DIRMINA-432:
-------------------------------------------

Why not simply 'write(..)' ?

So we can have :

WriteFuture write(Set<IoSession> sessions,Object message);

and a general broadcast (just a shortcut using the set of managed session as first paramaeter):
WriteFuture write(Object messsage);


> IoService method for writing Object to all the managed IoSession
> ----------------------------------------------------------------
>
>                 Key: DIRMINA-432
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-432
>             Project: MINA
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.7.0, 0.7.1, 0.7.2, 0.7.3, 0.7.4, 0.8.0, 0.8.1, 0.8.2, 0.8.3, 0.8.4, 0.9.0, 0.9.1, 0.9.2, 0.9.3, 0.9.4, 0.9.5, 1.0.0, 1.0.1, 1.0.2, 1.0.3, 1.1.0, 1.0.4, 1.1.1, 1.0.5, 1.1.2, 1.0.6, 1.1.3, 2.0.0-M1
>            Reporter: Julien Vermillard
>            Assignee: Julien Vermillard
>            Priority: Trivial
>             Fix For: 2.0.0-M1
>
>
> Would be convenient to ad a method to IoService for writing a message to all the managed sessions.
> in IoService : 
> public WriteFuture writeAllSession(Object message);
> the implementation could be done in AbstractIoService.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DIRMINA-432) IoService method for writing Object to all the managed IoSession

Posted by "Julien Vermillard (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DIRMINA-432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12525430 ] 

Julien Vermillard commented on DIRMINA-432:
-------------------------------------------

WDYT of adding a class in o.a.mina.common called SessionWriter with the folowing static method :
public static WriteFuture write(Set<IoSession> sessions,Object message); 
public static WriteFuture write(IoSession[] sessions,Object message); 


> IoService method for writing Object to all the managed IoSession
> ----------------------------------------------------------------
>
>                 Key: DIRMINA-432
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-432
>             Project: MINA
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.7.0, 0.7.1, 0.7.2, 0.7.3, 0.7.4, 0.8.0, 0.8.1, 0.8.2, 0.8.3, 0.8.4, 0.9.0, 0.9.1, 0.9.2, 0.9.3, 0.9.4, 0.9.5, 1.0.0, 1.0.1, 1.0.2, 1.0.3, 1.1.0, 1.0.4, 1.1.1, 1.0.5, 1.1.2, 1.0.6, 1.1.3, 2.0.0-M1
>            Reporter: Julien Vermillard
>            Assignee: Julien Vermillard
>            Priority: Trivial
>             Fix For: 2.0.0-M1
>
>
> Would be convenient to ad a method to IoService for writing a message to all the managed sessions.
> in IoService : 
> public WriteFuture writeAllSession(Object message);
> the implementation could be done in AbstractIoService.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DIRMINA-432) IoService method for writing Object to all the managed IoSession

Posted by "Trustin Lee (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRMINA-432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Trustin Lee updated DIRMINA-432:
--------------------------------

             Assignee: Trustin Lee  (was: Julien Vermillard)
           Issue Type: New Feature  (was: Improvement)
    Affects Version/s:     (was: 1.1.2)
                           (was: 1.0.5)
                           (was: 1.1.1)
                           (was: 1.0.4)
                           (was: 1.1.0)
                           (was: 1.0.3)
                           (was: 1.0.2)
                           (was: 1.0.1)
                           (was: 1.0.0)
                           (was: 0.9.5)
                           (was: 0.9.4)
                           (was: 0.9.3)
                           (was: 0.9.2)
                           (was: 0.9.1)
                           (was: 0.9.0)
                           (was: 0.8.4)
                           (was: 0.8.3)
                           (was: 0.8.2)
                           (was: 0.8.1)
                           (was: 0.8.0)
                           (was: 0.7.4)
                           (was: 0.7.3)
                           (was: 0.7.2)
                           (was: 0.7.1)
                           (was: 0.7.0)
                           (was: 1.0.6)
                           (was: 1.1.3)
                           (was: 2.0.0-M1)

> IoService method for writing Object to all the managed IoSession
> ----------------------------------------------------------------
>
>                 Key: DIRMINA-432
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-432
>             Project: MINA
>          Issue Type: New Feature
>          Components: Core
>            Reporter: Julien Vermillard
>            Assignee: Trustin Lee
>            Priority: Trivial
>             Fix For: 2.0.0-M1
>
>
> Would be convenient to ad a method to IoService for writing a message to all the managed sessions.
> in IoService : 
> public WriteFuture writeAllSession(Object message);
> the implementation could be done in AbstractIoService.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DIRMINA-432) IoService method for writing Object to all the managed IoSession

Posted by "Trustin Lee (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DIRMINA-432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12527056 ] 

Trustin Lee commented on DIRMINA-432:
-------------------------------------

I'd prefer MessageBroadcaster.  And users will want to know which peer failed to receive the broadcast message, so we need to return something different like....

* Map<IoSession, WriteFuture> or
* CompositeIoFuture (new interface) that can combine any IoFutures (e.g. ConnectFuture + WriteFuture).



> IoService method for writing Object to all the managed IoSession
> ----------------------------------------------------------------
>
>                 Key: DIRMINA-432
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-432
>             Project: MINA
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.7.0, 0.7.1, 0.7.2, 0.7.3, 0.7.4, 0.8.0, 0.8.1, 0.8.2, 0.8.3, 0.8.4, 0.9.0, 0.9.1, 0.9.2, 0.9.3, 0.9.4, 0.9.5, 1.0.0, 1.0.1, 1.0.2, 1.0.3, 1.1.0, 1.0.4, 1.1.1, 1.0.5, 1.1.2, 1.0.6, 1.1.3, 2.0.0-M1
>            Reporter: Julien Vermillard
>            Assignee: Julien Vermillard
>            Priority: Trivial
>             Fix For: 2.0.0-M1
>
>
> Would be convenient to ad a method to IoService for writing a message to all the managed sessions.
> in IoService : 
> public WriteFuture writeAllSession(Object message);
> the implementation could be done in AbstractIoService.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.