[GitHub] [spark] HyukjinKwon commented on a change in pull request #32785: [SPARK-35601][PYTHON] Support arithmetic operations against bool literals

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #32785:
URL: https://github.com/apache/spark/pull/32785#discussion_r647100350



##########
File path: python/pyspark/pandas/data_type_ops/base.py
##########
@@ -52,33 +52,42 @@
     from pyspark.pandas.series import Series  # noqa: F401 (SPARK-34943)
 
 
-def is_valid_operand_for_numeric_arithmetic(operand: Any, *, allow_bool: bool = True) -> bool:
-    """Check whether the operand is valid for arithmetic operations against numerics."""
+def is_valid_operand_for_numeric_arithmetic(
+    operand: Any, *, allow_bool_index_ops: bool = True, allow_bool: bool = True

Review comment:
       Out of curiosity, why do we need `allow_bool_index_ops`? Is there a case where only bool index should be allowed alone?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org