You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Shajini Thayasingh (Code Review)" <ge...@cloudera.org> on 2020/04/29 22:04:48 UTC
[Impala-ASF-CR] IMPALA-9570: [DOCS] add memory management
Shajini Thayasingh has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15836
Change subject: IMPALA-9570: [DOCS] add memory management
......................................................................
IMPALA-9570: [DOCS] add memory management
add memory management and fix broken links
Change-Id: I6e8b6d0c3fe2e1746831665b3d3ae98a0beaa1e7
---
M docs/impala_keydefs.ditamap
M docs/topics/impala_udf.xml
2 files changed, 10 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/15836/1
--
To view, visit http://gerrit.cloudera.org:8080/15836
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6e8b6d0c3fe2e1746831665b3d3ae98a0beaa1e7
Gerrit-Change-Number: 15836
Gerrit-PatchSet: 1
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
[Impala-ASF-CR] IMPALA-9570: [DOCS] add memory management
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15836 )
Change subject: IMPALA-9570: [DOCS] add memory management
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/15836/1/docs/topics/impala_udf.xml
File docs/topics/impala_udf.xml:
http://gerrit.cloudera.org:8080/#/c/15836/1/docs/topics/impala_udf.xml@926
PS1, Line 926: serialize, finalize or getValue
Let's use the same words as the code comments: "Serialize(), Finalize() or GetValue()", because there are no "getValue" function mentioned above.
http://gerrit.cloudera.org:8080/#/c/15836/1/docs/topics/impala_udf.xml@927
PS1, Line 927: ctor
Let's use the full word, "constructor", instead.
--
To view, visit http://gerrit.cloudera.org:8080/15836
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e8b6d0c3fe2e1746831665b3d3ae98a0beaa1e7
Gerrit-Change-Number: 15836
Gerrit-PatchSet: 1
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 06 May 2020 12:36:03 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9570: [DOCS] add memory management
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15836 )
Change subject: IMPALA-9570: [DOCS] add memory management
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15836
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e8b6d0c3fe2e1746831665b3d3ae98a0beaa1e7
Gerrit-Change-Number: 15836
Gerrit-PatchSet: 3
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 08 May 2020 03:57:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9570: [DOCS] add memory management
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15836 )
Change subject: IMPALA-9570: [DOCS] add memory management
......................................................................
Patch Set 1: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/589/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/15836
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e8b6d0c3fe2e1746831665b3d3ae98a0beaa1e7
Gerrit-Change-Number: 15836
Gerrit-PatchSet: 1
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 29 Apr 2020 22:12:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9570: [DOCS] add memory management
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15836 )
Change subject: IMPALA-9570: [DOCS] add memory management
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/15836
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e8b6d0c3fe2e1746831665b3d3ae98a0beaa1e7
Gerrit-Change-Number: 15836
Gerrit-PatchSet: 3
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 08 May 2020 04:18:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9570: [DOCS] add memory management
Posted by "Shajini Thayasingh (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15836
to look at the new patch set (#2).
Change subject: IMPALA-9570: [DOCS] add memory management
......................................................................
IMPALA-9570: [DOCS] add memory management
add memory management and fix broken links. Incorporated review changes.
Change-Id: I6e8b6d0c3fe2e1746831665b3d3ae98a0beaa1e7
---
M docs/impala_keydefs.ditamap
M docs/topics/impala_udf.xml
2 files changed, 10 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/15836/2
--
To view, visit http://gerrit.cloudera.org:8080/15836
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6e8b6d0c3fe2e1746831665b3d3ae98a0beaa1e7
Gerrit-Change-Number: 15836
Gerrit-PatchSet: 2
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-9570: [DOCS] add memory management
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15836 )
Change subject: IMPALA-9570: [DOCS] add memory management
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-docs-submit/366/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/15836
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e8b6d0c3fe2e1746831665b3d3ae98a0beaa1e7
Gerrit-Change-Number: 15836
Gerrit-PatchSet: 3
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 08 May 2020 03:57:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9570: [DOCS] add memory management
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15836 )
Change subject: IMPALA-9570: [DOCS] add memory management
......................................................................
Patch Set 2:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/590/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/15836
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e8b6d0c3fe2e1746831665b3d3ae98a0beaa1e7
Gerrit-Change-Number: 15836
Gerrit-PatchSet: 2
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 06 May 2020 17:42:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9570: [DOCS] add memory management
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15836 )
Change subject: IMPALA-9570: [DOCS] add memory management
......................................................................
IMPALA-9570: [DOCS] add memory management
add memory management and fix broken links. Incorporated review changes.
Change-Id: I6e8b6d0c3fe2e1746831665b3d3ae98a0beaa1e7
Reviewed-on: http://gerrit.cloudera.org:8080/15836
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M docs/impala_keydefs.ditamap
M docs/topics/impala_udf.xml
2 files changed, 10 insertions(+), 2 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/15836
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6e8b6d0c3fe2e1746831665b3d3ae98a0beaa1e7
Gerrit-Change-Number: 15836
Gerrit-PatchSet: 4
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-9570: [DOCS] add memory management
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15836 )
Change subject: IMPALA-9570: [DOCS] add memory management
......................................................................
Patch Set 2: Code-Review+2
Thanks for updating the doc.
--
To view, visit http://gerrit.cloudera.org:8080/15836
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e8b6d0c3fe2e1746831665b3d3ae98a0beaa1e7
Gerrit-Change-Number: 15836
Gerrit-PatchSet: 2
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 08 May 2020 03:54:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9570: [DOCS] add memory management
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15836 )
Change subject: IMPALA-9570: [DOCS] add memory management
......................................................................
Patch Set 1:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/589/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/15836
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e8b6d0c3fe2e1746831665b3d3ae98a0beaa1e7
Gerrit-Change-Number: 15836
Gerrit-PatchSet: 1
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 29 Apr 2020 22:04:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9570: [DOCS] add memory management
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15836 )
Change subject: IMPALA-9570: [DOCS] add memory management
......................................................................
Patch Set 2: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/590/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/15836
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e8b6d0c3fe2e1746831665b3d3ae98a0beaa1e7
Gerrit-Change-Number: 15836
Gerrit-PatchSet: 2
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 06 May 2020 17:50:27 +0000
Gerrit-HasComments: No