You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/10 23:37:43 UTC

[GitHub] [arrow-datafusion] andygrove opened a new pull request, #2507: MINOR: Enable multi-statement benchmark queries

andygrove opened a new pull request, #2507:
URL: https://github.com/apache/arrow-datafusion/pull/2507

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   N/A
   
    # Rationale for this change
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   
   q15.sql contains two SQL statements and this was not supported by the benchmark runner
   
   # What changes are included in this PR?
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   Support multiple queries per file
   
   # Are there any user-facing changes?
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   No
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] andygrove merged pull request #2507: MINOR: Enable multi-statement benchmark queries

Posted by GitBox <gi...@apache.org>.
andygrove merged PR #2507:
URL: https://github.com/apache/arrow-datafusion/pull/2507


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] andygrove commented on pull request #2507: MINOR: Enable multi-statement benchmark queries

Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #2507:
URL: https://github.com/apache/arrow-datafusion/pull/2507#issuecomment-1123115873

   > LGTM.
   > 
   > An off-topic question: I've noticed there were instructions on how to [get golden files](https://github.com/apache/arrow-datafusion/pull/34/files#diff-576c27794bae284efc278336a16d0649aaf599973a64d4b65dc67bc99bb7f000L37-L40) and get results verified but removed before. Do you think it's the time to add goldens and enable `verify_query` [here](https://github.com/apache/arrow-datafusion/blob/master/benchmarks/src/bin/tpch.rs#L914) for tpc-h?
   > 
   > Currently, these tests are skipped `TPCH_DATA environment variable not set, skipping test `
   
   The current approach is for developers to use the tpch toolkit to generate the expected answers locally and then set this env var to enable those tests. It would be nice if we could enable CI to do this as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] andygrove commented on pull request #2507: MINOR: Enable multi-statement benchmark queries

Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #2507:
URL: https://github.com/apache/arrow-datafusion/pull/2507#issuecomment-1123113875

   > When running Q15 do we get a new error now? Something like `CREATE VIEW` isnt implemented?
   
   Yes, exactly that!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] matthewmturner commented on pull request #2507: MINOR: Enable multi-statement benchmark queries

Posted by GitBox <gi...@apache.org>.
matthewmturner commented on PR #2507:
URL: https://github.com/apache/arrow-datafusion/pull/2507#issuecomment-1123020515

   When running Q15 do we get a new error now? Something like `CREATE VIEW` isnt implemented?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] matthewmturner commented on pull request #2507: MINOR: Enable multi-statement benchmark queries

Posted by GitBox <gi...@apache.org>.
matthewmturner commented on PR #2507:
URL: https://github.com/apache/arrow-datafusion/pull/2507#issuecomment-1123023604

   If we get this merged first i can enable Q15 in #2279 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org