You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "dan-s1 (via GitHub)" <gi...@apache.org> on 2026/07/03 20:12:42 UTC
[PR] NIFI-16703 Applied Pattern variable in other places in the code base and made preexisting pattern variables final [nifi]
dan-s1 opened a new pull request, #11392:
URL: https://github.com/apache/nifi/pull/11392
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
[NIFI-16703](https://issues.apache.org/jira/browse/NIFI-16703)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
- Pull request contains [commits signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) with a registered key indicating `Verified` status
### Pull Request Formatting
- Pull Request based on current revision of the `main` branch
- Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `./mvnw clean install -P contrib-check`
- [ ] JDK 21
- [ ] JDK 25
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-16703 Applied Pattern variable in other places in the code base and made preexisting pattern variables final [nifi]
Posted by "ChrisSamo632 (via GitHub)" <gi...@apache.org>.
ChrisSamo632 commented on PR #11392:
URL: https://github.com/apache/nifi/pull/11392#issuecomment-4879443690
> @exceptionfactory @pvillard31 Can you please help me figure out why the Validate Pull request build is failing? It is not clear from the logs why it is failing.
The jira ticket you've tried to link in the PR title (NIFI-16703) apparently doesn't exist. The PR must reference a valid jira ticket
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-16703 Applied Pattern variable in other places in the code base and made preexisting pattern variables final [nifi]
Posted by "dan-s1 (via GitHub)" <gi...@apache.org>.
dan-s1 commented on PR #11392:
URL: https://github.com/apache/nifi/pull/11392#issuecomment-4879155426
@exceptionfactory @pvillard31 Can you please help me figure out why the Validate Pull request build is failing. It is not apparent from the logs why it is failing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-16073 Applied Pattern variable in other places in the code base and made preexisting pattern variables final [nifi]
Posted by "pvillard31 (via GitHub)" <gi...@apache.org>.
pvillard31 commented on PR #11392:
URL: https://github.com/apache/nifi/pull/11392#issuecomment-4891015033
This now needs to be re-based on top of main and it should be OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-16073 Applied Pattern variable in other places in the code base and made preexisting pattern variables final [nifi]
Posted by "pvillard31 (via GitHub)" <gi...@apache.org>.
pvillard31 merged PR #11392:
URL: https://github.com/apache/nifi/pull/11392
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-16073 Applied Pattern variable in other places in the code base and made preexisting pattern variables final [nifi]
Posted by "pvillard31 (via GitHub)" <gi...@apache.org>.
pvillard31 commented on code in PR #11392:
URL: https://github.com/apache/nifi/pull/11392#discussion_r3536146768
##########
nifi-extension-bundles/nifi-graph-bundle/nifi-graph-processors/src/test/java/org/apache/nifi/processors/graph/util/InMemoryGraphClient.java:
##########
@@ -86,8 +86,8 @@ public Map<String, String> executeQuery(String query, Map<String, Object> parame
while (outerResultSet.hasNext()) {
Map.Entry<String, Object> innerResultSet = (Map.Entry<String, Object>) outerResultSet.next();
// this is for edge case handling where innerResultSet is also a Map
- if (innerResultSet.getValue() instanceof Map) {
- Iterator resultSet = ((Map) innerResultSet.getValue()).entrySet().iterator();
+ if (innerResultSet.getValue() instanceof Map map) {
+ Iterator resultSet = map.entrySet().iterator();
Review Comment:
final?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-16073 Applied Pattern variable in other places in the code base and made preexisting pattern variables final [nifi]
Posted by "dan-s1 (via GitHub)" <gi...@apache.org>.
dan-s1 commented on PR #11392:
URL: https://github.com/apache/nifi/pull/11392#issuecomment-4894198363
@ChrisSamo632 @pvillard31 Thank you very much for helping me resolve this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org