You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/11/03 13:43:45 UTC
[GitHub] [skywalking] EvanLjp opened a new pull request #5777: Fixed unit of time mixing problem in kubernetes-client
EvanLjp opened a new pull request #5777:
URL: https://github.com/apache/skywalking/pull/5777
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number.https://github.com/kubernetes-client/java/pull/1344(https://github.com/apache/skywalking/blob/c2141978d1039375598a32418b75161a78da22c1/CHANGES.md).
in Kubernetes-java-client, the millisecond is used to deliver to the API server.
but the unit in the API server is Second.
Because the feature was fixed in the last few days, so choose manually pass the time out parameter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #5777: Fixed unit of time mixing problem in kubernetes-client
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #5777:
URL: https://github.com/apache/skywalking/pull/5777
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] commented on pull request #5777: Fixed unit of time mixing problem in kubernetes-client
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #5777:
URL: https://github.com/apache/skywalking/pull/5777#issuecomment-720922608
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5777?src=pr&el=h1) Report
> Merging [#5777](https://codecov.io/gh/apache/skywalking/pull/5777?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d1c8831d318fb1e9d3d368d3ee76186881265f43?el=desc) will **decrease** coverage by `15.72%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5777?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5777 +/- ##
=============================================
- Coverage 51.51% 35.79% -15.73%
+ Complexity 3464 2005 -1459
=============================================
Files 1642 730 -912
Lines 35108 18341 -16767
Branches 3833 1696 -2137
=============================================
- Hits 18086 6565 -11521
+ Misses 16123 11280 -4843
+ Partials 899 496 -403
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5777?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5777/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh) | `0.00% <0.00%> (-18.92%)` | `0.00 <0.00> (ø)` | |
| [...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/5777/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==) | `0.00% <0.00%> (-3.45%)` | `0.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5777/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5777/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5777/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5777/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5777/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5777/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/5777/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...server/storage/plugin/influxdb/base/RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/5777/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL1JlY29yZERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [1274 more](https://codecov.io/gh/apache/skywalking/pull/5777/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5777?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5777?src=pr&el=footer). Last update [d1c8831...5c44f35](https://codecov.io/gh/apache/skywalking/pull/5777?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5777: Fixed unit of time mixing problem in kubernetes-client
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5777:
URL: https://github.com/apache/skywalking/pull/5777#issuecomment-720922608
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5777: Fixed unit of time mixing problem in kubernetes-client
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5777:
URL: https://github.com/apache/skywalking/pull/5777#discussion_r516450746
##########
File path: oap-server/server-cluster-plugin/cluster-kubernetes-plugin/src/main/java/org/apache/skywalking/oap/server/cluster/plugin/kubernetes/NamespacedPodListInformer.java
##########
@@ -83,7 +83,7 @@ private void doStartPodInformer(ClusterModuleKubernetesConfig podConfig) throws
SharedIndexInformer<V1Pod> podSharedIndexInformer = factory.sharedIndexInformerFor(
params -> coreV1Api.listNamespacedPodCall(
podConfig.getNamespace(), null, null, null, null,
- podConfig.getLabelSelector(), Integer.MAX_VALUE, params.resourceVersion, params.timeoutSeconds,
+ podConfig.getLabelSelector(), Integer.MAX_VALUE, params.resourceVersion, 300,
Review comment:
300 seconds? I am a little confused.
##########
File path: oap-server/server-cluster-plugin/cluster-kubernetes-plugin/src/main/java/org/apache/skywalking/oap/server/cluster/plugin/kubernetes/NamespacedPodListInformer.java
##########
@@ -83,7 +83,7 @@ private void doStartPodInformer(ClusterModuleKubernetesConfig podConfig) throws
SharedIndexInformer<V1Pod> podSharedIndexInformer = factory.sharedIndexInformerFor(
params -> coreV1Api.listNamespacedPodCall(
podConfig.getNamespace(), null, null, null, null,
- podConfig.getLabelSelector(), Integer.MAX_VALUE, params.resourceVersion, params.timeoutSeconds,
+ podConfig.getLabelSelector(), Integer.MAX_VALUE, params.resourceVersion, 300,
Review comment:
OK, got it now. Could you submit an issue to track this?
I think we need to upgrade the client to 10.1(maybe? the Last release is 10.0 already), and change this back to the right way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #5777: Fixed unit of time mixing problem in kubernetes-client
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #5777:
URL: https://github.com/apache/skywalking/pull/5777#discussion_r516451946
##########
File path: oap-server/server-cluster-plugin/cluster-kubernetes-plugin/src/main/java/org/apache/skywalking/oap/server/cluster/plugin/kubernetes/NamespacedPodListInformer.java
##########
@@ -83,7 +83,7 @@ private void doStartPodInformer(ClusterModuleKubernetesConfig podConfig) throws
SharedIndexInformer<V1Pod> podSharedIndexInformer = factory.sharedIndexInformerFor(
params -> coreV1Api.listNamespacedPodCall(
podConfig.getNamespace(), null, null, null, null,
- podConfig.getLabelSelector(), Integer.MAX_VALUE, params.resourceVersion, params.timeoutSeconds,
+ podConfig.getLabelSelector(), Integer.MAX_VALUE, params.resourceVersion, 300,
Review comment:
https://github.com/kubernetes-client/java/pull/1344/files
The default value is indeed 300s
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] EvanLjp commented on a change in pull request #5777: Fixed unit of time mixing problem in kubernetes-client
Posted by GitBox <gi...@apache.org>.
EvanLjp commented on a change in pull request #5777:
URL: https://github.com/apache/skywalking/pull/5777#discussion_r516451461
##########
File path: oap-server/server-cluster-plugin/cluster-kubernetes-plugin/src/main/java/org/apache/skywalking/oap/server/cluster/plugin/kubernetes/NamespacedPodListInformer.java
##########
@@ -83,7 +83,7 @@ private void doStartPodInformer(ClusterModuleKubernetesConfig podConfig) throws
SharedIndexInformer<V1Pod> podSharedIndexInformer = factory.sharedIndexInformerFor(
params -> coreV1Api.listNamespacedPodCall(
podConfig.getNamespace(), null, null, null, null,
- podConfig.getLabelSelector(), Integer.MAX_VALUE, params.resourceVersion, params.timeoutSeconds,
+ podConfig.getLabelSelector(), Integer.MAX_VALUE, params.resourceVersion, 300,
Review comment:
Follow the Kubernetes default configuration
##########
File path: oap-server/server-cluster-plugin/cluster-kubernetes-plugin/src/main/java/org/apache/skywalking/oap/server/cluster/plugin/kubernetes/NamespacedPodListInformer.java
##########
@@ -83,7 +83,7 @@ private void doStartPodInformer(ClusterModuleKubernetesConfig podConfig) throws
SharedIndexInformer<V1Pod> podSharedIndexInformer = factory.sharedIndexInformerFor(
params -> coreV1Api.listNamespacedPodCall(
podConfig.getNamespace(), null, null, null, null,
- podConfig.getLabelSelector(), Integer.MAX_VALUE, params.resourceVersion, params.timeoutSeconds,
+ podConfig.getLabelSelector(), Integer.MAX_VALUE, params.resourceVersion, 300,
Review comment:
https://github.com/apache/skywalking/issues/5778
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org