Re: [PR] [AMORO-3348] Extract the implementation of OptimizerManager [amoro]

["czy006 (via GitHub)" <gi...@apache.org>]

czy006 commented on code in PR #3437:
URL: https://github.com/apache/amoro/pull/3437#discussion_r1958993947


##########
amoro-ams/src/main/java/org/apache/amoro/server/DefaultOptimizingService.java:
##########
@@ -317,19 +318,7 @@ private OptimizingQueue getQueueByToken(String token) {
         .orElseThrow(() -> new PluginRetryAuthException("Optimizer has not been authenticated"));
   }
 
-  @Override
-  public List<OptimizerInstance> listOptimizers() {
-    return ImmutableList.copyOf(authOptimizers.values());
-  }
-
-  @Override
-  public List<OptimizerInstance> listOptimizers(String group) {
-    return authOptimizers.values().stream()
-        .filter(optimizer -> optimizer.getGroupName().equals(group))
-        .collect(Collectors.toList());
-  }
-
-  @Override
+  // TODO need to use optimizer manager

Review Comment:
   Need to impl Optimizer Manager,is that feature in next pr?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org