Re: [PR] HDDS-14350. Ratis configurations for ozone helm charts [ozone-helm-charts]

["shuan1026 (via GitHub)" <gi...@apache.org>]

shuan1026 commented on PR #51:
URL: https://github.com/apache/ozone-helm-charts/pull/51#issuecomment-5090999559

   > Thanks for the PR!
   > 
   > I’d love a bit more context on why we need this new configuration approach. Because it’s very generic and empty by default, users could supply any property through it (including non-Ratis ones). It seems like we can achieve the same outcome using the existing `configuration.files` or `configuration.filesFrom` properties. Unless there's a specific use case this addresses that the existing options don't, I'd suggest sticking with those to avoid duplication.
   
   Agreed. This isn't strictly necessary. Existing options already cover it (we can also use `om.env`). My read of this follow-up was mainly to give a clear entry point for slow-network ratis tuning and have those changes roll pods automatically, but keeping the chart simpler is also a good call. Happy to drop this and rely on the existing paths. :D


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org