[GitHub] [guacamole-server] necouchman commented on a change in pull request #243: GUACAMOLE-249: Migrate to FreeRDP 2.x

[GitBox <gi...@apache.org>]

necouchman commented on a change in pull request #243: GUACAMOLE-249: Migrate to FreeRDP 2.x
URL: https://github.com/apache/guacamole-server/pull/243#discussion_r363062567
 
 

 ##########
 File path: src/common/surface.c
 ##########
 @@ -260,58 +260,67 @@ static int __guac_common_surface_is_opaque(guac_common_surface* surface,
 
 /**
  * Returns whether the given rectangle should be combined into the existing
- * dirty rectangle, to be eventually flushed as a "png" instruction.
+ * dirty rectangle, to be eventually flushed as image data, or would be best
+ * kept independent of the current rectangle.
  *
- * @param surface The surface to be queried.
- * @param rect The update rectangle.
- * @param rect_only Non-zero if this update, by its nature, contains only
- *                  metainformation about the update's rectangle, zero if
- *                  the update also contains image data.
- * @return Non-zero if the update should be combined with any existing update,
- *         zero otherwise.
+ * @param surface
+ *     The surface being updated.
+ *
+ * @param rect
+ *     The bounding rectangle of the updating being made to the surface.
 
 Review comment:
   "of the updating being made" -> "of the update being made"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services