You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by mi...@apache.org on 2012/11/03 16:48:46 UTC
svn commit: r1405368 -
/lucene/dev/trunk/lucene/queries/src/java/org/apache/lucene/queries/TermsFilter.java
Author: mikemccand
Date: Sat Nov 3 15:48:46 2012
New Revision: 1405368
URL: http://svn.apache.org/viewvc?rev=1405368&view=rev
Log:
add TODOs
Modified:
lucene/dev/trunk/lucene/queries/src/java/org/apache/lucene/queries/TermsFilter.java
Modified: lucene/dev/trunk/lucene/queries/src/java/org/apache/lucene/queries/TermsFilter.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/queries/src/java/org/apache/lucene/queries/TermsFilter.java?rev=1405368&r1=1405367&r2=1405368&view=diff
==============================================================================
--- lucene/dev/trunk/lucene/queries/src/java/org/apache/lucene/queries/TermsFilter.java (original)
+++ lucene/dev/trunk/lucene/queries/src/java/org/apache/lucene/queries/TermsFilter.java Sat Nov 3 15:48:46 2012
@@ -114,6 +114,16 @@ public final class TermsFilter extends F
private TermsFilter(FieldAndTermEnum iter, int length) {
+ // TODO: maybe use oal.index.PrefixCodedTerms instead?
+ // If number of terms is more than a few hundred it
+ // should be a win
+
+ // TODO: we also pack terms in FieldCache/DocValues
+ // ... maybe we can refactor to share that code
+
+ // TODO: yet another option is to build the union of the terms in
+ // an automaton an call intersect on the termsenum if the density is high
+
int hash = 9;
byte[] serializedTerms = new byte[0];
this.offsets = new int[length+1];
@@ -199,10 +209,6 @@ public final class TermsFilter extends F
}
}
}
- /*
- * TODO: we should explore if it is worth to build the union of the terms in
- * an automaton an call intersect on the termsenum if the density is high
- */
return result;
}