You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by tgroh <gi...@git.apache.org> on 2016/04/06 19:14:33 UTC
[GitHub] incubator-beam pull request: [BEAM-44] Stop nesting Nullable coder...
GitHub user tgroh opened a pull request:
https://github.com/apache/incubator-beam/pull/136
[BEAM-44] Stop nesting Nullable coders
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace "<Jira issue #>" in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
A single layer of nullable coders is sufficient to safely encode
possibly-null values. This allows use of NullableCoder#of to wrap any
coder, without duplicating null-safety logic applied by NullableCoder.
Fixes BEAM-44
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tgroh/incubator-beam nullable_coder
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/136.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #136
----
commit 6f9fef4624b12ddce94cdc819472eb3a724dda33
Author: Thomas Groh <tg...@google.com>
Date: 2016-04-06T17:07:29Z
Stop nesting Nullable coders
A single layer of nullable coders is sufficient to safely encode
possibly-null values. This allows use of NullableCoder#of to wrap any
coder, without duplicating null-safety logic applied by NullableCoder.
Fixes BEAM-44
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-beam pull request: [BEAM-44] Stop nesting Nullable coder...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-beam/pull/136
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---