You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@singa.apache.org by GitBox <gi...@apache.org> on 2020/09/03 14:26:21 UTC
[GitHub] [singa] chrishkchris opened a new pull request #787: Fix the graph operation for
chrishkchris opened a new pull request #787:
URL: https://github.com/apache/singa/pull/787
Thanks Rulin @XJDKC for fixing the graph operation in this PR
The problem was due to the workspace variable in rnn.
The problem appears when the ops clean up the workspace variable (setValue->0) before use for rnn operation multiple times in the graph, while some ops using the workspace are independent to each other.
To solve the problem, if a tensor is written by multiple independent ops, these ops should be performed by time.
Some of the test:
```
root@64926e30597f:~/dcsysh/singa/examples/rnn# python3 imdb_train.py
epoch 0 loss [0.6489457]; acc 0.617
epoch 1 loss [0.55472153]; acc 0.715
epoch 2 loss [0.51863945]; acc 0.743
epoch 3 loss [0.49822766]; acc 0.758
epoch 4 loss [0.48312518]; acc 0.767
eval acc 0.750
root@64926e30597f:~/dcsysh/singa/examples/cnn# python3 train_cnn.py resnet cifar10 -b 32 -m 1
Starting Epoch 0:
Training loss = 2867.570801, training accuracy = 0.352753
Evaluation accuracy = 0.467448, Elapsed Time = 335.571664s
root@64926e30597f:~/dcsysh/singa/examples/cnn# python3 train_cnn.py resnet cifar10 -b 32 -m 1 -g
Starting Epoch 0:
Training loss = 2866.714111, training accuracy = 0.352693
Evaluation accuracy = 0.488381, Elapsed Time = 379.508079s
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] codecov[bot] edited a comment on pull request #787: Fix the graph operation when tensor is written by multiple independent ops
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #787:
URL: https://github.com/apache/singa/pull/787#issuecomment-686559807
# [Codecov](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=h1) Report
> Merging [#787](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/singa/commit/178b107741081332fb51d908e87e7fa26b69779e?el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `58.33%`.
[](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #787 +/- ##
==========================================
- Coverage 65.08% 65.07% -0.01%
==========================================
Files 86 86
Lines 4786 4799 +13
==========================================
+ Hits 3115 3123 +8
- Misses 1671 1676 +5
```
| [Impacted Files](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/core/scheduler/scheduler.cc](https://codecov.io/gh/apache/singa/pull/787/diff?src=pr&el=tree#diff-c3JjL2NvcmUvc2NoZWR1bGVyL3NjaGVkdWxlci5jYw==) | `54.29% <58.33%> (+0.12%)` | :arrow_up: |
| [include/singa/core/scheduler.h](https://codecov.io/gh/apache/singa/pull/787/diff?src=pr&el=tree#diff-aW5jbHVkZS9zaW5nYS9jb3JlL3NjaGVkdWxlci5o) | `71.42% <0.00%> (+2.19%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=footer). Last update [178b107...2bc6456](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] chrishkchris commented on pull request #787: Fix the graph operation when tensor is written by multiple independent ops
Posted by GitBox <gi...@apache.org>.
chrishkchris commented on pull request #787:
URL: https://github.com/apache/singa/pull/787#issuecomment-689347850
the codecov test finally pass
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] chrishkchris commented on pull request #787: Fix the graph operation when tensor is written by multiple independent ops
Posted by GitBox <gi...@apache.org>.
chrishkchris commented on pull request #787:
URL: https://github.com/apache/singa/pull/787#issuecomment-689317606
added test case to see if the codecov can pass or not
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] chrishkchris edited a comment on pull request #787: Fix the graph operation when tensor is written by multiple independent ops
Posted by GitBox <gi...@apache.org>.
chrishkchris edited a comment on pull request #787:
URL: https://github.com/apache/singa/pull/787#issuecomment-689347850
the codecov test finally pass
I have nothing else to change in this PR. Ready for merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] codecov[bot] edited a comment on pull request #787: Fix the graph operation when tensor is written by multiple independent ops
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #787:
URL: https://github.com/apache/singa/pull/787#issuecomment-686559807
# [Codecov](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=h1) Report
> Merging [#787](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/singa/commit/2cdb881f5f84844caa728574ca0ae9f619382cb4?el=desc) will **decrease** coverage by `4.98%`.
> The diff coverage is `58.33%`.
[](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #787 +/- ##
==========================================
- Coverage 70.05% 65.07% -4.99%
==========================================
Files 100 86 -14
Lines 11556 4799 -6757
==========================================
- Hits 8096 3123 -4973
+ Misses 3460 1676 -1784
```
| Flag | Coverage Δ | |
|---|---|---|
| #singa-cpp | `65.07% <58.33%> (-0.01%)` | :arrow_down: |
| #singa-python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/core/scheduler/scheduler.cc](https://codecov.io/gh/apache/singa/pull/787/diff?src=pr&el=tree#diff-c3JjL2NvcmUvc2NoZWR1bGVyL3NjaGVkdWxlci5jYw==) | `54.29% <58.33%> (+0.12%)` | :arrow_up: |
| [tensor.py](https://codecov.io/gh/apache/singa/pull/787/diff?src=pr&el=tree#diff-dGVuc29yLnB5) | | |
| [snapshot.py](https://codecov.io/gh/apache/singa/pull/787/diff?src=pr&el=tree#diff-c25hcHNob3QucHk=) | | |
| [utils.py](https://codecov.io/gh/apache/singa/pull/787/diff?src=pr&el=tree#diff-dXRpbHMucHk=) | | |
| [initializer.py](https://codecov.io/gh/apache/singa/pull/787/diff?src=pr&el=tree#diff-aW5pdGlhbGl6ZXIucHk=) | | |
| [sonnx.py](https://codecov.io/gh/apache/singa/pull/787/diff?src=pr&el=tree#diff-c29ubngucHk=) | | |
| [layer.py](https://codecov.io/gh/apache/singa/pull/787/diff?src=pr&el=tree#diff-bGF5ZXIucHk=) | | |
| [image\_tool.py](https://codecov.io/gh/apache/singa/pull/787/diff?src=pr&el=tree#diff-aW1hZ2VfdG9vbC5weQ==) | | |
| [device.py](https://codecov.io/gh/apache/singa/pull/787/diff?src=pr&el=tree#diff-ZGV2aWNlLnB5) | | |
| [autograd.py](https://codecov.io/gh/apache/singa/pull/787/diff?src=pr&el=tree#diff-YXV0b2dyYWQucHk=) | | |
| ... and [6 more](https://codecov.io/gh/apache/singa/pull/787/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=footer). Last update [2cdb881...2ad3552](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] codecov[bot] edited a comment on pull request #787: Fix the graph operation when tensor is written by multiple independent ops
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #787:
URL: https://github.com/apache/singa/pull/787#issuecomment-686559807
# [Codecov](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=h1) Report
> Merging [#787](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/singa/commit/2cdb881f5f84844caa728574ca0ae9f619382cb4?el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `75.00%`.
[](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #787 +/- ##
=======================================
Coverage 70.05% 70.06%
=======================================
Files 100 100
Lines 11556 11569 +13
=======================================
+ Hits 8096 8106 +10
- Misses 3460 3463 +3
```
| Flag | Coverage Δ | |
|---|---|---|
| #singa-cpp | `65.11% <75.00%> (+0.03%)` | :arrow_up: |
| #singa-python | `73.57% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/core/scheduler/scheduler.cc](https://codecov.io/gh/apache/singa/pull/787/diff?src=pr&el=tree#diff-c3JjL2NvcmUvc2NoZWR1bGVyL3NjaGVkdWxlci5jYw==) | `54.79% <75.00%> (+0.63%)` | :arrow_up: |
| [include/singa/core/scheduler.h](https://codecov.io/gh/apache/singa/pull/787/diff?src=pr&el=tree#diff-aW5jbHVkZS9zaW5nYS9jb3JlL3NjaGVkdWxlci5o) | `71.42% <0.00%> (+2.19%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=footer). Last update [2cdb881...b1cd1a8](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] codecov[bot] edited a comment on pull request #787: Fix the graph operation when tensor is written by multiple independent ops
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #787:
URL: https://github.com/apache/singa/pull/787#issuecomment-686559807
# [Codecov](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=h1) Report
> Merging [#787](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/singa/commit/2cdb881f5f84844caa728574ca0ae9f619382cb4?el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `75.00%`.
[](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #787 +/- ##
=======================================
Coverage 70.05% 70.06%
=======================================
Files 100 100
Lines 11556 11569 +13
=======================================
+ Hits 8096 8106 +10
- Misses 3460 3463 +3
```
| Flag | Coverage Δ | |
|---|---|---|
| #singa-cpp | `65.11% <75.00%> (+0.03%)` | :arrow_up: |
| #singa-python | `73.57% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/core/scheduler/scheduler.cc](https://codecov.io/gh/apache/singa/pull/787/diff?src=pr&el=tree#diff-c3JjL2NvcmUvc2NoZWR1bGVyL3NjaGVkdWxlci5jYw==) | `54.79% <75.00%> (+0.63%)` | :arrow_up: |
| [include/singa/core/scheduler.h](https://codecov.io/gh/apache/singa/pull/787/diff?src=pr&el=tree#diff-aW5jbHVkZS9zaW5nYS9jb3JlL3NjaGVkdWxlci5o) | `71.42% <0.00%> (+2.19%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=footer). Last update [2cdb881...b1cd1a8](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] codecov[bot] edited a comment on pull request #787: Fix the graph operation when tensor is written by multiple independent ops
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #787:
URL: https://github.com/apache/singa/pull/787#issuecomment-686559807
# [Codecov](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=h1) Report
> Merging [#787](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/singa/commit/178b107741081332fb51d908e87e7fa26b69779e?el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `58.33%`.
[](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #787 +/- ##
==========================================
- Coverage 65.08% 65.07% -0.01%
==========================================
Files 86 86
Lines 4786 4799 +13
==========================================
+ Hits 3115 3123 +8
- Misses 1671 1676 +5
```
| [Impacted Files](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/core/scheduler/scheduler.cc](https://codecov.io/gh/apache/singa/pull/787/diff?src=pr&el=tree#diff-c3JjL2NvcmUvc2NoZWR1bGVyL3NjaGVkdWxlci5jYw==) | `54.29% <58.33%> (+0.12%)` | :arrow_up: |
| [include/singa/core/scheduler.h](https://codecov.io/gh/apache/singa/pull/787/diff?src=pr&el=tree#diff-aW5jbHVkZS9zaW5nYS9jb3JlL3NjaGVkdWxlci5o) | `71.42% <0.00%> (+2.19%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=footer). Last update [178b107...2bc6456](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] nudles merged pull request #787: Fix the graph operation when tensor is written by multiple independent ops
Posted by GitBox <gi...@apache.org>.
nudles merged pull request #787:
URL: https://github.com/apache/singa/pull/787
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] codecov[bot] edited a comment on pull request #787: Fix the graph operation when tensor is written by multiple independent ops
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #787:
URL: https://github.com/apache/singa/pull/787#issuecomment-686559807
# [Codecov](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=h1) Report
> Merging [#787](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/singa/commit/178b107741081332fb51d908e87e7fa26b69779e?el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `58.33%`.
[](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #787 +/- ##
==========================================
- Coverage 65.08% 65.07% -0.01%
==========================================
Files 86 86
Lines 4786 4799 +13
==========================================
+ Hits 3115 3123 +8
- Misses 1671 1676 +5
```
| [Impacted Files](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/core/scheduler/scheduler.cc](https://codecov.io/gh/apache/singa/pull/787/diff?src=pr&el=tree#diff-c3JjL2NvcmUvc2NoZWR1bGVyL3NjaGVkdWxlci5jYw==) | `54.29% <58.33%> (+0.12%)` | :arrow_up: |
| [include/singa/core/scheduler.h](https://codecov.io/gh/apache/singa/pull/787/diff?src=pr&el=tree#diff-aW5jbHVkZS9zaW5nYS9jb3JlL3NjaGVkdWxlci5o) | `71.42% <0.00%> (+2.19%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=footer). Last update [178b107...2bc6456](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] codecov[bot] edited a comment on pull request #787: Fix the graph operation when tensor is written by multiple independent ops
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #787:
URL: https://github.com/apache/singa/pull/787#issuecomment-686559807
# [Codecov](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=h1) Report
> Merging [#787](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/singa/commit/178b107741081332fb51d908e87e7fa26b69779e?el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `58.33%`.
[](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #787 +/- ##
==========================================
- Coverage 65.08% 65.07% -0.01%
==========================================
Files 86 86
Lines 4786 4799 +13
==========================================
+ Hits 3115 3123 +8
- Misses 1671 1676 +5
```
| [Impacted Files](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/core/scheduler/scheduler.cc](https://codecov.io/gh/apache/singa/pull/787/diff?src=pr&el=tree#diff-c3JjL2NvcmUvc2NoZWR1bGVyL3NjaGVkdWxlci5jYw==) | `54.29% <58.33%> (+0.12%)` | :arrow_up: |
| [include/singa/core/scheduler.h](https://codecov.io/gh/apache/singa/pull/787/diff?src=pr&el=tree#diff-aW5jbHVkZS9zaW5nYS9jb3JlL3NjaGVkdWxlci5o) | `71.42% <0.00%> (+2.19%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=footer). Last update [178b107...11894cc](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] chrishkchris commented on pull request #787: Fix the graph operation when tensor is written by multiple independent ops
Posted by GitBox <gi...@apache.org>.
chrishkchris commented on pull request #787:
URL: https://github.com/apache/singa/pull/787#issuecomment-686537302
ready for merge
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] codecov[bot] commented on pull request #787: Fix the graph operation when tensor is written by multiple independent ops
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #787:
URL: https://github.com/apache/singa/pull/787#issuecomment-686559807
# [Codecov](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=h1) Report
> Merging [#787](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/singa/commit/178b107741081332fb51d908e87e7fa26b69779e?el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `58.33%`.
[](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #787 +/- ##
==========================================
- Coverage 65.08% 65.07% -0.01%
==========================================
Files 86 86
Lines 4786 4799 +13
==========================================
+ Hits 3115 3123 +8
- Misses 1671 1676 +5
```
| [Impacted Files](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/core/scheduler/scheduler.cc](https://codecov.io/gh/apache/singa/pull/787/diff?src=pr&el=tree#diff-c3JjL2NvcmUvc2NoZWR1bGVyL3NjaGVkdWxlci5jYw==) | `54.29% <58.33%> (+0.12%)` | :arrow_up: |
| [include/singa/core/scheduler.h](https://codecov.io/gh/apache/singa/pull/787/diff?src=pr&el=tree#diff-aW5jbHVkZS9zaW5nYS9jb3JlL3NjaGVkdWxlci5o) | `71.42% <0.00%> (+2.19%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=footer). Last update [178b107...11894cc](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] codecov[bot] edited a comment on pull request #787: Fix the graph operation when tensor is written by multiple independent ops
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #787:
URL: https://github.com/apache/singa/pull/787#issuecomment-686559807
# [Codecov](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=h1) Report
> Merging [#787](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/singa/commit/2cdb881f5f84844caa728574ca0ae9f619382cb4?el=desc) will **decrease** coverage by `4.98%`.
> The diff coverage is `58.33%`.
[](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #787 +/- ##
==========================================
- Coverage 70.05% 65.07% -4.99%
==========================================
Files 100 86 -14
Lines 11556 4799 -6757
==========================================
- Hits 8096 3123 -4973
+ Misses 3460 1676 -1784
```
| Flag | Coverage Δ | |
|---|---|---|
| #singa-cpp | `?` | |
| #singa-python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/core/scheduler/scheduler.cc](https://codecov.io/gh/apache/singa/pull/787/diff?src=pr&el=tree#diff-c3JjL2NvcmUvc2NoZWR1bGVyL3NjaGVkdWxlci5jYw==) | `54.29% <58.33%> (+0.12%)` | :arrow_up: |
| [device.py](https://codecov.io/gh/apache/singa/pull/787/diff?src=pr&el=tree#diff-ZGV2aWNlLnB5) | | |
| [sonnx.py](https://codecov.io/gh/apache/singa/pull/787/diff?src=pr&el=tree#diff-c29ubngucHk=) | | |
| [model.py](https://codecov.io/gh/apache/singa/pull/787/diff?src=pr&el=tree#diff-bW9kZWwucHk=) | | |
| [snapshot.py](https://codecov.io/gh/apache/singa/pull/787/diff?src=pr&el=tree#diff-c25hcHNob3QucHk=) | | |
| [initializer.py](https://codecov.io/gh/apache/singa/pull/787/diff?src=pr&el=tree#diff-aW5pdGlhbGl6ZXIucHk=) | | |
| [tensor.py](https://codecov.io/gh/apache/singa/pull/787/diff?src=pr&el=tree#diff-dGVuc29yLnB5) | | |
| [\_\_init\_\_.py](https://codecov.io/gh/apache/singa/pull/787/diff?src=pr&el=tree#diff-X19pbml0X18ucHk=) | | |
| [data.py](https://codecov.io/gh/apache/singa/pull/787/diff?src=pr&el=tree#diff-ZGF0YS5weQ==) | | |
| [opt.py](https://codecov.io/gh/apache/singa/pull/787/diff?src=pr&el=tree#diff-b3B0LnB5) | | |
| ... and [6 more](https://codecov.io/gh/apache/singa/pull/787/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=footer). Last update [2cdb881...2ad3552](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] codecov[bot] edited a comment on pull request #787: Fix the graph operation when tensor is written by multiple independent ops
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #787:
URL: https://github.com/apache/singa/pull/787#issuecomment-686559807
# [Codecov](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=h1) Report
> Merging [#787](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/singa/commit/2cdb881f5f84844caa728574ca0ae9f619382cb4?el=desc) will **decrease** coverage by `4.98%`.
> The diff coverage is `58.33%`.
[](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #787 +/- ##
==========================================
- Coverage 70.05% 65.07% -4.99%
==========================================
Files 100 86 -14
Lines 11556 4799 -6757
==========================================
- Hits 8096 3123 -4973
+ Misses 3460 1676 -1784
```
| Flag | Coverage Δ | |
|---|---|---|
| #singa-cpp | `65.07% <58.33%> (-0.01%)` | :arrow_down: |
| #singa-python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/core/scheduler/scheduler.cc](https://codecov.io/gh/apache/singa/pull/787/diff?src=pr&el=tree#diff-c3JjL2NvcmUvc2NoZWR1bGVyL3NjaGVkdWxlci5jYw==) | `54.29% <58.33%> (+0.12%)` | :arrow_up: |
| [image\_tool.py](https://codecov.io/gh/apache/singa/pull/787/diff?src=pr&el=tree#diff-aW1hZ2VfdG9vbC5weQ==) | | |
| [model.py](https://codecov.io/gh/apache/singa/pull/787/diff?src=pr&el=tree#diff-bW9kZWwucHk=) | | |
| [initializer.py](https://codecov.io/gh/apache/singa/pull/787/diff?src=pr&el=tree#diff-aW5pdGlhbGl6ZXIucHk=) | | |
| [singa\_wrap.py](https://codecov.io/gh/apache/singa/pull/787/diff?src=pr&el=tree#diff-c2luZ2Ffd3JhcC5weQ==) | | |
| [data.py](https://codecov.io/gh/apache/singa/pull/787/diff?src=pr&el=tree#diff-ZGF0YS5weQ==) | | |
| [tensor.py](https://codecov.io/gh/apache/singa/pull/787/diff?src=pr&el=tree#diff-dGVuc29yLnB5) | | |
| [autograd.py](https://codecov.io/gh/apache/singa/pull/787/diff?src=pr&el=tree#diff-YXV0b2dyYWQucHk=) | | |
| [device.py](https://codecov.io/gh/apache/singa/pull/787/diff?src=pr&el=tree#diff-ZGV2aWNlLnB5) | | |
| [sonnx.py](https://codecov.io/gh/apache/singa/pull/787/diff?src=pr&el=tree#diff-c29ubngucHk=) | | |
| ... and [6 more](https://codecov.io/gh/apache/singa/pull/787/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=footer). Last update [2cdb881...2ad3552](https://codecov.io/gh/apache/singa/pull/787?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org