You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Carlos Pita (JIRA)" <ji...@apache.org> on 2008/04/25 10:31:55 UTC
[jira] Created: (WICKET-1566) AbstractTransformerBehavior doesn't
honor the defaultMarkupEncoding
AbstractTransformerBehavior doesn't honor the defaultMarkupEncoding
-------------------------------------------------------------------
Key: WICKET-1566
URL: https://issues.apache.org/jira/browse/WICKET-1566
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.3.3
Reporter: Carlos Pita
Fix:
do
String charset = component.getApplication().getMarkupSettings().getDefaultMarkupEncoding();
webResponse.write(new ByteArrayInputStream(output).getBytes(charset)));
instead of
webResponse.write(output);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-1566) AbstractTransformerBehavior doesn't
honor character encoding
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg reassigned WICKET-1566:
-------------------------------------
Assignee: Juergen Donnerstag
> AbstractTransformerBehavior doesn't honor character encoding
> ------------------------------------------------------------
>
> Key: WICKET-1566
> URL: https://issues.apache.org/jira/browse/WICKET-1566
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.3
> Reporter: Carlos Pita
> Assignee: Juergen Donnerstag
>
> Fix:
> do
> String charset = component.getApplication().getMarkupSettings().getDefaultMarkupEncoding();
> webResponse.write(new ByteArrayInputStream(output).getBytes(charset)));
> instead of
> webResponse.write(output);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1566) AbstractTransformerBehavior doesn't
honor the defaultMarkupEncoding
Posted by "Carlos Pita (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12592662#action_12592662 ]
Carlos Pita commented on WICKET-1566:
-------------------------------------
Now I realize that this problem only happens in a modification of mine that can also transform pages (see
https://issues.apache.org/jira/browse/WICKET-1565). The problem is that the stringresponse doesn't forward the content type to the underlying webresponse, which ultimately configure the httpservletresponse encoding, this last being the one that determines the servlet response writer charset. A simple StringResponse subclass forwarding encoding related methods will do the trick, in case you're interested in implementing 1565.
StringResponse stringResponse = new StringResponse() {
@Override
public void setCharacterEncoding(String encoding) {
originalResponse.setCharacterEncoding(encoding);
}
@Override
public void setContentType(String mimeType) {
originalResponse.setContentType(mimeType);
}
};
> AbstractTransformerBehavior doesn't honor the defaultMarkupEncoding
> -------------------------------------------------------------------
>
> Key: WICKET-1566
> URL: https://issues.apache.org/jira/browse/WICKET-1566
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.3
> Reporter: Carlos Pita
>
> Fix:
> do
> String charset = component.getApplication().getMarkupSettings().getDefaultMarkupEncoding();
> webResponse.write(new ByteArrayInputStream(output).getBytes(charset)));
> instead of
> webResponse.write(output);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-1566) AbstractTransformerBehavior doesn't
honor character encoding
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Juergen Donnerstag resolved WICKET-1566.
----------------------------------------
Resolution: Invalid
As written by Carlos, it was a bug in his code
> AbstractTransformerBehavior doesn't honor character encoding
> ------------------------------------------------------------
>
> Key: WICKET-1566
> URL: https://issues.apache.org/jira/browse/WICKET-1566
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.3
> Reporter: Carlos Pita
> Assignee: Juergen Donnerstag
>
> Fix:
> do
> String charset = component.getApplication().getMarkupSettings().getDefaultMarkupEncoding();
> webResponse.write(new ByteArrayInputStream(output).getBytes(charset)));
> instead of
> webResponse.write(output);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1566) AbstractTransformerBehavior doesn't
honor character encoding
Posted by "Carlos Pita (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carlos Pita updated WICKET-1566:
--------------------------------
Summary: AbstractTransformerBehavior doesn't honor character encoding (was: AbstractTransformerBehavior doesn't honor the defaultMarkupEncoding)
> AbstractTransformerBehavior doesn't honor character encoding
> ------------------------------------------------------------
>
> Key: WICKET-1566
> URL: https://issues.apache.org/jira/browse/WICKET-1566
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.3
> Reporter: Carlos Pita
>
> Fix:
> do
> String charset = component.getApplication().getMarkupSettings().getDefaultMarkupEncoding();
> webResponse.write(new ByteArrayInputStream(output).getBytes(charset)));
> instead of
> webResponse.write(output);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.