[jira] [Commented] (BEAM-3027) Output type of SourceID-stripper is not correctly set

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-3027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16194549#comment-16194549 ] 

ASF GitHub Bot commented on BEAM-3027:
--------------------------------------

GitHub user aljoscha opened a pull request:

    https://github.com/apache/beam/pull/3953

    [BEAM-3027] Correctly set output type on SourceId-stripper

    R: @peihe or @JingsongLi or @mxm 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aljoscha/beam jira-3027-source-id-stripper-type

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3953.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3953
    
----
commit 713e7b08851702dae109313f9243fc9ed127fa33
Author: Aljoscha Krettek <al...@gmail.com>
Date:   2017-10-06T12:55:10Z

    [BEAM-3027] Correctly set output type on SourceId-stripper

----


> Output type of SourceID-stripper is not correctly set
> -----------------------------------------------------
>
>                 Key: BEAM-3027
>                 URL: https://issues.apache.org/jira/browse/BEAM-3027
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-flink
>            Reporter: Aljoscha Krettek
>            Assignee: Aljoscha Krettek
>            Priority: Blocker
>             Fix For: 2.2.0
>
>
> This code: https://github.com/apache/beam/blob/be9fb29901cf4a1ae7b4a9d8e9f25f4ea78359fd/runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkStreamingTransformTranslators.java#L193
> Does not set the output type of the flatMap to {{outputTypeInfo}}, which is the correct {{TypeInfo}} that uses the Beam coder. This means that Flink will use Kryo as a fallback, which can be problematic in cases.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)