You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by "abderrahim (via GitHub)" <gi...@apache.org> on 2023/10/22 13:39:57 UTC
[PR] docker: support url in addition to registry-url/image [buildstream-plugins]
abderrahim opened a new pull request, #58:
URL: https://github.com/apache/buildstream-plugins/pull/58
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docker: support url in addition to registry-url/image [buildstream-plugins]
Posted by "wsalmonct (via GitHub)" <gi...@apache.org>.
wsalmonct commented on PR #58:
URL: https://github.com/apache/buildstream-plugins/pull/58#issuecomment-1777223078
Does this silently ignore `image` and `registry-url` if `url` is present?
It raises a error if nether are present. but should it not also raise a error if both are?
The condition of both `image` and `url` does not cause a error as such but it does cause unexpected behaviour. usually if you provide a key that is not used then bst causes a error (node.validate_keys) so i think the extra error would follow the existing patten?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docker: support url in addition to registry-url/image [buildstream-plugins]
Posted by "gtristan (via GitHub)" <gi...@apache.org>.
gtristan commented on code in PR #58:
URL: https://github.com/apache/buildstream-plugins/pull/58#discussion_r1372556157
##########
src/buildstream_plugins/sources/docker.py:
##########
@@ -37,6 +37,10 @@
# Image path (required)
Review Comment:
Nit: We should at least remove the "(required)" part of the docs here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docker: support url in addition to registry-url/image [buildstream-plugins]
Posted by "abderrahim (via GitHub)" <gi...@apache.org>.
abderrahim merged PR #58:
URL: https://github.com/apache/buildstream-plugins/pull/58
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docker: support url in addition to registry-url/image [buildstream-plugins]
Posted by "abderrahim (via GitHub)" <gi...@apache.org>.
abderrahim commented on PR #58:
URL: https://github.com/apache/buildstream-plugins/pull/58#issuecomment-1774127738
> Looks good to me. I'm a bit worried if it's legal to have registry which is mounted deeper in URL (IOW first path segment is not v2)
Yeah, I don't see that when reading the [spec](https://distribution.github.io/distribution/spec/api/). But [the issue](https://gitlab.com/BuildStream/bst-external/-/issues/9) that led to this implementation seems to imply otherwise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docker: support url in addition to registry-url/image [buildstream-plugins]
Posted by "abderrahim (via GitHub)" <gi...@apache.org>.
abderrahim commented on PR #58:
URL: https://github.com/apache/buildstream-plugins/pull/58#issuecomment-1777460247
> Does this silently ignore `image` and `registry-url` if `url` is present?
>
> It raises a error if nether are present. but should it not also raise a error if both are?
Seems you're right. Somehow I thought the current condition would handle it.
> The condition of both `image` and `url` does not cause a error as such but it does cause unexpected behaviour. usually if you provide a key that is not used then bst causes a error (node.validate_keys) so i think the extra error would follow the existing patten?
I agree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docker: support url in addition to registry-url/image [buildstream-plugins]
Posted by "wsalmonct (via GitHub)" <gi...@apache.org>.
wsalmonct commented on PR #58:
URL: https://github.com/apache/buildstream-plugins/pull/58#issuecomment-1777657263
The new version looks good to me!
I don't have permission to approve but i would if i could.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org