[GitHub] [arrow] wjones127 commented on a diff in pull request #12775: ARROW-16006: [C++] Row conversion helpers and example

[GitBox <gi...@apache.org>]

wjones127 commented on code in PR #12775:
URL: https://github.com/apache/arrow/pull/12775#discussion_r895438582


##########
c_glib/arrow-glib/table-builder.cpp:
##########
@@ -155,11 +155,10 @@ garrow_record_batch_builder_new(GArrowSchema *schema, GError **error)
 {
   auto arrow_schema = garrow_schema_get_raw(schema);
   auto memory_pool = arrow::default_memory_pool();
-  std::unique_ptr<arrow::RecordBatchBuilder> arrow_builder;
-  auto status = arrow::RecordBatchBuilder::Make(arrow_schema,
-                                                memory_pool,
-                                                &arrow_builder);
-  if (garrow_error_check(error, status, "[record-batch-builder][new]")) {
+  auto builder_result = arrow::RecordBatchBuilder::Make(arrow_schema, memory_pool);
+
+  if (garrow::check(error, builder_result, "[record-batch-builder][new]")) {
+    std::unique_ptr<arrow::RecordBatchBuilder> arrow_builder = std::move(builder_result).ValueOrDie();

Review Comment:
   It's not related. I've moved this change to #13356 and will rebase after that's merged.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org