You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/04/09 11:58:30 UTC
[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2558: nrf5340 combine app/net build
apache-mynewt-bot removed a comment on pull request #2558:
URL: https://github.com/apache/mynewt-core/pull/2558#issuecomment-816604325
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### hw/mcu/nordic/nrf5340_net/src/hal_vflash.c
<details>
```diff
@@ -30,8 +30,8 @@
#define NRF5340_NET_VFLASH_SECTOR_SZ 2048
-#define NRF_APP_IPC_NS ((NRF_IPC_Type*)0x4002A000)
-#define NRF_APP_IPC_S ((NRF_IPC_Type*)0x5002A000)
+#define NRF_APP_IPC_NS ((NRF_IPC_Type *)0x4002A000)
+#define NRF_APP_IPC_S ((NRF_IPC_Type *)0x5002A000)
struct swap_data {
uint32_t encryption_key0[4];
```
</details>
#### hw/drivers/ipc_nrf5340/src/ipc_nrf5340.c
<details>
```diff
@@ -206,8 +206,8 @@
* This is a workaround that is needed till application side code waits
* on IPC for network core controller to sent NOP first.
*/
-#define NRF_APP_IPC_NS ((NRF_IPC_Type*)0x4002A000)
-#define NRF_APP_IPC_S ((NRF_IPC_Type*)0x5002A000)
+#define NRF_APP_IPC_NS ((NRF_IPC_Type *)0x4002A000)
+#define NRF_APP_IPC_S ((NRF_IPC_Type *)0x5002A000)
NRF_APP_IPC_S->GPMEM[0] = 0;
NRF_APP_IPC_S->GPMEM[1] = 0;
#endif
@@ -242,7 +242,7 @@
* Application side prepared image for net core.
* When net core starts it's ipc_nrf5340_init() will clear those.
*/
- while (NRF_IPC->GPMEM[1]) ;
+ while (NRF_IPC->GPMEM[1]);
}
#endif
}
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org