You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2022/01/21 10:07:16 UTC
[GitHub] [servicecomb-service-center] robotLJW opened a new pull request #1243: [feat] add task tombstone when db is mongo
robotLJW opened a new pull request #1243:
URL: https://github.com/apache/servicecomb-service-center/pull/1243
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
- [ ] Never comment source code, delete it.
- [ ] UT should has "context, subject, expected result" result as test case name, when you call t.Run().
---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-service-center] little-cui commented on a change in pull request #1243: [feat] add task tombstone when db is mongo
Posted by GitBox <gi...@apache.org>.
little-cui commented on a change in pull request #1243:
URL: https://github.com/apache/servicecomb-service-center/pull/1243#discussion_r790108879
##########
File path: datasource/mongo/account.go
##########
@@ -68,7 +70,15 @@ func (ds *RbacDAO) CreateAccount(ctx context.Context, a *rbacmodel.Account) erro
a.ID = util.GenerateUUID()
a.CreateTime = strconv.FormatInt(time.Now().Unix(), 10)
a.UpdateTime = a.CreateTime
- _, err = dmongo.GetClient().GetDB().Collection(model.CollectionAccount).InsertOne(ctx, a)
+ createFunc := func(sessionContext mongo.SessionContext) error {
Review comment:
直接抽取成方法，不用函数变量，其他地方也是类似修改
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-service-center] robotLJW commented on a change in pull request #1243: [feat] add task tombstone when db is mongo
Posted by GitBox <gi...@apache.org>.
robotLJW commented on a change in pull request #1243:
URL: https://github.com/apache/servicecomb-service-center/pull/1243#discussion_r790113754
##########
File path: datasource/mongo/account.go
##########
@@ -68,7 +70,15 @@ func (ds *RbacDAO) CreateAccount(ctx context.Context, a *rbacmodel.Account) erro
a.ID = util.GenerateUUID()
a.CreateTime = strconv.FormatInt(time.Now().Unix(), 10)
a.UpdateTime = a.CreateTime
- _, err = dmongo.GetClient().GetDB().Collection(model.CollectionAccount).InsertOne(ctx, a)
+ createFunc := func(sessionContext mongo.SessionContext) error {
Review comment:
已经修改，抽取成相应的crud的类型的txn的私有方法
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-service-center] little-cui merged pull request #1243: [feat] add task tombstone when db is mongo
Posted by GitBox <gi...@apache.org>.
little-cui merged pull request #1243:
URL: https://github.com/apache/servicecomb-service-center/pull/1243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org