[GitHub] [flink] KarmaGYZ commented on a change in pull request #11838: [FLINK-16965] Convert Graphite reporter to plugin

[GitBox <gi...@apache.org>]

KarmaGYZ commented on a change in pull request #11838:
URL: https://github.com/apache/flink/pull/11838#discussion_r413450999



##########
File path: flink-metrics/flink-metrics-graphite/pom.xml
##########
@@ -65,31 +65,4 @@ under the License.
 			<version>${dropwizard.version}</version>
 		</dependency>
 	</dependencies>
-
-	<build>
-		<plugins>
-			<plugin>
-				<groupId>org.apache.maven.plugins</groupId>
-				<artifactId>maven-shade-plugin</artifactId>
-				<executions>
-					<execution>
-						<id>shade-flink</id>
-						<phase>package</phase>
-						<goals>
-							<goal>shade</goal>
-						</goals>
-						<configuration>
-							<artifactSet>
-								<includes>
-									<include>org.apache.flink:flink-metrics-dropwizard</include>
-									<include>io.dropwizard.metrics:metrics-core</include>

Review comment:
       You mean we still need to shade "io.dropwizard.metrics:metrics-core" and "io.dropwizard.metrics:metrics-graphite", right?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org