[GitHub] [airflow] ryanahamilton commented on a change in pull request #11815: Render k8s yaml for tasks via the Airflow UI

[GitBox <gi...@apache.org>]

ryanahamilton commented on a change in pull request #11815:
URL: https://github.com/apache/airflow/pull/11815#discussion_r511936895



##########
File path: airflow/www/views.py
##########
@@ -808,11 +808,11 @@ def dag_details(self, session=None):
             tags=tags
         )
 
-    @expose('/rendered')
+    @expose('/rendered_templates')

Review comment:
       1. If we're going to change the URL of this view, I'd suggest we move to hyphens instead of underscores while we're at it. Hyphens are more of a standard pattern these days.
   2. Did you make this plural on purpose? The existing template navigation/heading is singular.
   3. Do we have to worry about aliasing/redirecting the old route to the new?
   
   ```suggestion
       @expose('/rendered-templates')
   ```

##########
File path: airflow/www/views.py
##########
@@ -860,6 +860,53 @@ def rendered(self):
             root=root,
             title=title)
 
+    @expose('/rendered_k8s')

Review comment:
       Use hyphen for this one too:
   ```suggestion
       @expose('/rendered-k8s')
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org