[GitHub] [skywalking-nodejs] tom-pytel opened a new pull request #39: HttpClient fixes

[GitBox <gi...@apache.org>]

tom-pytel opened a new pull request #39:
URL: https://github.com/apache/skywalking-nodejs/pull/39


   Fixed two HttpClient edge cases:
   * If an Exit span was created in an Entry span that is handling a "data" event then that child span would not be linked to the parent, like for example handling incoming POST data.
   * Wrapped `http.request()` callback if one is provided instead of event since it procs before the event handler and the same kind of Exit span problem would occur if an Exit span was created in the callback.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-nodejs] kezhenxu94 merged pull request #39: HttpClient fixes

[GitBox <gi...@apache.org>]

kezhenxu94 merged pull request #39:
URL: https://github.com/apache/skywalking-nodejs/pull/39


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org