You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2022/03/04 03:42:22 UTC

[GitHub] [thrift] kainjow commented on pull request #2489: THRIFT-2059: Support for Enums in Python >= 3.4

kainjow commented on pull request #2489:
URL: https://github.com/apache/thrift/pull/2489#issuecomment-1058796782


   > We do have plan to drop support for python 2, or python3 before 3.4 (as they are all EOL now), so if we do this after that we don't really have to do any special handling and can just support it blindly. but doing it now means that we still need to handle the case of <3.4 that `IntEnum` is not available?
   
   Yes that's right. But it might also be good to keep this as an option when introduced, and then in a later version make it the new default just to make sure it's stable.
   
   > I'm pretty sure these 2 travis failures do not show before this pr:
   > 
   > * https://app.travis-ci.com/github/apache/thrift/jobs/556647214
   > * https://app.travis-ci.com/github/apache/thrift/jobs/556647215
   
   ah, I only updated the CMake tests, looks like there's also equivalent for Make.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org