[GitHub] [tvm] lhutton1 commented on a diff in pull request #13407: [ACL] Enable int8 data type in QNN ADD

[GitBox <gi...@apache.org>]

lhutton1 commented on code in PR #13407:
URL: https://github.com/apache/tvm/pull/13407#discussion_r1024015646


##########
tests/python/contrib/test_arm_compute_lib/test_add.py:
##########
@@ -93,6 +93,7 @@ def test_runtime_add():
     for dtype, low, high, atol, rtol, op, op_params in [
         ("float32", -127, 128, 1e-7, 1e-7, relay.add, {}),
         ("uint8", 0, 255, 0.0, 1.0, relay.qnn.op.add, _qnn_params),
+        ("int8", -127, 128, 0.0, 1.0, relay.qnn.op.add, _qnn_params),

Review Comment:
   Nit: looks like there has been a mixup between `atol` and `rtol` previously, I'd expect `atol=1` and `rtol=0`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org