Re: [PR] chore: deprecate record_batch macro in favor of upstream one [datafusion]

["Jefffrey (via GitHub)" <gi...@apache.org>]

Jefffrey commented on code in PR #23295:
URL: https://github.com/apache/datafusion/pull/23295#discussion_r3522243921


##########
datafusion-examples/examples/ffi/ffi_example_table_provider/Cargo.toml:
##########
@@ -23,10 +23,14 @@ publish = false
 
 [dependencies]
 arrow = { workspace = true }
+arrow-schema = { workspace = true }
 datafusion = { workspace = true }
 datafusion-ffi = { workspace = true }
 ffi_module_interface = { path = "../ffi_module_interface" }
 
+[package.metadata.cargo-machete]
+ignored = ["arrow-schema"]

Review Comment:
   this seems pretty unfortunate, that its kind of a hidden dependency of the macro 🙁
   
   i suppose we cant do much about it unless we fix it upstream (and even then would require `arrow-array` to reexport `arrow-schema` i think?)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org