[jira] [Commented] (GEODE-8835) Incrementing connections despite of creation failed

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-8835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17265857#comment-17265857 ] 

ASF GitHub Bot commented on GEODE-8835:
---------------------------------------

mkevo opened a new pull request #5907:
URL: https://github.com/apache/geode/pull/5907


   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [x] Is your initial contribution a single, squashed commit?
   
   - [x] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Incrementing connections despite of creation failed
> ---------------------------------------------------
>
>                 Key: GEODE-8835
>                 URL: https://issues.apache.org/jira/browse/GEODE-8835
>             Project: Geode
>          Issue Type: Bug
>          Components: client/server
>            Reporter: Mario Kevo
>            Assignee: Mario Kevo
>            Priority: Major
>
> {color:#172b4d}Geode client in function OpExecutorImpl.execute() borrow connection from availableConnectionManager, but execute fail, then execute connectionManager.exchangeConnection(conn, attemptedServers), in this function will borrow again from availableConnectionManager again, but fail, then execute forceCreateConnection(excludedServers), in forceCreateConnection, it first add the connection "connectionAccounting.create()", but later create connection fail. So report "Unable to create a connection in the allowed time". and geode not process this abnormal case to dec the connectionAccounting. so it make the geode client think all connection in used and can't create connection again.{color}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)