You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/05 13:54:05 UTC

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #17425: Use `dag_maker` fixture in models/test_taskinstance.py

ephraimbuddy commented on a change in pull request #17425:
URL: https://github.com/apache/airflow/pull/17425#discussion_r683475029



##########
File path: tests/models/test_taskinstance.py
##########
@@ -1969,9 +1836,9 @@ def test_get_rendered_template_fields(self):
 
     @mock.patch.dict(os.environ, {"AIRFLOW_IS_K8S_EXECUTOR_POD": "True"})
     @mock.patch("airflow.settings.pod_mutation_hook")
-    def test_render_k8s_pod_yaml(self, pod_mutation_hook):
-        with DAG('test_get_rendered_k8s_spec', start_date=DEFAULT_DATE):
-            task = BashOperator(task_id='op1', bash_command="{{ task.task_id }}")
+    def test_render_k8s_pod_yaml(self, pod_mutation_hook, dag_maker):
+        with dag_maker('test_get_rendered_k8s_spec'):
+            task = BashOperator(task_id='op1', bash_command="{{ taTsk.task_id }}")

Review comment:
       The tests are failing here, any ideas?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org