You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2017/03/16 21:12:53 UTC
Review Request 57704: HDP 3.0 support for Tez with configs, kerberos,
widgets, metrics, quicklinks, and themes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57704/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez and Dmytro Sen.
Bugs: AMBARI-19833
https://issues.apache.org/jira/browse/AMBARI-19833
Repository: ambari
Description
-------
HDP 3.0 support for Tez with configs, kerberos, widgets, metrics, quicklinks, and themes
Flatten from HDP 2.0.6 - 2.6 into common-services, and reference in HDP 3.0
In HDP 3.0, we have created a new stack definition that does not inherit from other stacks, in order to reduce the complexity of having to analyze older stacks.
This means that we need to create a service definition (metainfo.xml, configs, kerberos, widgets, metrics, quicklinks, and themes) that is equivalent to what is inherit and deleted from all of the previous stacks.
A merge needs to account for additions, overrides, and deletions.
metainfo.xml and configs perform a merge of older versions
kerberos.json always seems to override the previous file
Because the bits for this service may not yet be available in the HDP 3.0 repo,
the task is to ensure that /api/v1/stacks/HDP/versions/2.6/services/TEZ (which uses inheritance) is equivalent to the flattening of /api/v1/stacks/HDP/versions/3.0/services/TEZ .
Please take a look at how this was done for ZK, HDFS, and YARN/MR.
This means that you will not be able to actually install the service for now, but can still perform validation during the Install Wizard that the correct components and configs show up.
Diffs
-----
ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/configuration/tez-env.xml PRE-CREATION
ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/configuration/tez-site.xml PRE-CREATION
ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/kerberos.json PRE-CREATION
ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/metainfo.xml PRE-CREATION
ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/package/scripts/params.py PRE-CREATION
ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/package/scripts/params_linux.py PRE-CREATION
ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/package/scripts/params_windows.py PRE-CREATION
ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/package/scripts/pre_upgrade.py PRE-CREATION
ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/package/scripts/service_check.py PRE-CREATION
ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/package/scripts/tez.py PRE-CREATION
ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/package/scripts/tez_client.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/3.0/services/TEZ/metainfo.xml PRE-CREATION
Diff: https://reviews.apache.org/r/57704/diff/1/
Testing
-------
Thanks,
Vitalyi Brodetskyi
Re: Review Request 57704: HDP 3.0 support for Tez with configs,
kerberos, widgets, metrics, quicklinks, and themes
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57704/#review169218
-----------------------------------------------------------
Fix it, then Ship it!
Fix it and ship it, thanks!
ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/configuration/tez-site.xml
Lines 485 (patched)
<https://reviews.apache.org/r/57704/#comment241555>
Let's set all of these configs to <on-ambari-upgrade add="false" />
- Alejandro Fernandez
On March 16, 2017, 9:12 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57704/
> -----------------------------------------------------------
>
> (Updated March 16, 2017, 9:12 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Dmytro Sen.
>
>
> Bugs: AMBARI-19833
> https://issues.apache.org/jira/browse/AMBARI-19833
>
>
> Repository: ambari
>
>
> Description
> -------
>
> HDP 3.0 support for Tez with configs, kerberos, widgets, metrics, quicklinks, and themes
> Flatten from HDP 2.0.6 - 2.6 into common-services, and reference in HDP 3.0
> In HDP 3.0, we have created a new stack definition that does not inherit from other stacks, in order to reduce the complexity of having to analyze older stacks.
> This means that we need to create a service definition (metainfo.xml, configs, kerberos, widgets, metrics, quicklinks, and themes) that is equivalent to what is inherit and deleted from all of the previous stacks.
> A merge needs to account for additions, overrides, and deletions.
> metainfo.xml and configs perform a merge of older versions
> kerberos.json always seems to override the previous file
> Because the bits for this service may not yet be available in the HDP 3.0 repo,
> the task is to ensure that /api/v1/stacks/HDP/versions/2.6/services/TEZ (which uses inheritance) is equivalent to the flattening of /api/v1/stacks/HDP/versions/3.0/services/TEZ .
> Please take a look at how this was done for ZK, HDFS, and YARN/MR.
> This means that you will not be able to actually install the service for now, but can still perform validation during the Install Wizard that the correct components and configs show up.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/configuration/tez-env.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/configuration/tez-site.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/package/scripts/params_linux.py PRE-CREATION
> ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/package/scripts/params_windows.py PRE-CREATION
> ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/package/scripts/pre_upgrade.py PRE-CREATION
> ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/package/scripts/service_check.py PRE-CREATION
> ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/package/scripts/tez.py PRE-CREATION
> ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/package/scripts/tez_client.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/3.0/services/TEZ/metainfo.xml PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/57704/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 57704: HDP 3.0 support for Tez with configs,
kerberos, widgets, metrics, quicklinks, and themes
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57704/#review169289
-----------------------------------------------------------
Ship it!
Ship It!
- Dmytro Sen
On \u041c\u0430\u0440\u0442 17, 2017, 1:07 \u043f.\u043f., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57704/
> -----------------------------------------------------------
>
> (Updated \u041c\u0430\u0440\u0442 17, 2017, 1:07 \u043f.\u043f.)
>
>
> Review request for Ambari, Alejandro Fernandez and Dmytro Sen.
>
>
> Bugs: AMBARI-19833
> https://issues.apache.org/jira/browse/AMBARI-19833
>
>
> Repository: ambari
>
>
> Description
> -------
>
> HDP 3.0 support for Tez with configs, kerberos, widgets, metrics, quicklinks, and themes
> Flatten from HDP 2.0.6 - 2.6 into common-services, and reference in HDP 3.0
> In HDP 3.0, we have created a new stack definition that does not inherit from other stacks, in order to reduce the complexity of having to analyze older stacks.
> This means that we need to create a service definition (metainfo.xml, configs, kerberos, widgets, metrics, quicklinks, and themes) that is equivalent to what is inherit and deleted from all of the previous stacks.
> A merge needs to account for additions, overrides, and deletions.
> metainfo.xml and configs perform a merge of older versions
> kerberos.json always seems to override the previous file
> Because the bits for this service may not yet be available in the HDP 3.0 repo,
> the task is to ensure that /api/v1/stacks/HDP/versions/2.6/services/TEZ (which uses inheritance) is equivalent to the flattening of /api/v1/stacks/HDP/versions/3.0/services/TEZ .
> Please take a look at how this was done for ZK, HDFS, and YARN/MR.
> This means that you will not be able to actually install the service for now, but can still perform validation during the Install Wizard that the correct components and configs show up.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/configuration/tez-env.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/configuration/tez-site.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/package/scripts/params_linux.py PRE-CREATION
> ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/package/scripts/params_windows.py PRE-CREATION
> ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/package/scripts/pre_upgrade.py PRE-CREATION
> ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/package/scripts/service_check.py PRE-CREATION
> ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/package/scripts/tez.py PRE-CREATION
> ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/package/scripts/tez_client.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/3.0/services/TEZ/metainfo.xml PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/57704/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 57704: HDP 3.0 support for Tez with configs,
kerberos, widgets, metrics, quicklinks, and themes
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57704/#review169304
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On March 17, 2017, 1:07 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57704/
> -----------------------------------------------------------
>
> (Updated March 17, 2017, 1:07 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Dmytro Sen.
>
>
> Bugs: AMBARI-19833
> https://issues.apache.org/jira/browse/AMBARI-19833
>
>
> Repository: ambari
>
>
> Description
> -------
>
> HDP 3.0 support for Tez with configs, kerberos, widgets, metrics, quicklinks, and themes
> Flatten from HDP 2.0.6 - 2.6 into common-services, and reference in HDP 3.0
> In HDP 3.0, we have created a new stack definition that does not inherit from other stacks, in order to reduce the complexity of having to analyze older stacks.
> This means that we need to create a service definition (metainfo.xml, configs, kerberos, widgets, metrics, quicklinks, and themes) that is equivalent to what is inherit and deleted from all of the previous stacks.
> A merge needs to account for additions, overrides, and deletions.
> metainfo.xml and configs perform a merge of older versions
> kerberos.json always seems to override the previous file
> Because the bits for this service may not yet be available in the HDP 3.0 repo,
> the task is to ensure that /api/v1/stacks/HDP/versions/2.6/services/TEZ (which uses inheritance) is equivalent to the flattening of /api/v1/stacks/HDP/versions/3.0/services/TEZ .
> Please take a look at how this was done for ZK, HDFS, and YARN/MR.
> This means that you will not be able to actually install the service for now, but can still perform validation during the Install Wizard that the correct components and configs show up.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/configuration/tez-env.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/configuration/tez-site.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/package/scripts/params_linux.py PRE-CREATION
> ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/package/scripts/params_windows.py PRE-CREATION
> ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/package/scripts/pre_upgrade.py PRE-CREATION
> ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/package/scripts/service_check.py PRE-CREATION
> ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/package/scripts/tez.py PRE-CREATION
> ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/package/scripts/tez_client.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/3.0/services/TEZ/metainfo.xml PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/57704/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 57704: HDP 3.0 support for Tez with configs,
kerberos, widgets, metrics, quicklinks, and themes
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57704/
-----------------------------------------------------------
(Updated \u0411\u0435\u0440\u0435\u0437\u0435\u043d\u044c 17, 2017, 1:07 \u043f\u0456\u0441\u043b\u044f \u043f\u043e\u043b\u0443\u0434\u043d\u044f)
Review request for Ambari, Alejandro Fernandez and Dmytro Sen.
Bugs: AMBARI-19833
https://issues.apache.org/jira/browse/AMBARI-19833
Repository: ambari
Description
-------
HDP 3.0 support for Tez with configs, kerberos, widgets, metrics, quicklinks, and themes
Flatten from HDP 2.0.6 - 2.6 into common-services, and reference in HDP 3.0
In HDP 3.0, we have created a new stack definition that does not inherit from other stacks, in order to reduce the complexity of having to analyze older stacks.
This means that we need to create a service definition (metainfo.xml, configs, kerberos, widgets, metrics, quicklinks, and themes) that is equivalent to what is inherit and deleted from all of the previous stacks.
A merge needs to account for additions, overrides, and deletions.
metainfo.xml and configs perform a merge of older versions
kerberos.json always seems to override the previous file
Because the bits for this service may not yet be available in the HDP 3.0 repo,
the task is to ensure that /api/v1/stacks/HDP/versions/2.6/services/TEZ (which uses inheritance) is equivalent to the flattening of /api/v1/stacks/HDP/versions/3.0/services/TEZ .
Please take a look at how this was done for ZK, HDFS, and YARN/MR.
This means that you will not be able to actually install the service for now, but can still perform validation during the Install Wizard that the correct components and configs show up.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/configuration/tez-env.xml PRE-CREATION
ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/configuration/tez-site.xml PRE-CREATION
ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/kerberos.json PRE-CREATION
ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/metainfo.xml PRE-CREATION
ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/package/scripts/params.py PRE-CREATION
ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/package/scripts/params_linux.py PRE-CREATION
ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/package/scripts/params_windows.py PRE-CREATION
ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/package/scripts/pre_upgrade.py PRE-CREATION
ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/package/scripts/service_check.py PRE-CREATION
ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/package/scripts/tez.py PRE-CREATION
ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/package/scripts/tez_client.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/3.0/services/TEZ/metainfo.xml PRE-CREATION
Diff: https://reviews.apache.org/r/57704/diff/2/
Changes: https://reviews.apache.org/r/57704/diff/1-2/
Testing
-------
Thanks,
Vitalyi Brodetskyi