You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/09/07 02:51:01 UTC
[GitHub] zhijiangW commented on a change in pull request #6417:
[FLINK-9913][runtime] Improve output serialization only once in RecordWriter
zhijiangW commented on a change in pull request #6417: [FLINK-9913][runtime] Improve output serialization only once in RecordWriter
URL: https://github.com/apache/flink/pull/6417#discussion_r215832704
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/RecordWriter.java
##########
@@ -197,40 +214,39 @@ public void setMetricGroup(TaskIOMetricGroup metrics) {
* Marks the current {@link BufferBuilder} as finished and clears the state for next one.
*/
private void tryFinishCurrentBufferBuilder(int targetChannel) {
- if (bufferBuilders[targetChannel].isPresent()) {
- BufferBuilder bufferBuilder = bufferBuilders[targetChannel].get();
+ Optional<BufferBuilder> bufferBuilderOpt = bufferBuilders[targetChannel];
Review comment:
I also have not seen throughput improvements for this change, then I will revert this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services