You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/11/23 03:35:10 UTC
[GitHub] [netbeans] BradWalker opened a new pull request #2556: [NETBEANS-5053] - cleanup Set raw type warnings..
BradWalker opened a new pull request #2556:
URL: https://github.com/apache/netbeans/pull/2556
I am trying to cleanup a bunch of the Set raw type warnings.. They look like this..
[repeat] /home/bwalker/src/netbeans/cpplite/cpplite.debugger/src/org/netbeans/modules/cpplite/debugger/breakpoints/CPPLiteBreakpointActionProvider.java:50: warning: [rawtypes] found raw type: Set
[repeat] private static final Set actions = Collections.singleton (
[repeat] ^
[repeat] missing type arguments for generic class Set<E>
[repeat] where E is a type-variable:
[repeat] E extends Object declared in interface Set
This change reduces the warnings dramatically. The ones remaining are in public interfaces
and it's beyond the scope for me to tackle that.. Hopefully, in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on a change in pull request #2556: [NETBEANS-5053] - cleanup Set raw type warnings..
Posted by GitBox <gi...@apache.org>.
BradWalker commented on a change in pull request #2556:
URL: https://github.com/apache/netbeans/pull/2556#discussion_r529045063
##########
File path: ide/xsl/src/org/netbeans/modules/xsl/grammar/XSLGrammarQuery.java
##########
@@ -136,33 +136,33 @@ private static Map getElementDecls() {
// Commonly used variables
Set emptySet = new TreeSet();
String spaceAtt = "xml:space"; // NOI18N
- Set tmpSet;
+ Set<String> tmpSet;
////////////////////////////////////////////////
// Initialize common sets
- Set charInstructions = new TreeSet(Arrays.asList(new String[]{"apply-templates", // NOI18N
+ Set<String> charInstructions = new TreeSet<>(Arrays.<String>asList(new String[]{"apply-templates", // NOI18N
"call-template","apply-imports","for-each","value-of", // NOI18N
"copy-of","number","choose","if","text","copy", // NOI18N
"variable","message","fallback"})); // NOI18N
- Set instructions = new TreeSet(charInstructions);
- instructions.addAll(Arrays.asList(new String[]{"processing-instruction", // NOI18N
+ Set<String> instructions = new TreeSet<>(charInstructions);
+ instructions.addAll(Arrays.<String>asList(new String[]{"processing-instruction", // NOI18N
"comment","element","attribute"})); // NOI18N
- Set charTemplate = charInstructions; // We don't care about PCDATA
+ Set<String> charTemplate = charInstructions; // We don't care about PCDATA
- template = new TreeSet(instructions);
+ template = new TreeSet<>(instructions);
template.add(resultElements);
- Set topLevel = new TreeSet(Arrays.asList(new String[]{"import","include","strip-space", // NOI18N
+ Set<String> topLevel = new TreeSet<>(Arrays.<String>asList(new String[]{"import","include","strip-space", // NOI18N
"preserve-space","output","key","decimal-format","attribute-set", // NOI18N
"variable","param","template","namespace-alias"})); // NOI18N
- Set topLevelAttr = new TreeSet(Arrays.asList(new String[]{"extension-element-prefixes", // NOI18N
+ Set<String> topLevelAttr = new TreeSet(Arrays.<String>asList(new String[]{"extension-element-prefixes", // NOI18N
Review comment:
changed..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on a change in pull request #2556: [NETBEANS-5053] - cleanup Set raw type warnings..
Posted by GitBox <gi...@apache.org>.
BradWalker commented on a change in pull request #2556:
URL: https://github.com/apache/netbeans/pull/2556#discussion_r529045769
##########
File path: ide/xsl/src/org/netbeans/modules/xsl/grammar/XSLGrammarQuery.java
##########
@@ -136,33 +136,33 @@ private static Map getElementDecls() {
// Commonly used variables
Set emptySet = new TreeSet();
String spaceAtt = "xml:space"; // NOI18N
- Set tmpSet;
+ Set<String> tmpSet;
////////////////////////////////////////////////
// Initialize common sets
- Set charInstructions = new TreeSet(Arrays.asList(new String[]{"apply-templates", // NOI18N
+ Set<String> charInstructions = new TreeSet<>(Arrays.<String>asList(new String[]{"apply-templates", // NOI18N
Review comment:
changed..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on a change in pull request #2556: [NETBEANS-5053] - cleanup Set raw type warnings..
Posted by GitBox <gi...@apache.org>.
BradWalker commented on a change in pull request #2556:
URL: https://github.com/apache/netbeans/pull/2556#discussion_r529022292
##########
File path: ide/xsl/src/org/netbeans/modules/xsl/grammar/XSLGrammarQuery.java
##########
@@ -378,7 +378,7 @@ private static Set getXslFunctions() {
private static Set getXPathAxes() {
if (xpathAxes == null) {
- xpathAxes = new TreeSet(Arrays.asList(new String[]{"ancestor::", "ancestor-or-self::", // NOI18N
+ xpathAxes = new TreeSet<>(Arrays.<String>asList(new String[]{"ancestor::", "ancestor-or-self::", // NOI18N
Review comment:
changed..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on a change in pull request #2556: [NETBEANS-5053] - cleanup Set raw type warnings..
Posted by GitBox <gi...@apache.org>.
BradWalker commented on a change in pull request #2556:
URL: https://github.com/apache/netbeans/pull/2556#discussion_r529045541
##########
File path: ide/xsl/src/org/netbeans/modules/xsl/grammar/XSLGrammarQuery.java
##########
@@ -378,7 +378,7 @@ private static Set getXslFunctions() {
private static Set getXPathAxes() {
if (xpathAxes == null) {
- xpathAxes = new TreeSet(Arrays.asList(new String[]{"ancestor::", "ancestor-or-self::", // NOI18N
+ xpathAxes = new TreeSet<>(Arrays.<String>asList(new String[]{"ancestor::", "ancestor-or-self::", // NOI18N
Review comment:
changed..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on a change in pull request #2556: [NETBEANS-5053] - cleanup Set raw type warnings..
Posted by GitBox <gi...@apache.org>.
BradWalker commented on a change in pull request #2556:
URL: https://github.com/apache/netbeans/pull/2556#discussion_r529045353
##########
File path: ide/xsl/src/org/netbeans/modules/xsl/grammar/XSLGrammarQuery.java
##########
@@ -365,7 +365,7 @@ private static Set getTemplate() {
private static Set getXslFunctions() {
if (xslFunctions == null) {
- xslFunctions = new TreeSet(Arrays.asList(new String[]{
+ xslFunctions = new TreeSet<>(Arrays.<String>asList(new String[]{
Review comment:
changed..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on a change in pull request #2556: [NETBEANS-5053] - cleanup Set raw type warnings..
Posted by GitBox <gi...@apache.org>.
BradWalker commented on a change in pull request #2556:
URL: https://github.com/apache/netbeans/pull/2556#discussion_r529017587
##########
File path: java/ant.debugger/src/org/netbeans/modules/ant/debugger/AntDebugger.java
##########
@@ -306,9 +306,8 @@ private void stopHere(AntEvent event) {
updateUI();
currentFile = event.getScriptLocation();
// update variable values
- Set properties = event.getPropertyNames ();
- variables = (String[]) properties.toArray
- (new String [properties.size ()]);
+ Set<String> properties = event.getPropertyNames();
+ variables = (String[])properties.toArray(new String [properties.size()]);
Review comment:
Fixed..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on a change in pull request #2556: [NETBEANS-5053] - cleanup Set raw type warnings..
Posted by GitBox <gi...@apache.org>.
BradWalker commented on a change in pull request #2556:
URL: https://github.com/apache/netbeans/pull/2556#discussion_r529044764
##########
File path: ide/xsl/src/org/netbeans/modules/xsl/grammar/XSLGrammarQuery.java
##########
@@ -136,33 +136,33 @@ private static Map getElementDecls() {
// Commonly used variables
Set emptySet = new TreeSet();
String spaceAtt = "xml:space"; // NOI18N
- Set tmpSet;
+ Set<String> tmpSet;
////////////////////////////////////////////////
// Initialize common sets
- Set charInstructions = new TreeSet(Arrays.asList(new String[]{"apply-templates", // NOI18N
+ Set<String> charInstructions = new TreeSet<>(Arrays.<String>asList(new String[]{"apply-templates", // NOI18N
"call-template","apply-imports","for-each","value-of", // NOI18N
"copy-of","number","choose","if","text","copy", // NOI18N
"variable","message","fallback"})); // NOI18N
- Set instructions = new TreeSet(charInstructions);
- instructions.addAll(Arrays.asList(new String[]{"processing-instruction", // NOI18N
+ Set<String> instructions = new TreeSet<>(charInstructions);
+ instructions.addAll(Arrays.<String>asList(new String[]{"processing-instruction", // NOI18N
Review comment:
changed..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing merged pull request #2556: [NETBEANS-5053] - cleanup Set raw type warnings..
Posted by GitBox <gi...@apache.org>.
matthiasblaesing merged pull request #2556:
URL: https://github.com/apache/netbeans/pull/2556
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on a change in pull request #2556: [NETBEANS-5053] - cleanup Set raw type warnings..
Posted by GitBox <gi...@apache.org>.
BradWalker commented on a change in pull request #2556:
URL: https://github.com/apache/netbeans/pull/2556#discussion_r529022292
##########
File path: ide/xsl/src/org/netbeans/modules/xsl/grammar/XSLGrammarQuery.java
##########
@@ -378,7 +378,7 @@ private static Set getXslFunctions() {
private static Set getXPathAxes() {
if (xpathAxes == null) {
- xpathAxes = new TreeSet(Arrays.asList(new String[]{"ancestor::", "ancestor-or-self::", // NOI18N
+ xpathAxes = new TreeSet<>(Arrays.<String>asList(new String[]{"ancestor::", "ancestor-or-self::", // NOI18N
Review comment:
changed..
##########
File path: ide/xsl/src/org/netbeans/modules/xsl/grammar/XSLGrammarQuery.java
##########
@@ -136,33 +136,33 @@ private static Map getElementDecls() {
// Commonly used variables
Set emptySet = new TreeSet();
String spaceAtt = "xml:space"; // NOI18N
- Set tmpSet;
+ Set<String> tmpSet;
////////////////////////////////////////////////
// Initialize common sets
- Set charInstructions = new TreeSet(Arrays.asList(new String[]{"apply-templates", // NOI18N
+ Set<String> charInstructions = new TreeSet<>(Arrays.<String>asList(new String[]{"apply-templates", // NOI18N
"call-template","apply-imports","for-each","value-of", // NOI18N
"copy-of","number","choose","if","text","copy", // NOI18N
"variable","message","fallback"})); // NOI18N
- Set instructions = new TreeSet(charInstructions);
- instructions.addAll(Arrays.asList(new String[]{"processing-instruction", // NOI18N
+ Set<String> instructions = new TreeSet<>(charInstructions);
+ instructions.addAll(Arrays.<String>asList(new String[]{"processing-instruction", // NOI18N
"comment","element","attribute"})); // NOI18N
- Set charTemplate = charInstructions; // We don't care about PCDATA
+ Set<String> charTemplate = charInstructions; // We don't care about PCDATA
- template = new TreeSet(instructions);
+ template = new TreeSet<>(instructions);
template.add(resultElements);
- Set topLevel = new TreeSet(Arrays.asList(new String[]{"import","include","strip-space", // NOI18N
+ Set<String> topLevel = new TreeSet<>(Arrays.<String>asList(new String[]{"import","include","strip-space", // NOI18N
"preserve-space","output","key","decimal-format","attribute-set", // NOI18N
"variable","param","template","namespace-alias"})); // NOI18N
- Set topLevelAttr = new TreeSet(Arrays.asList(new String[]{"extension-element-prefixes", // NOI18N
+ Set<String> topLevelAttr = new TreeSet(Arrays.<String>asList(new String[]{"extension-element-prefixes", // NOI18N
"exclude-result-prefixes","id","version",spaceAtt})); // NOI18N
- resultElementAttr = new TreeSet(Arrays.asList(new String[]{"extension-element-prefixes", // NOI18N
+ resultElementAttr = new TreeSet<>(Arrays.<String>asList(new String[]{"extension-element-prefixes", // NOI18N
Review comment:
changed..
##########
File path: ide/xsl/src/org/netbeans/modules/xsl/grammar/XSLGrammarQuery.java
##########
@@ -136,33 +136,33 @@ private static Map getElementDecls() {
// Commonly used variables
Set emptySet = new TreeSet();
String spaceAtt = "xml:space"; // NOI18N
- Set tmpSet;
+ Set<String> tmpSet;
////////////////////////////////////////////////
// Initialize common sets
- Set charInstructions = new TreeSet(Arrays.asList(new String[]{"apply-templates", // NOI18N
+ Set<String> charInstructions = new TreeSet<>(Arrays.<String>asList(new String[]{"apply-templates", // NOI18N
"call-template","apply-imports","for-each","value-of", // NOI18N
"copy-of","number","choose","if","text","copy", // NOI18N
"variable","message","fallback"})); // NOI18N
- Set instructions = new TreeSet(charInstructions);
- instructions.addAll(Arrays.asList(new String[]{"processing-instruction", // NOI18N
+ Set<String> instructions = new TreeSet<>(charInstructions);
+ instructions.addAll(Arrays.<String>asList(new String[]{"processing-instruction", // NOI18N
"comment","element","attribute"})); // NOI18N
- Set charTemplate = charInstructions; // We don't care about PCDATA
+ Set<String> charTemplate = charInstructions; // We don't care about PCDATA
- template = new TreeSet(instructions);
+ template = new TreeSet<>(instructions);
template.add(resultElements);
- Set topLevel = new TreeSet(Arrays.asList(new String[]{"import","include","strip-space", // NOI18N
+ Set<String> topLevel = new TreeSet<>(Arrays.<String>asList(new String[]{"import","include","strip-space", // NOI18N
"preserve-space","output","key","decimal-format","attribute-set", // NOI18N
"variable","param","template","namespace-alias"})); // NOI18N
- Set topLevelAttr = new TreeSet(Arrays.asList(new String[]{"extension-element-prefixes", // NOI18N
+ Set<String> topLevelAttr = new TreeSet(Arrays.<String>asList(new String[]{"extension-element-prefixes", // NOI18N
Review comment:
changed..
##########
File path: ide/xsl/src/org/netbeans/modules/xsl/grammar/XSLGrammarQuery.java
##########
@@ -136,33 +136,33 @@ private static Map getElementDecls() {
// Commonly used variables
Set emptySet = new TreeSet();
String spaceAtt = "xml:space"; // NOI18N
- Set tmpSet;
+ Set<String> tmpSet;
////////////////////////////////////////////////
// Initialize common sets
- Set charInstructions = new TreeSet(Arrays.asList(new String[]{"apply-templates", // NOI18N
+ Set<String> charInstructions = new TreeSet<>(Arrays.<String>asList(new String[]{"apply-templates", // NOI18N
"call-template","apply-imports","for-each","value-of", // NOI18N
"copy-of","number","choose","if","text","copy", // NOI18N
"variable","message","fallback"})); // NOI18N
- Set instructions = new TreeSet(charInstructions);
- instructions.addAll(Arrays.asList(new String[]{"processing-instruction", // NOI18N
+ Set<String> instructions = new TreeSet<>(charInstructions);
+ instructions.addAll(Arrays.<String>asList(new String[]{"processing-instruction", // NOI18N
"comment","element","attribute"})); // NOI18N
- Set charTemplate = charInstructions; // We don't care about PCDATA
+ Set<String> charTemplate = charInstructions; // We don't care about PCDATA
- template = new TreeSet(instructions);
+ template = new TreeSet<>(instructions);
template.add(resultElements);
- Set topLevel = new TreeSet(Arrays.asList(new String[]{"import","include","strip-space", // NOI18N
+ Set<String> topLevel = new TreeSet<>(Arrays.<String>asList(new String[]{"import","include","strip-space", // NOI18N
Review comment:
changed..
##########
File path: ide/xsl/src/org/netbeans/modules/xsl/grammar/XSLGrammarQuery.java
##########
@@ -136,33 +136,33 @@ private static Map getElementDecls() {
// Commonly used variables
Set emptySet = new TreeSet();
String spaceAtt = "xml:space"; // NOI18N
- Set tmpSet;
+ Set<String> tmpSet;
////////////////////////////////////////////////
// Initialize common sets
- Set charInstructions = new TreeSet(Arrays.asList(new String[]{"apply-templates", // NOI18N
+ Set<String> charInstructions = new TreeSet<>(Arrays.<String>asList(new String[]{"apply-templates", // NOI18N
Review comment:
changed..
##########
File path: ide/xsl/src/org/netbeans/modules/xsl/grammar/XSLGrammarQuery.java
##########
@@ -136,33 +136,33 @@ private static Map getElementDecls() {
// Commonly used variables
Set emptySet = new TreeSet();
String spaceAtt = "xml:space"; // NOI18N
- Set tmpSet;
+ Set<String> tmpSet;
////////////////////////////////////////////////
// Initialize common sets
- Set charInstructions = new TreeSet(Arrays.asList(new String[]{"apply-templates", // NOI18N
+ Set<String> charInstructions = new TreeSet<>(Arrays.<String>asList(new String[]{"apply-templates", // NOI18N
"call-template","apply-imports","for-each","value-of", // NOI18N
"copy-of","number","choose","if","text","copy", // NOI18N
"variable","message","fallback"})); // NOI18N
- Set instructions = new TreeSet(charInstructions);
- instructions.addAll(Arrays.asList(new String[]{"processing-instruction", // NOI18N
+ Set<String> instructions = new TreeSet<>(charInstructions);
+ instructions.addAll(Arrays.<String>asList(new String[]{"processing-instruction", // NOI18N
Review comment:
changed..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on a change in pull request #2556: [NETBEANS-5053] - cleanup Set raw type warnings..
Posted by GitBox <gi...@apache.org>.
BradWalker commented on a change in pull request #2556:
URL: https://github.com/apache/netbeans/pull/2556#discussion_r529045213
##########
File path: ide/xsl/src/org/netbeans/modules/xsl/grammar/XSLGrammarQuery.java
##########
@@ -136,33 +136,33 @@ private static Map getElementDecls() {
// Commonly used variables
Set emptySet = new TreeSet();
String spaceAtt = "xml:space"; // NOI18N
- Set tmpSet;
+ Set<String> tmpSet;
////////////////////////////////////////////////
// Initialize common sets
- Set charInstructions = new TreeSet(Arrays.asList(new String[]{"apply-templates", // NOI18N
+ Set<String> charInstructions = new TreeSet<>(Arrays.<String>asList(new String[]{"apply-templates", // NOI18N
"call-template","apply-imports","for-each","value-of", // NOI18N
"copy-of","number","choose","if","text","copy", // NOI18N
"variable","message","fallback"})); // NOI18N
- Set instructions = new TreeSet(charInstructions);
- instructions.addAll(Arrays.asList(new String[]{"processing-instruction", // NOI18N
+ Set<String> instructions = new TreeSet<>(charInstructions);
+ instructions.addAll(Arrays.<String>asList(new String[]{"processing-instruction", // NOI18N
"comment","element","attribute"})); // NOI18N
- Set charTemplate = charInstructions; // We don't care about PCDATA
+ Set<String> charTemplate = charInstructions; // We don't care about PCDATA
- template = new TreeSet(instructions);
+ template = new TreeSet<>(instructions);
template.add(resultElements);
- Set topLevel = new TreeSet(Arrays.asList(new String[]{"import","include","strip-space", // NOI18N
+ Set<String> topLevel = new TreeSet<>(Arrays.<String>asList(new String[]{"import","include","strip-space", // NOI18N
"preserve-space","output","key","decimal-format","attribute-set", // NOI18N
"variable","param","template","namespace-alias"})); // NOI18N
- Set topLevelAttr = new TreeSet(Arrays.asList(new String[]{"extension-element-prefixes", // NOI18N
+ Set<String> topLevelAttr = new TreeSet(Arrays.<String>asList(new String[]{"extension-element-prefixes", // NOI18N
"exclude-result-prefixes","id","version",spaceAtt})); // NOI18N
- resultElementAttr = new TreeSet(Arrays.asList(new String[]{"extension-element-prefixes", // NOI18N
+ resultElementAttr = new TreeSet<>(Arrays.<String>asList(new String[]{"extension-element-prefixes", // NOI18N
Review comment:
chnaged..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #2556: [NETBEANS-5053] - cleanup Set raw type warnings..
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #2556:
URL: https://github.com/apache/netbeans/pull/2556#issuecomment-733178752
Thank you - lets get this in.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on a change in pull request #2556: [NETBEANS-5053] - cleanup Set raw type warnings..
Posted by GitBox <gi...@apache.org>.
BradWalker commented on a change in pull request #2556:
URL: https://github.com/apache/netbeans/pull/2556#discussion_r529021745
##########
File path: ide/xsl/src/org/netbeans/modules/xsl/grammar/XSLGrammarQuery.java
##########
@@ -136,33 +136,33 @@ private static Map getElementDecls() {
// Commonly used variables
Set emptySet = new TreeSet();
String spaceAtt = "xml:space"; // NOI18N
- Set tmpSet;
+ Set<String> tmpSet;
////////////////////////////////////////////////
// Initialize common sets
- Set charInstructions = new TreeSet(Arrays.asList(new String[]{"apply-templates", // NOI18N
+ Set<String> charInstructions = new TreeSet<>(Arrays.<String>asList(new String[]{"apply-templates", // NOI18N
"call-template","apply-imports","for-each","value-of", // NOI18N
"copy-of","number","choose","if","text","copy", // NOI18N
"variable","message","fallback"})); // NOI18N
- Set instructions = new TreeSet(charInstructions);
- instructions.addAll(Arrays.asList(new String[]{"processing-instruction", // NOI18N
+ Set<String> instructions = new TreeSet<>(charInstructions);
+ instructions.addAll(Arrays.<String>asList(new String[]{"processing-instruction", // NOI18N
"comment","element","attribute"})); // NOI18N
- Set charTemplate = charInstructions; // We don't care about PCDATA
+ Set<String> charTemplate = charInstructions; // We don't care about PCDATA
- template = new TreeSet(instructions);
+ template = new TreeSet<>(instructions);
template.add(resultElements);
- Set topLevel = new TreeSet(Arrays.asList(new String[]{"import","include","strip-space", // NOI18N
+ Set<String> topLevel = new TreeSet<>(Arrays.<String>asList(new String[]{"import","include","strip-space", // NOI18N
"preserve-space","output","key","decimal-format","attribute-set", // NOI18N
"variable","param","template","namespace-alias"})); // NOI18N
- Set topLevelAttr = new TreeSet(Arrays.asList(new String[]{"extension-element-prefixes", // NOI18N
+ Set<String> topLevelAttr = new TreeSet(Arrays.<String>asList(new String[]{"extension-element-prefixes", // NOI18N
Review comment:
changed..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on pull request #2556: [NETBEANS-5053] - cleanup Set raw type warnings..
Posted by GitBox <gi...@apache.org>.
BradWalker commented on pull request #2556:
URL: https://github.com/apache/netbeans/pull/2556#issuecomment-732474919
Hey @mklaehn , I tried to also remove the array creation.. But, it gave me an error.. So I left it.. But, I did make the suggested changed you had..
Thanks very much for looking at this!!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on a change in pull request #2556: [NETBEANS-5053] - cleanup Set raw type warnings..
Posted by GitBox <gi...@apache.org>.
BradWalker commented on a change in pull request #2556:
URL: https://github.com/apache/netbeans/pull/2556#discussion_r529018875
##########
File path: ide/xsl/src/org/netbeans/modules/xsl/grammar/XSLGrammarQuery.java
##########
@@ -136,33 +136,33 @@ private static Map getElementDecls() {
// Commonly used variables
Set emptySet = new TreeSet();
String spaceAtt = "xml:space"; // NOI18N
- Set tmpSet;
+ Set<String> tmpSet;
////////////////////////////////////////////////
// Initialize common sets
- Set charInstructions = new TreeSet(Arrays.asList(new String[]{"apply-templates", // NOI18N
+ Set<String> charInstructions = new TreeSet<>(Arrays.<String>asList(new String[]{"apply-templates", // NOI18N
Review comment:
changed..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on a change in pull request #2556: [NETBEANS-5053] - cleanup Set raw type warnings..
Posted by GitBox <gi...@apache.org>.
BradWalker commented on a change in pull request #2556:
URL: https://github.com/apache/netbeans/pull/2556#discussion_r529022001
##########
File path: ide/xsl/src/org/netbeans/modules/xsl/grammar/XSLGrammarQuery.java
##########
@@ -136,33 +136,33 @@ private static Map getElementDecls() {
// Commonly used variables
Set emptySet = new TreeSet();
String spaceAtt = "xml:space"; // NOI18N
- Set tmpSet;
+ Set<String> tmpSet;
////////////////////////////////////////////////
// Initialize common sets
- Set charInstructions = new TreeSet(Arrays.asList(new String[]{"apply-templates", // NOI18N
+ Set<String> charInstructions = new TreeSet<>(Arrays.<String>asList(new String[]{"apply-templates", // NOI18N
"call-template","apply-imports","for-each","value-of", // NOI18N
"copy-of","number","choose","if","text","copy", // NOI18N
"variable","message","fallback"})); // NOI18N
- Set instructions = new TreeSet(charInstructions);
- instructions.addAll(Arrays.asList(new String[]{"processing-instruction", // NOI18N
+ Set<String> instructions = new TreeSet<>(charInstructions);
+ instructions.addAll(Arrays.<String>asList(new String[]{"processing-instruction", // NOI18N
"comment","element","attribute"})); // NOI18N
- Set charTemplate = charInstructions; // We don't care about PCDATA
+ Set<String> charTemplate = charInstructions; // We don't care about PCDATA
- template = new TreeSet(instructions);
+ template = new TreeSet<>(instructions);
template.add(resultElements);
- Set topLevel = new TreeSet(Arrays.asList(new String[]{"import","include","strip-space", // NOI18N
+ Set<String> topLevel = new TreeSet<>(Arrays.<String>asList(new String[]{"import","include","strip-space", // NOI18N
"preserve-space","output","key","decimal-format","attribute-set", // NOI18N
"variable","param","template","namespace-alias"})); // NOI18N
- Set topLevelAttr = new TreeSet(Arrays.asList(new String[]{"extension-element-prefixes", // NOI18N
+ Set<String> topLevelAttr = new TreeSet(Arrays.<String>asList(new String[]{"extension-element-prefixes", // NOI18N
"exclude-result-prefixes","id","version",spaceAtt})); // NOI18N
- resultElementAttr = new TreeSet(Arrays.asList(new String[]{"extension-element-prefixes", // NOI18N
+ resultElementAttr = new TreeSet<>(Arrays.<String>asList(new String[]{"extension-element-prefixes", // NOI18N
Review comment:
changed..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on a change in pull request #2556: [NETBEANS-5053] - cleanup Set raw type warnings..
Posted by GitBox <gi...@apache.org>.
BradWalker commented on a change in pull request #2556:
URL: https://github.com/apache/netbeans/pull/2556#discussion_r529018128
##########
File path: ide/xsl/src/org/netbeans/modules/xsl/grammar/XSLGrammarQuery.java
##########
@@ -136,33 +136,33 @@ private static Map getElementDecls() {
// Commonly used variables
Set emptySet = new TreeSet();
String spaceAtt = "xml:space"; // NOI18N
- Set tmpSet;
+ Set<String> tmpSet;
////////////////////////////////////////////////
// Initialize common sets
- Set charInstructions = new TreeSet(Arrays.asList(new String[]{"apply-templates", // NOI18N
+ Set<String> charInstructions = new TreeSet<>(Arrays.<String>asList(new String[]{"apply-templates", // NOI18N
"call-template","apply-imports","for-each","value-of", // NOI18N
"copy-of","number","choose","if","text","copy", // NOI18N
"variable","message","fallback"})); // NOI18N
- Set instructions = new TreeSet(charInstructions);
- instructions.addAll(Arrays.asList(new String[]{"processing-instruction", // NOI18N
+ Set<String> instructions = new TreeSet<>(charInstructions);
+ instructions.addAll(Arrays.<String>asList(new String[]{"processing-instruction", // NOI18N
Review comment:
changed..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mklaehn commented on a change in pull request #2556: [NETBEANS-5053] - cleanup Set raw type warnings..
Posted by GitBox <gi...@apache.org>.
mklaehn commented on a change in pull request #2556:
URL: https://github.com/apache/netbeans/pull/2556#discussion_r528562470
##########
File path: java/ant.debugger/src/org/netbeans/modules/ant/debugger/AntDebugger.java
##########
@@ -306,9 +306,8 @@ private void stopHere(AntEvent event) {
updateUI();
currentFile = event.getScriptLocation();
// update variable values
- Set properties = event.getPropertyNames ();
- variables = (String[]) properties.toArray
- (new String [properties.size ()]);
+ Set<String> properties = event.getPropertyNames();
+ variables = (String[])properties.toArray(new String [properties.size()]);
Review comment:
Redundant cast after change
```suggestion
variables = properties.toArray(new String [properties.size()]);
```
##########
File path: ide/xsl/src/org/netbeans/modules/xsl/grammar/XSLGrammarQuery.java
##########
@@ -136,33 +136,33 @@ private static Map getElementDecls() {
// Commonly used variables
Set emptySet = new TreeSet();
String spaceAtt = "xml:space"; // NOI18N
- Set tmpSet;
+ Set<String> tmpSet;
////////////////////////////////////////////////
// Initialize common sets
- Set charInstructions = new TreeSet(Arrays.asList(new String[]{"apply-templates", // NOI18N
+ Set<String> charInstructions = new TreeSet<>(Arrays.<String>asList(new String[]{"apply-templates", // NOI18N
"call-template","apply-imports","for-each","value-of", // NOI18N
"copy-of","number","choose","if","text","copy", // NOI18N
"variable","message","fallback"})); // NOI18N
- Set instructions = new TreeSet(charInstructions);
- instructions.addAll(Arrays.asList(new String[]{"processing-instruction", // NOI18N
+ Set<String> instructions = new TreeSet<>(charInstructions);
+ instructions.addAll(Arrays.<String>asList(new String[]{"processing-instruction", // NOI18N
Review comment:
inferrable type informations
```suggestion
instructions.addAll(Arrays.asList(new String[]{"processing-instruction", // NOI18N
```
strictly speaking the array creation is not needed as well
##########
File path: ide/xsl/src/org/netbeans/modules/xsl/grammar/XSLGrammarQuery.java
##########
@@ -136,33 +136,33 @@ private static Map getElementDecls() {
// Commonly used variables
Set emptySet = new TreeSet();
String spaceAtt = "xml:space"; // NOI18N
- Set tmpSet;
+ Set<String> tmpSet;
////////////////////////////////////////////////
// Initialize common sets
- Set charInstructions = new TreeSet(Arrays.asList(new String[]{"apply-templates", // NOI18N
+ Set<String> charInstructions = new TreeSet<>(Arrays.<String>asList(new String[]{"apply-templates", // NOI18N
Review comment:
inferrable type informations
```suggestion
Set<String> charInstructions = new TreeSet<>(Arrays.asList(new String[]{"apply-templates", // NOI18N
```
strictly speaking the array creation is not needed as well
##########
File path: ide/xsl/src/org/netbeans/modules/xsl/grammar/XSLGrammarQuery.java
##########
@@ -365,7 +365,7 @@ private static Set getTemplate() {
private static Set getXslFunctions() {
if (xslFunctions == null) {
- xslFunctions = new TreeSet(Arrays.asList(new String[]{
+ xslFunctions = new TreeSet<>(Arrays.<String>asList(new String[]{
Review comment:
inferrable type informations
```suggestion
xslFunctions = new TreeSet<>(Arrays.asList(new String[]{
```
strictly speaking the array creation is not needed as well
##########
File path: ide/xsl/src/org/netbeans/modules/xsl/grammar/XSLGrammarQuery.java
##########
@@ -136,33 +136,33 @@ private static Map getElementDecls() {
// Commonly used variables
Set emptySet = new TreeSet();
String spaceAtt = "xml:space"; // NOI18N
- Set tmpSet;
+ Set<String> tmpSet;
////////////////////////////////////////////////
// Initialize common sets
- Set charInstructions = new TreeSet(Arrays.asList(new String[]{"apply-templates", // NOI18N
+ Set<String> charInstructions = new TreeSet<>(Arrays.<String>asList(new String[]{"apply-templates", // NOI18N
"call-template","apply-imports","for-each","value-of", // NOI18N
"copy-of","number","choose","if","text","copy", // NOI18N
"variable","message","fallback"})); // NOI18N
- Set instructions = new TreeSet(charInstructions);
- instructions.addAll(Arrays.asList(new String[]{"processing-instruction", // NOI18N
+ Set<String> instructions = new TreeSet<>(charInstructions);
+ instructions.addAll(Arrays.<String>asList(new String[]{"processing-instruction", // NOI18N
"comment","element","attribute"})); // NOI18N
- Set charTemplate = charInstructions; // We don't care about PCDATA
+ Set<String> charTemplate = charInstructions; // We don't care about PCDATA
- template = new TreeSet(instructions);
+ template = new TreeSet<>(instructions);
template.add(resultElements);
- Set topLevel = new TreeSet(Arrays.asList(new String[]{"import","include","strip-space", // NOI18N
+ Set<String> topLevel = new TreeSet<>(Arrays.<String>asList(new String[]{"import","include","strip-space", // NOI18N
Review comment:
inferrable type informations
```suggestion
Set<String> topLevel = new TreeSet<>(Arrays.asList(new String[]{"import","include","strip-space", // NOI18N
```
strictly speaking the array creation is not needed as well
##########
File path: ide/xsl/src/org/netbeans/modules/xsl/grammar/XSLGrammarQuery.java
##########
@@ -378,7 +378,7 @@ private static Set getXslFunctions() {
private static Set getXPathAxes() {
if (xpathAxes == null) {
- xpathAxes = new TreeSet(Arrays.asList(new String[]{"ancestor::", "ancestor-or-self::", // NOI18N
+ xpathAxes = new TreeSet<>(Arrays.<String>asList(new String[]{"ancestor::", "ancestor-or-self::", // NOI18N
Review comment:
inferrable type informations
```suggestion
xpathAxes = new TreeSet<>(Arrays.asList(new String[]{"ancestor::", "ancestor-or-self::", // NOI18N
```
strictly speaking the array creation is not needed as well
##########
File path: ide/xsl/src/org/netbeans/modules/xsl/grammar/XSLGrammarQuery.java
##########
@@ -136,33 +136,33 @@ private static Map getElementDecls() {
// Commonly used variables
Set emptySet = new TreeSet();
String spaceAtt = "xml:space"; // NOI18N
- Set tmpSet;
+ Set<String> tmpSet;
////////////////////////////////////////////////
// Initialize common sets
- Set charInstructions = new TreeSet(Arrays.asList(new String[]{"apply-templates", // NOI18N
+ Set<String> charInstructions = new TreeSet<>(Arrays.<String>asList(new String[]{"apply-templates", // NOI18N
"call-template","apply-imports","for-each","value-of", // NOI18N
"copy-of","number","choose","if","text","copy", // NOI18N
"variable","message","fallback"})); // NOI18N
- Set instructions = new TreeSet(charInstructions);
- instructions.addAll(Arrays.asList(new String[]{"processing-instruction", // NOI18N
+ Set<String> instructions = new TreeSet<>(charInstructions);
+ instructions.addAll(Arrays.<String>asList(new String[]{"processing-instruction", // NOI18N
"comment","element","attribute"})); // NOI18N
- Set charTemplate = charInstructions; // We don't care about PCDATA
+ Set<String> charTemplate = charInstructions; // We don't care about PCDATA
- template = new TreeSet(instructions);
+ template = new TreeSet<>(instructions);
template.add(resultElements);
- Set topLevel = new TreeSet(Arrays.asList(new String[]{"import","include","strip-space", // NOI18N
+ Set<String> topLevel = new TreeSet<>(Arrays.<String>asList(new String[]{"import","include","strip-space", // NOI18N
"preserve-space","output","key","decimal-format","attribute-set", // NOI18N
"variable","param","template","namespace-alias"})); // NOI18N
- Set topLevelAttr = new TreeSet(Arrays.asList(new String[]{"extension-element-prefixes", // NOI18N
+ Set<String> topLevelAttr = new TreeSet(Arrays.<String>asList(new String[]{"extension-element-prefixes", // NOI18N
Review comment:
inferrable type informations
```suggestion
Set<String> topLevelAttr = new TreeSet(Arrays.asList(new String[]{"extension-element-prefixes", // NOI18N
```
strictly speaking the array creation is not needed as well
##########
File path: ide/xsl/src/org/netbeans/modules/xsl/grammar/XSLGrammarQuery.java
##########
@@ -136,33 +136,33 @@ private static Map getElementDecls() {
// Commonly used variables
Set emptySet = new TreeSet();
String spaceAtt = "xml:space"; // NOI18N
- Set tmpSet;
+ Set<String> tmpSet;
////////////////////////////////////////////////
// Initialize common sets
- Set charInstructions = new TreeSet(Arrays.asList(new String[]{"apply-templates", // NOI18N
+ Set<String> charInstructions = new TreeSet<>(Arrays.<String>asList(new String[]{"apply-templates", // NOI18N
"call-template","apply-imports","for-each","value-of", // NOI18N
"copy-of","number","choose","if","text","copy", // NOI18N
"variable","message","fallback"})); // NOI18N
- Set instructions = new TreeSet(charInstructions);
- instructions.addAll(Arrays.asList(new String[]{"processing-instruction", // NOI18N
+ Set<String> instructions = new TreeSet<>(charInstructions);
+ instructions.addAll(Arrays.<String>asList(new String[]{"processing-instruction", // NOI18N
"comment","element","attribute"})); // NOI18N
- Set charTemplate = charInstructions; // We don't care about PCDATA
+ Set<String> charTemplate = charInstructions; // We don't care about PCDATA
- template = new TreeSet(instructions);
+ template = new TreeSet<>(instructions);
template.add(resultElements);
- Set topLevel = new TreeSet(Arrays.asList(new String[]{"import","include","strip-space", // NOI18N
+ Set<String> topLevel = new TreeSet<>(Arrays.<String>asList(new String[]{"import","include","strip-space", // NOI18N
"preserve-space","output","key","decimal-format","attribute-set", // NOI18N
"variable","param","template","namespace-alias"})); // NOI18N
- Set topLevelAttr = new TreeSet(Arrays.asList(new String[]{"extension-element-prefixes", // NOI18N
+ Set<String> topLevelAttr = new TreeSet(Arrays.<String>asList(new String[]{"extension-element-prefixes", // NOI18N
"exclude-result-prefixes","id","version",spaceAtt})); // NOI18N
- resultElementAttr = new TreeSet(Arrays.asList(new String[]{"extension-element-prefixes", // NOI18N
+ resultElementAttr = new TreeSet<>(Arrays.<String>asList(new String[]{"extension-element-prefixes", // NOI18N
Review comment:
inferrable type informations
```suggestion
resultElementAttr = new TreeSet<>(Arrays.asList(new String[]{"extension-element-prefixes", // NOI18N
```
strictly speaking the array creation is not needed as well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on a change in pull request #2556: [NETBEANS-5053] - cleanup Set raw type warnings..
Posted by GitBox <gi...@apache.org>.
BradWalker commented on a change in pull request #2556:
URL: https://github.com/apache/netbeans/pull/2556#discussion_r529021491
##########
File path: ide/xsl/src/org/netbeans/modules/xsl/grammar/XSLGrammarQuery.java
##########
@@ -136,33 +136,33 @@ private static Map getElementDecls() {
// Commonly used variables
Set emptySet = new TreeSet();
String spaceAtt = "xml:space"; // NOI18N
- Set tmpSet;
+ Set<String> tmpSet;
////////////////////////////////////////////////
// Initialize common sets
- Set charInstructions = new TreeSet(Arrays.asList(new String[]{"apply-templates", // NOI18N
+ Set<String> charInstructions = new TreeSet<>(Arrays.<String>asList(new String[]{"apply-templates", // NOI18N
"call-template","apply-imports","for-each","value-of", // NOI18N
"copy-of","number","choose","if","text","copy", // NOI18N
"variable","message","fallback"})); // NOI18N
- Set instructions = new TreeSet(charInstructions);
- instructions.addAll(Arrays.asList(new String[]{"processing-instruction", // NOI18N
+ Set<String> instructions = new TreeSet<>(charInstructions);
+ instructions.addAll(Arrays.<String>asList(new String[]{"processing-instruction", // NOI18N
"comment","element","attribute"})); // NOI18N
- Set charTemplate = charInstructions; // We don't care about PCDATA
+ Set<String> charTemplate = charInstructions; // We don't care about PCDATA
- template = new TreeSet(instructions);
+ template = new TreeSet<>(instructions);
template.add(resultElements);
- Set topLevel = new TreeSet(Arrays.asList(new String[]{"import","include","strip-space", // NOI18N
+ Set<String> topLevel = new TreeSet<>(Arrays.<String>asList(new String[]{"import","include","strip-space", // NOI18N
Review comment:
changed..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on a change in pull request #2556: [NETBEANS-5053] - cleanup Set raw type warnings..
Posted by GitBox <gi...@apache.org>.
BradWalker commented on a change in pull request #2556:
URL: https://github.com/apache/netbeans/pull/2556#discussion_r529044993
##########
File path: ide/xsl/src/org/netbeans/modules/xsl/grammar/XSLGrammarQuery.java
##########
@@ -136,33 +136,33 @@ private static Map getElementDecls() {
// Commonly used variables
Set emptySet = new TreeSet();
String spaceAtt = "xml:space"; // NOI18N
- Set tmpSet;
+ Set<String> tmpSet;
////////////////////////////////////////////////
// Initialize common sets
- Set charInstructions = new TreeSet(Arrays.asList(new String[]{"apply-templates", // NOI18N
+ Set<String> charInstructions = new TreeSet<>(Arrays.<String>asList(new String[]{"apply-templates", // NOI18N
"call-template","apply-imports","for-each","value-of", // NOI18N
"copy-of","number","choose","if","text","copy", // NOI18N
"variable","message","fallback"})); // NOI18N
- Set instructions = new TreeSet(charInstructions);
- instructions.addAll(Arrays.asList(new String[]{"processing-instruction", // NOI18N
+ Set<String> instructions = new TreeSet<>(charInstructions);
+ instructions.addAll(Arrays.<String>asList(new String[]{"processing-instruction", // NOI18N
"comment","element","attribute"})); // NOI18N
- Set charTemplate = charInstructions; // We don't care about PCDATA
+ Set<String> charTemplate = charInstructions; // We don't care about PCDATA
- template = new TreeSet(instructions);
+ template = new TreeSet<>(instructions);
template.add(resultElements);
- Set topLevel = new TreeSet(Arrays.asList(new String[]{"import","include","strip-space", // NOI18N
+ Set<String> topLevel = new TreeSet<>(Arrays.<String>asList(new String[]{"import","include","strip-space", // NOI18N
Review comment:
changed..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists