You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Sudheesh Katkam <sk...@maprtech.com> on 2015/04/14 19:25:06 UTC
Review Request 33177: DRILL-2508: Add new column to sys.options table
that exposes whether or not the current system value is the default
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33177/
-----------------------------------------------------------
Review request for drill.
Repository: drill-git
Description
-------
DRILL-2508: Added a wrapper class for OptionValue to include status
Option status: BOOT, DEFAULT, CHANGED
Diffs
-----
README.md 69da92f
Diff: https://reviews.apache.org/r/33177/diff/
Testing
-------
Thanks,
Sudheesh Katkam
Re: Review Request 33177: DRILL-2508: Add new column to sys.options
table
that exposes whether or not the current system value is the default
Posted by Jason Altekruse <al...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33177/#review82835
-----------------------------------------------------------
Ship it!
Ship It!
- Jason Altekruse
On May 5, 2015, 10:51 p.m., Sudheesh Katkam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33177/
> -----------------------------------------------------------
>
> (Updated May 5, 2015, 10:51 p.m.)
>
>
> Review request for drill and Jason Altekruse.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> [DRILL-2508](https://issues.apache.org/jira/browse/DRILL-2508): Added a wrapper class for OptionValue to include status
> Option status: BOOT, DEFAULT, CHANGED
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/server/options/FallbackOptionManager.java 0af816d
> exec/java-exec/src/main/java/org/apache/drill/exec/server/options/OptionManager.java 1bdc108
> exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SystemOptionManager.java 33b2a4c
> exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/SystemTable.java bd23d81
>
> Diff: https://reviews.apache.org/r/33177/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sudheesh Katkam
>
>
Re: Review Request 33177: DRILL-2508: Add new column to sys.options
table
that exposes whether or not the current system value is the default
Posted by Sudheesh Katkam <sk...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33177/
-----------------------------------------------------------
(Updated May 5, 2015, 10:51 p.m.)
Review request for drill and Jason Altekruse.
Changes
-------
Rebased on current master. Passed all unit tests.
Repository: drill-git
Description
-------
[DRILL-2508](https://issues.apache.org/jira/browse/DRILL-2508): Added a wrapper class for OptionValue to include status
Option status: BOOT, DEFAULT, CHANGED
Diffs (updated)
-----
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/FallbackOptionManager.java 0af816d
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/OptionManager.java 1bdc108
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SystemOptionManager.java 33b2a4c
exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/SystemTable.java bd23d81
Diff: https://reviews.apache.org/r/33177/diff/
Testing
-------
Thanks,
Sudheesh Katkam
Re: Review Request 33177: DRILL-2508: Add new column to sys.options
table
that exposes whether or not the current system value is the default
Posted by Sudheesh Katkam <sk...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33177/
-----------------------------------------------------------
(Updated April 14, 2015, 5:32 p.m.)
Review request for drill and Jacques Nadeau.
Changes
-------
Please review [diff/2/](https://reviews.apache.org/r/33177/diff/2/) (and not [diff/1/](https://reviews.apache.org/r/33177/diff/1/) or [diff/1-2/](https://reviews.apache.org/r/33177/diff/1-2/))
+ Based on top of master and [DRILL-2766](https://issues.apache.org/jira/browse/DRILL-2766)
+ First uploaded a spacing change to README.md for review board to accept (because DRILL-2766 is not merged into master yet)
Repository: drill-git
Description (updated)
-------
[DRILL-2508](https://issues.apache.org/jira/browse/DRILL-2508): Added a wrapper class for OptionValue to include status
Option status: BOOT, DEFAULT, CHANGED
Diffs (updated)
-----
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/FallbackOptionManager.java 45d393c
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/OptionManager.java 4ffe9a3
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SystemOptionManager.java 1a8559e
exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/SystemTable.java 2c338ca
Diff: https://reviews.apache.org/r/33177/diff/
Testing
-------
Thanks,
Sudheesh Katkam